Weizhen Huang weizhen
19 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang approved blender/blender#105022 2023-02-21 16:13:24 +01:00
Fix Light Tree option causing wrong renders on macOS AMD
Weizhen Huang commented on pull request blender/blender#105022 2023-02-21 15:49:36 +01:00
Fix Light Tree option causing wrong renders on macOS AMD

But according to scene.cpp the light manager is updated before the integrator? If light manager is updated after the integrator I agree it would be better to remove the other one. But yes if…

Weizhen Huang commented on pull request blender/blender#105022 2023-02-21 15:16:03 +01:00
Fix Light Tree option causing wrong renders on macOS AMD

I think this line can be deleted.

Weizhen Huang commented on pull request blender/blender#104888 2023-02-21 15:15:38 +01:00
Gizmo: add undo and name

Usually description is used here, but looks rather lengthy if there is already description for RNA properties, so I use name instead.

Weizhen Huang commented on pull request blender/blender#104888 2023-02-21 15:15:38 +01:00
Gizmo: add undo and name

I find this get_unique concept quite strange, it is here because gizmos are allowed to have multiple properties, and if there are multiple I don't know which one just got edited, and could it be that only one of them has undo.

Weizhen Huang commented on pull request blender/blender#104888 2023-02-21 15:15:38 +01:00
Gizmo: add undo and name

I find it a bit confusing that there are two groups of getter/setters. The new transform_set_fn could modify the value, and I don't want to drop the const specifier for value_set_fn. Or could there be better function names?

Weizhen Huang pushed to enable_gizmo_undo at weizhen/blender 2023-02-20 17:24:40 +01:00
2de990a55c Refactor: Gizmo: transform RNA properties in light gizmos
53a0946b2e Refactor: Gizmo: update area light size via RNA instead of setting manually
55826ea5a6 Gizmo: display gizmo name in tooltip
4a7fc3d5b2 Gizmo: enable undo for light gizmos
b2e6a6c987 Cleanup: use available #wmGizmoPropertyFnParams
Compare 56 commits »
Weizhen Huang commented on issue blender/blender#104280 2023-02-20 13:21:19 +01:00
Improve visualisation and manipulation of lights in the viewport

@slwk1d thank you for your feedback.

  • Point light theoretically should have a radius of 0, so I don't see a problem of a default value of 0. But it seems a bug that the move gizmo is drawn over…
Weizhen Huang pushed to main at blender/blender 2023-02-17 19:17:10 +01:00
d6774174e9 Fix compile error due to previous changes
Weizhen Huang opened issue infrastructure/blender-projects-platform#42 2023-02-17 16:29:30 +01:00
Same command line instructions for "Rebase then fast-forward" and "Create squash commit"
Weizhen Huang created pull request blender/blender#104888 2023-02-17 16:21:41 +01:00
Gizmo: add undo and name
Weizhen Huang created branch enable_gizmo_undo in weizhen/blender 2023-02-17 16:18:00 +01:00
Weizhen Huang pushed to enable_gizmo_undo at weizhen/blender 2023-02-17 16:18:00 +01:00
c1ae1ac248 Gizmo: display gizmo name in tooltip
4816f7c02c Gizmo: enable undo for light gizmos
ca2d347b4c Cleanup: use available #wmGizmoPropertyFnParams
08f24553dc Cleanup: Remove accidentally merged TODO comment
7838eb12c6 Merge branch 'blender-v3.5-release'
Compare 10 commits »
Weizhen Huang deleted branch shift_uniform_scale from weizhen/blender 2023-02-14 11:21:43 +01:00
Weizhen Huang commented on pull request blender/blender#104418 2023-02-14 11:21:32 +01:00
Gizmo: press shift key to scale area lights uniformly

The pull request has been merged as a3e6cb5dab

Weizhen Huang closed pull request blender/blender#104418 2023-02-14 11:21:32 +01:00
Gizmo: press shift key to scale area lights uniformly
Weizhen Huang pushed to main at blender/blender 2023-02-14 11:19:27 +01:00
a3e6cb5dab Gizmo: press shift key to scale cage2d gizmo uniformly
Weizhen Huang pushed to shift_uniform_scale at weizhen/blender 2023-02-14 11:02:48 +01:00
67cb09357e Merge branch 'main' into shift_uniform_scale
fe0a219b5b Revert: Formatting changes space_toolsystem_toolbar
09498264f6 Deps: build one at a time, each using all available cores on Linux
46c34ba1f6 GNUmakefile: include install directory in 'make deps' message
d02f863b18 Update RNA to User manual mappings
Compare 36 commits »
Weizhen Huang pushed to show_gizmo_constraint at weizhen/blender 2023-02-13 19:21:24 +01:00
a6eab432eb Gizmo: draw thicker lines on cage2d edges when hovering to indicate constraint axis
Weizhen Huang created branch show_gizmo_constraint in weizhen/blender 2023-02-13 19:21:23 +01:00