@OmarEmaraDev @Sergey maybe you have opinions here too...
ELEM is used in other places for single element comparison. I'm leaving out node_gizmo.cc, to better conform with the coding style rule "When making changes, conform to the style and…
Ideally we shouldn't need that flag at all, since all operations can be constant, and the flag is_constant_operation exists for operations that are definately constant.
I will refactor in…
I can reproduce the freeze, Blender shows following error:
Did you save the 3.6 with that addon enabled? I think Blender should not…
does it make sense to set
can_be_constantto true by default? That could work too, I was hoping this way shows the behavior more explicitly in operations. I don't have a strong opinion…
Change type, manually free storage and add output socket.... isn't deleting and constructing a new node cleaner at this point? :)
CONVERTER and FILTER don't sound right either... Switch node also uses NODE_CLASS_LAYOUT. Do you suggest I change that as well (in a separate patch) ?
I'm not sure how to achieve that. node doesn't have an output socket so linking to viewer node doesn't work. So I took version_geometry_nodes_replace_transfer_attribute_node() from `versioning_…
That's the setup I tried to demonstrate in my previous post. For some reason images are not showing properly...
I don't think we can cover that case using the way constant folding is implemented…
Not sure if this answers your question, but levels is not included in this patch, so when connected to an image it will behave as before, but when it's input is not connected to an input it will…
@Jeroen-Bakker do you know the historic reasons behind limiting the image size for scale operation? I was not able to get Blender to crash when scaling images with very large factors, but the…
The GPU compositor uses the domain of the first linked input, the Full Frame Compositor was also designed like this from the start,.
This doesn't make sense to me for though, at least for…
Constant folding of the node graph happens every time COM_execute() gets called. It replaces operations such as TranslateOperation with ConstantOperation at runtime, right after building the…