Manager: Fix invalid null assertion #104307
No reviewers
Labels
No Label
Good First Issue
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Job Type
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: studio/flamenco#104307
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "abelli/flamenco:invalid-null"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Overview
This patch removes the null check of a condition that evaluates if a string variable is empty.
In JavaScript, empty strings are truthy values compared to null.
Request
Tests
Thanks for the fix!
Another one for the tests: just
console.log(null || '')
-- it'll log<empty string>
.When
A
is falsey,A || B
evaluates toB
-- in this case the expression evaluates to the empty string. SocustomBlenderExe != (null || '')
is exactly the same ascustomBlenderExe != ''
.In this case
customBlenderExe
is just a string, so there is no need to compare withnull
anyway.