Alexander Brock Alexander-Brock
0 Followers · 0 Following

  • I studied computer science at Heidelberg University. Now I'm working on camera calibration for RabbitAI GmbH.

  • Joined on 2024-06-17
Repositories
2
 Projects Public Activity Starred Repositories
Alexander Brock pushed to test-panorama-roundtrip at Alexander-Brock/blender 2024-07-01 22:49:56 +02:00
118c929037 Fix order of includes
Alexander Brock commented on pull request blender/blender#123932 2024-07-01 18:51:15 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

Build error on Darwin:

source/kernel/camera/projection.h:66:25: error: no matching function for call to 'safe_normalize'^[[0m
  const float2 uv = r * safe_normalize(make_float2(dir.y,…
Alexander Brock commented on pull request blender/blender#123932 2024-07-01 15:59:07 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

I don't see results of the build bot, does it work?

Alexander Brock pushed to test-panorama-roundtrip at Alexander-Brock/blender 2024-07-01 15:17:33 +02:00
c1f674d439 Remove special handling of FisheyeEquisolid
80a140f457 Increase error threshold so the tests pass on Windows
Compare 2 commits »
Alexander Brock pushed to test-panorama-roundtrip at Alexander-Brock/blender 2024-07-01 14:11:20 +02:00
a2a3853a22 Make equirectangular_to_direction easier to read
Alexander Brock pushed to test-panorama-roundtrip at Alexander-Brock/blender 2024-07-01 00:04:38 +02:00
95bab73288 Simplify equiangular_cubemap_face_to_direction
Alexander Brock commented on pull request blender/blender#123932 2024-07-01 00:00:11 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

Third possibility: Add a function len(float, float) to math_float2.h:

ccl_device_inline float len(const float x, const float y)
{
  return sqrtf(sqr(x) + sqr(y));
}

Which…

Alexander Brock commented on pull request blender/blender#123932 2024-06-30 23:15:20 +02:00
Add round-trip tests for *_to_direction functions and fix some of them

Alternative idea: len(make_float2(dir.y, dir.z))

Alexander Brock created pull request blender/blender#123932 2024-06-29 01:43:49 +02:00
Add round-trip tests for *_to_direction functions and fix some of them
Alexander Brock pushed to test-panorama-roundtrip at Alexander-Brock/blender 2024-06-29 00:58:26 +02:00
2061cd7f17 Replace usage of safe_normalize by normalize because it's guaranteed to be safe
Alexander Brock pushed to test-panorama-roundtrip at Alexander-Brock/blender 2024-06-29 00:46:23 +02:00
894bf1feba Simplify direction_to_equiangular_cubemap_face
1fa3309606 Fix normalization error in equiangular_cubemap_face_to_direction
c5a6c7b549 Fix mirror bug in direction_to_fisheye_equisolid
309392de0d Fix mirror bug in direction_to_fisheye
75095551b6 Fix bug in spherical_to_direction
Compare 10 commits »
Alexander Brock created branch test-panorama-roundtrip in Alexander-Brock/blender 2024-06-29 00:46:23 +02:00
Alexander Brock pushed to test-flepo at Alexander-Brock/blender 2024-06-28 15:41:51 +02:00
2fef02cd4f Add missing include
Alexander Brock pushed to test-flepo at Alexander-Brock/blender 2024-06-28 14:43:17 +02:00
aa042b6170 Add missing include
Alexander Brock commented on pull request blender/blender#123737 2024-06-28 13:40:26 +02:00
Fix and test direction_to_fisheye_lens_polynomial

Could someone trigger the build?

Alexander Brock pushed to test-flepo at Alexander-Brock/blender 2024-06-28 12:31:46 +02:00
5e9375ade9 Replace initializer lists by make_float2/3
Alexander Brock commented on pull request blender/blender#123737 2024-06-28 12:26:05 +02:00
Fix and test direction_to_fisheye_lens_polynomial

The round-trip error on Windows for the x-coordinate went down from 1.5e-4 to below 1e-6, I suspect because of the removal of the trigonometry. I increased the threshold for the y-coordinate to…

Alexander Brock pushed to test-flepo at Alexander-Brock/blender 2024-06-28 12:21:47 +02:00
bc91c4d927 Increase error threshold because of Windows somehow handling floats differently
2a0e43ed32 Add f suffix to all float constants
Compare 2 commits »
Alexander Brock pushed to test-flepo at Alexander-Brock/blender 2024-06-28 11:26:31 +02:00
60ba509bfb Remove usage of math constants from GNU extensions
Alexander Brock pushed to test-flepo at Alexander-Brock/blender 2024-06-28 10:51:13 +02:00
55cb485ac4 Add math constants from GNU extensions