-
I studied computer science at Heidelberg University. Now I'm working on camera calibration for RabbitAI GmbH.
- Joined on
2024-06-17
I accidentally used the GNU extensions for math constants. I think I fixed it, could someone trigger the build?
I removed the early return and use safe_normalize, could you trigger the build so I can look more into why the tests fail on Windows?
I agree and changed it, but it lead to NaN being returned in the center, so I added early return near the center:
if (dir.y < 1e-8f && dir.y > -1e-8f && dir.z < 1e-8f && dir.z > -1e-8f)…Every time I add commits and push them I get this message from git:
alexander@cadence:~/rabbit/blender$ git push
Enumerating objects: 17, done.
Counting objects: 100% (17/17), done.
Delt…@Sergey I added 2 test cases which test symmetry and hand-crafted values for fisheye_lens_polynomial_to_direction, could you re-run the test?
Interesting, the test fails on Windows. For the y coordinate the error is ~2.7e-6 which might be some kind of difference in handling of float operations, but for the x coordinate it is ~1.5e-4…
General questions:
- When fixing small stuff like float suffix, constness, names, etc. should I amend the previous commit and force-push it?
- Should I click "Resolve conversation" when I…
I changed it. Usually I prefer the assertions, because I often have hundreds of (pseudo-randomly generated) tests so when I introduce a sign error or similar I get thousands of lines telling me my…
I made everything as const as possible now, the reason I didn't in the first place was that I change k2 in the test-loop because it's zero in all my test cases.