Ben-7
0 Followers · 0 Following
  • Joined on 2024-04-05
Repositories
2
 Projects Public Activity Starred Repositories
Ben-7 commented on pull request blender/blender#125101 2024-07-19 19:56:22 +02:00
Alternative method for finding openmp with clang-cl compiler on windows

Sounds good. I've removed attempting to get LLVMROOT via registry key.

Ben-7 pushed to clangcl-openmp-fix at Ben-7/blender 2024-07-19 19:54:21 +02:00
bb87ebceff removed locating llvmroot by registry
Ben-7 created pull request blender/blender#125101 2024-07-19 19:00:43 +02:00
Alternative method for finding openmp with clang-cl compiler on windows
Ben-7 pushed to clangcl-openmp-fix at Ben-7/blender 2024-07-19 18:54:58 +02:00
59ffbd8278 alternative method for finding openmp with clang-cl compiler on windows
Ben-7 pushed to clangcl-openmp-fix at Ben-7/blender 2024-07-19 18:49:33 +02:00
fe5248d045 alternative method for finding openmp with clang-cl compiler on windows
615f4a7d4e Cleanup: Vulkan: Remove unused variable
0ee46f1208 Refactor: Sculpt: Expose per-pbvh type unique face set methods
41430ed4bd Cleanup: Split strip foreground drawing function
7a6a2519c5 Refactor: SubdivCCG: Extract utility method for boundary calculation
Compare 10 commits »
Ben-7 created branch clangcl-openmp-fix in Ben-7/blender 2024-07-19 18:49:33 +02:00
Ben-7 deleted branch x86-clang-support from Ben-7/blender 2024-04-25 18:44:29 +02:00
Ben-7 created repository Ben-7/lib-windows_x64 2024-04-25 18:43:26 +02:00
Ben-7 commented on pull request blender/blender#120317 2024-04-22 20:26:16 +02:00
x86-clang-support

No particular reason. I've removed them in edd2f667b961e02d106bdc67822fc51cc0603a6c

Ben-7 commented on pull request blender/blender#120317 2024-04-22 20:25:19 +02:00
x86-clang-support

I've refactored removing all commits associated with the manifest embedding and updated to the current main. I also removed the parentheses for the NOT(MSVC_CLANG) cmake sections.

I can…

Ben-7 pushed to x86-clang-support at Ben-7/blender 2024-04-22 20:23:02 +02:00
90b7958ae8 clang-cl: added missing with_tbb for LIBCPP_VERSION define
Ben-7 pushed to x86-clang-support at Ben-7/blender 2024-04-22 19:49:51 +02:00
edd2f667b9 clang-cl: removed parentheses around not msvc_clang
2149ae0657 set clang cmake args in win32 to clangcl
08a182c99e clang-cl: now using msvc_clang to check compiler. Checking WITH_TBB for tbb fix
1c3043c741 apply work around only when tbb version < 12
95ac3e359f clang-cl: removed strippedpd
Compare 197 commits »
Ben-7 pushed to x86-clang-support at Ben-7/blender 2024-04-18 00:55:15 +02:00
3395e85656 set clang cmake args in win32 to clangcl
Ben-7 commented on pull request blender/blender#120317 2024-04-16 07:09:06 +02:00
x86-clang-support

I also ran into that issue with an older version of clang. If it's necessary to have older clang versions functioning, I can push a fix for the casting errors.

For the manifest post build step:…

Ben-7 commented on pull request blender/blender#120317 2024-04-16 06:59:46 +02:00
x86-clang-support

I've pulled in new commits from main including that PR and have dropped the commits affecting these lines.

Ben-7 commented on pull request blender/blender#120317 2024-04-16 06:56:18 +02:00
x86-clang-support

Added extract WITH_TBB check in 8556e4147f110.

Ben-7 commented on pull request blender/blender#120317 2024-04-16 06:55:34 +02:00
x86-clang-support

Good question. Switched both checks using CMAKE_C_COMPILER_ID to MSVC_CLANG in 8556e4147f110.

Ben-7 pushed to x86-clang-support at Ben-7/blender 2024-04-16 06:52:06 +02:00
5c3e37dbb3 clang-cl: stopped blender.exe.manifest from being embedded into blender-launcher
8556e4147f clang-cl: now using msvc_clang to check compiler. Checking WITH_TBB for tbb fix
b44a7169c8 MSVC: use external manifest for blender.exe
444e294e2e removed post build step
9ca7c4353a clang-cl:added _LIBCPP_VERSION define to resolve tbb header errors
Compare 296 commits »
Ben-7 commented on pull request blender/blender#120317 2024-04-15 23:24:13 +02:00
x86-clang-support

Your PR resolves the problem without needing the post build step.

However, blender-launcher fails to compile properly since the [manifest was left as a dependency](https://projects.blender.org/…

Ben-7 commented on pull request blender/blender#120317 2024-04-10 20:09:03 +02:00
x86-clang-support

I've committed your recommendation. I attempted to build with the latest version of opentbb but due to changes in namespaces - e.g. tbb::task becoming tbb::detail:d1::task - I needed to omit…