Bill-Spitzak
  • Joined on 2024-02-16
Bill-Spitzak commented on pull request blender/blender#124928 2024-07-19 00:07:00 +02:00
Fix #124842: Prevent rounding errors from introducing black pixels in Translate

It does not change the extend if wrapping is enabled.

However I think this does not work for non-integer translations. Going to test this now.

In my opinion the correct fix is to fix the CPU…

Bill-Spitzak pushed to translate at Bill-Spitzak/blender 2024-07-17 23:48:57 +02:00
6280f0f724 Fix #124842: Prevent rounding errors from introducing black pixels in Translate
Bill-Spitzak pushed to translate at Bill-Spitzak/blender 2024-07-17 22:35:08 +02:00
3a9b68e034 Fix #124842: Prevent rounding errors from introducing black pixels in Translate
Bill-Spitzak created pull request blender/blender#124928 2024-07-17 22:31:56 +02:00
Fix #1243549: Prevent rounding errors from introducing black pixels in Translate
Bill-Spitzak created branch translate in Bill-Spitzak/blender 2024-07-17 22:31:05 +02:00
Bill-Spitzak pushed to translate at Bill-Spitzak/blender 2024-07-17 22:31:05 +02:00
eb690e0b53 Fix #1243549: Prevent rounding errors from introducing black pixels in Translate
Bill-Spitzak commented on issue blender/blender#124842 2024-07-17 22:22:22 +02:00
CPU compositor Translate sets left and bottom edge to blank pixels

I found a quick fix to COM_TranslateOperation.cc.

However the proper fix is to change the sampling code to do Clip correctly. I'm not sure if this is worth doing however as I suspect the plan…

Bill-Spitzak opened issue blender/blender#124842 2024-07-17 06:45:14 +02:00
CPU compositor Translate sets left and bottom edge to blank pixels
Bill-Spitzak commented on pull request blender/blender#124381 2024-07-17 06:36:57 +02:00
Fix #124133: Transforms shift due to incorrect floor()

blender/blender#124841 is a patch that appears to work. This seems less intrusive than changing the translation of odd domains.

Bill-Spitzak created pull request blender/blender#124841 2024-07-17 06:35:16 +02:00
WIP: do the 1/2 pixel translation only in RealizeOnDomainOperation
Bill-Spitzak created branch resolveshift in Bill-Spitzak/blender 2024-07-17 06:32:08 +02:00
Bill-Spitzak pushed to resolveshift at Bill-Spitzak/blender 2024-07-17 06:32:08 +02:00
b3b2014f14 Put the .5 shift into RealizeOnDomainOperation
6c2b76e768 Fix sampling calls in CPU compositor
ee0d542e15 Use the "nearest" filter if possible
8ec8430a92 Compute full transform including corner offsets outside glsl
2da2dd133a Fix #124133: Transforms shift due to incorrect floor()
Compare 6 commits »
Bill-Spitzak commented on pull request blender/blender#124381 2024-07-17 05:02:53 +02:00
Fix #124133: Transforms shift due to incorrect floor()

I have a new idea for fixing your example. This will not involve shifting odd-sized domains. Instead a "resolve" used to match up multiple domains, where there is no transform, will translate by…

Bill-Spitzak commented on pull request blender/blender#124381 2024-07-17 04:50:09 +02:00
Fix #124133: Transforms shift due to incorrect floor()

I added some fixes for the CPU compositor to make it match the GPU compositor more. IMHO the GPU compositor is correct, the CPU compositor was wrong.

Bill-Spitzak pushed to main at Bill-Spitzak/blender 2024-07-17 03:31:37 +02:00
c1f77d7d86 Fix sampling calls in CPU compositor
bad2dab394 Use the "nearest" filter if possible
a808eed03c Compute full transform including corner offsets outside glsl
7f1c21e6db Fix #124133: Transforms shift due to incorrect floor()
b8eb872583 Sculpt: Simplify gathering of position data
Compare 59 commits »
Bill-Spitzak commented on pull request blender/blender#124760 2024-07-16 22:06:31 +02:00
WIP: halfpixel shift for odd domains

PS: Every other piece of software I have worked on or tested will blur the image if an attempt is made to center an odd-sized image in an even-sized one. Generally the user "fixes" this by…

Bill-Spitzak commented on pull request blender/blender#124760 2024-07-16 21:55:12 +02:00
WIP: halfpixel shift for odd domains

Yes this is on purpose. If the pixels between two images do not line up, one must be filtered. So the odd sized image must be moved so the pixels line up. IMHO there is absolutely no way around…

Bill-Spitzak commented on issue blender/blender#124133 2024-07-16 07:37:18 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

See #124760 for a patch that adds the 1/2 pixel shift for odd-sized domains, fixing the example.

Bill-Spitzak created pull request blender/blender#124760 2024-07-16 06:06:54 +02:00
WIP: halfpixel shift for odd domains