Bill-Spitzak
  • Joined on 2024-02-16
Bill-Spitzak commented on pull request blender/blender#124381 2024-07-09 22:27:06 +02:00
Fix #124133: Transforms shift due to incorrect floor()

Pushed version with minimal changes to the code. I did delete a comment referring to the removed code.

Bill-Spitzak pushed to main at Bill-Spitzak/blender 2024-07-09 22:25:28 +02:00
8e00bda301 Fix #124133: Transforms shift due to incorrect floor()
Bill-Spitzak commented on pull request blender/blender#124381 2024-07-09 22:20:18 +02:00
Fix #124133: Transforms shift due to incorrect floor()

Actually the original code had vec2(...) / 2.0 which apparently is compiling everywhere so I'm not convinced that the vec2(...) + 0.5 needs a cast. Seems likely addition and division are…

Bill-Spitzak commented on pull request blender/blender#124381 2024-07-09 22:17:39 +02:00
Fix #124133: Transforms shift due to incorrect floor()

The comments are from a second patch, I'll remove that. And remove unnecessary changes.

I'm curious what platforms the automatic cast to vec does not compile on? Though I believe it is harmless…

Bill-Spitzak pushed to main at Bill-Spitzak/blender 2024-07-09 06:26:53 +02:00
664f4d5b95 Changes to comments in compositor_realize_on_domain.glsl
Bill-Spitzak commented on issue blender/blender#124133 2024-07-09 03:05:56 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

I'm reopening because I was able to fix it. See pull request

Bill-Spitzak reopened issue blender/blender#124133 2024-07-09 03:05:21 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel
Bill-Spitzak created pull request blender/blender#124381 2024-07-09 03:02:38 +02:00
Fix #124133: Transforms shift due to incorrect floor()
Bill-Spitzak pushed to main at Bill-Spitzak/blender 2024-07-09 02:53:58 +02:00
4b0e86b531 Fix #124133: Transforms shift due to incorrect floor()
bbcc720c13 Fix: Property search crash after recent allocator change
61db25b78e Fix: Linker error in lite build with OBJ import node
e474eef5d1 Cleanup: Formatting
28d3f7f638 Cleanup: Sculpt: Remove unused PBVH variables
Compare 4790 commits »
Bill-Spitzak commented on issue blender/blender#124133 2024-07-08 22:01:35 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

I do not believe the limitation to bilinear sampling is causing this problem, as it would only lead to identical artifacts at each end of an integer-sized rescale, and this effect is off-center.

Bill-Spitzak commented on issue blender/blender#124133 2024-07-06 05:03:15 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

Further investigation reveals that this is a general compositor problem with the Scale node. It looks like scales that would produce a non-integer result size do not make an accurate scale, and…

Bill-Spitzak commented on issue blender/blender#124133 2024-07-05 17:29:33 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

My mistake was I did a save-as for the image in order to compare it with the composite in an external program, I did not know this unpacked it.

Bill-Spitzak commented on issue blender/blender#124133 2024-07-05 17:28:12 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

This one proved to work (I deleted the on-disk texture) and I switched the main pain back to the 3D view.

Bill-Spitzak commented on issue blender/blender#124133 2024-07-04 21:37:16 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

It looks like I did not save the image with the white edges, here is an updated .blend file. I also made it scale the background in all cases by making the render output

It appears that…

Bill-Spitzak commented on issue blender/blender#124133 2024-07-04 21:05:34 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

Figure out a way to toggle between the composite view and the background image, and the offset is obvious.

Bill-Spitzak reopened issue blender/blender#124133 2024-07-04 21:04:34 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel
Bill-Spitzak commented on issue blender/blender#124133 2024-07-04 21:04:29 +02:00
Compositor transform/realize can shift image by 1/2 an input pixel

No I am not talking about the problem when portions of the display window are clipped.

The problem is there appears to be an offset of about 1 pixel (or maybe 1/2 pixel) between the viewport…

Bill-Spitzak opened issue blender/blender#124133 2024-07-04 05:34:55 +02:00
Images in compositor do not align with Viewport background images
Bill-Spitzak commented on issue blender/blender#124071 2024-07-04 04:23:13 +02:00
Viewport compositor scales background images incorrectly

I agree, I was confused because for some reason my viewport was very close to 1:1 scale with the render, producing slight offsets. If I had zoomed it in/out I probably would have figured out what…

Bill-Spitzak commented on issue blender/blender#124071 2024-07-03 02:15:19 +02:00
Viewport compositor scales background images incorrectly

For the life of me I cannot figure out how to make it alpha composite the render atop the background. It acts like the alpha is 1.0 everywhere in the render. For this example I set the Fac of the…