DagerD/blender
1
1
Fork 0
forked from blender/blender
Code Pull Requests Activity

MaterialX: Implement export of Input nodes #20

Merged
Bogdan Nagirniak merged 26 commits from Vasyl-Pidhirskyi/blender:BLEN-530 into matx-export-material 2023-09-15 19:55:37 +02:00
Conversation 0 Commits 26 Files Changed 20 +4 -4
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b5343a4d79 - Show all commits

4
source/blender/nodes/shader/nodes/node_shader_geometry.cc
View File

@ -65,11 +65,11 @@ NODE_SHADER_MATERIALX_BEGIN
NodeItem res = empty(); NodeItem res = empty();
std::string name = socket_out_->name; std::string name = socket_out_->name;
BogdanNagirniak marked this conversation as resolved
Bogdan Nagirniak commented 2023-09-13 17:21:15 +02:00
Review
Copy Link

maybe std::string name = socket_out_->name ?

maybe std::string name = socket_out_->name ?
if (name == "Position"){ if (name == "Position") {
res = create_node("position", NodeItem::Type::Vector3); res = create_node("position", NodeItem::Type::Vector3);
res.set_input("space", val(std::string("world"))); res.set_input("space", val(std::string("world")));
} }
else if (name =="Normal"){ else if (name == "Normal") {
res = create_node("normal", NodeItem::Type::Vector3); res = create_node("normal", NodeItem::Type::Vector3);
res.set_input("space", val(std::string("world"))); res.set_input("space", val(std::string("world")));
} }

4
source/blender/nodes/shader/nodes/node_shader_uvmap.cc
View File

@ -71,8 +71,8 @@ NODE_SHADER_MATERIALX_BEGIN
#ifdef WITH_MATERIALX #ifdef WITH_MATERIALX
{ {
BogdanNagirniak marked this conversation as resolved
Bogdan Nagirniak commented 2023-09-13 17:32:14 +02:00
Review
Copy Link

I think it is implemented here, use NOTE that other properties of node are unsupported

I think it is implemented here, use NOTE that other properties of node are unsupported
/* NODE: "From Instances" not implemented /* NODE: "From Instances" not implemented
* UV selection not implemented * UV selection not implemented
*/ */
return texcoord_node(); return texcoord_node();
} }
#endif #endif