View transforms like Filmic and AgX assume that 1.0 is the maximum and fit HDR values into the 0..1 range with a gradual roll-off.
I would like to point out that a properly done HDR version…
You shouldn't change the display device to something that is not your monitor hardware that you are staring at right now.
It triggers [H-K effect](https://en.wikipedia.org/wiki/Helmholtz%E2%80%9…
It seems you applied extreme power curve after view transform. It's completely normal for view transforms to show this kind of breakage under this kind of setting. ARRI Reveal (ARRI Alexa 35's…
Having a PR seems like a good idea nevertheless, as it allows to easily make testable builds.
After giving some thoughts, I feel the need to do more exploration before making any more PRs…
Aside from adding comments explaining the Luminance Compensation * transforms
I did write it in the space's description though.
`Offset the negative values in BT.2020 and compensate for…
My reasoning is that Troy's original config didn't have AgX Log as view transform anyways. And I also have concerns about different forks for AgX don't have interchangeable AgX Logs, there is…
I am fine with leaving the upper Guard Rail and the Guard Rail
view transforms out, especially since I have baked the AgX views into single LUTs, now the components are not as interwoven together.
Maybe just call it "Lower Guard Rail"? It's split from the Guard Rail (lower + higher) from the first place.
Ok I just stayed up the entire night addressing the things pointed out.
Guard Rail, on the other hand, has a significant shoulder, which is more tone-mapping-like and seems unnecessary. If…
The contrast Looks are pivoted on linear 0.18 middle grey, but some user doesn't necessary like that behavior. The punchy look is a different kind of contrast as it darkens the entire image. As…
Yes there is a power 2.4 curve baked in, the reason was more for precision, as tested it seems outputting linear values causes lower precision.
I just thought we should have something to replace Filmic Log
, but if you confirm we should not include either AgX Log
or Filmic Log
I am fine with removing it.
It calculates luminance of the RGB values, offsets target RGB values upwards globally until there is no negative, and then restore the luminance. So it should be a chromaticity-linear "clipping"…
No because then when the view is AgX, the look menu will feature both AgX's and Filmic's Look. You will have too High Contrast
s in the menu, this will be super confusing.
There was supposed to be another matrix after the LUT, and then apply display device's Guard Rail. But now they are all baked inside of this one single LUT.