Zijun Zhou Eary
  • Joined on 2019-09-02
Zijun Zhou closed issue blender/blender#109938 2023-08-29 09:52:05 +02:00
OCIO Grading Primary Transform Error on Metal Shder
Zijun Zhou commented on issue blender/blender#109938 2023-08-29 09:52:02 +02:00
OCIO Grading Primary Transform Error on Metal Shder

Should be fixed by 259bfc4553

Zijun Zhou commented on issue blender/blender#105714 2023-08-26 01:40:15 +02:00
Supporting HDR workflows in Blender

View transforms like Filmic and AgX assume that 1.0 is the maximum and fit HDR values into the 0..1 range with a gradual roll-off.

I would like to point out that a properly done HDR version…

Zijun Zhou commented on issue blender/blender#111453 2023-08-24 10:06:39 +02:00
is Agx working as expected?

You shouldn't change the display device to something that is not your monitor hardware that you are staring at right now.

It triggers [H-K effect](https://en.wikipedia.org/wiki/Helmholtz%E2%80%9…

Zijun Zhou commented on issue blender/blender#111453 2023-08-24 09:02:49 +02:00
is Agx working as expected?

It seems you applied extreme power curve after view transform. It's completely normal for view transforms to show this kind of breakage under this kind of setting. ARRI Reveal (ARRI Alexa 35's…

Zijun Zhou commented on pull request blender/blender#106355 2023-08-22 14:00:59 +02:00
Replace Default OCIO config with AgX (Filmic v2)

The last PR has been posted: #111380

Zijun Zhou created pull request blender/blender#111380 2023-08-22 13:58:35 +02:00
Shrink Filmic LUT size down without noticeable difference
Zijun Zhou commented on pull request blender/blender#111099 2023-08-22 11:51:55 +02:00
AgX-Step5: Add AgX and its components

Having a PR seems like a good idea nevertheless, as it allows to easily make testable builds.

After giving some thoughts, I feel the need to do more exploration before making any more PRs…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-21 19:11:27 +02:00
AgX-Step5: Add AgX and its components

Aside from adding comments explaining the Luminance Compensation * transforms

I did write it in the space's description though.

`Offset the negative values in BT.2020 and compensate for…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-18 11:48:03 +02:00
AgX-Step5: Add AgX and its components

My reasoning is that Troy's original config didn't have AgX Log as view transform anyways. And I also have concerns about different forks for AgX don't have interchangeable AgX Logs, there is…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-18 10:40:43 +02:00
AgX-Step5: Add AgX and its components

I am fine with leaving the upper Guard Rail and the Guard Rail view transforms out, especially since I have baked the AgX views into single LUTs, now the components are not as interwoven together.

Zijun Zhou commented on pull request blender/blender#111099 2023-08-17 20:09:16 +02:00
AgX-Step5: Add AgX and its components

Maybe just call it "Lower Guard Rail"? It's split from the Guard Rail (lower + higher) from the first place.

Zijun Zhou commented on pull request blender/blender#111099 2023-08-17 02:35:49 +02:00
AgX-Step5: Add AgX and its components

Ok I just stayed up the entire night addressing the things pointed out.

Guard Rail, on the other hand, has a significant shoulder, which is more tone-mapping-like and seems unnecessary. If…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-17 02:03:58 +02:00
AgX-Step5: Add AgX and its components

The contrast Looks are pivoted on linear 0.18 middle grey, but some user doesn't necessary like that behavior. The punchy look is a different kind of contrast as it darkens the entire image. As…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-17 02:01:05 +02:00
AgX-Step5: Add AgX and its components

Yes there is a power 2.4 curve baked in, the reason was more for precision, as tested it seems outputting linear values causes lower precision.

Zijun Zhou commented on pull request blender/blender#111099 2023-08-17 01:56:13 +02:00
AgX-Step5: Add AgX and its components

I just thought we should have something to replace Filmic Log, but if you confirm we should not include either AgX Log or Filmic Log I am fine with removing it.

Zijun Zhou commented on pull request blender/blender#111099 2023-08-17 01:52:36 +02:00
AgX-Step5: Add AgX and its components

It calculates luminance of the RGB values, offsets target RGB values upwards globally until there is no negative, and then restore the luminance. So it should be a chromaticity-linear "clipping"…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-16 15:03:26 +02:00
AgX-Step5: Add AgX and its components

No because then when the view is AgX, the look menu will feature both AgX's and Filmic's Look. You will have too High Contrasts in the menu, this will be super confusing.

Zijun Zhou commented on pull request blender/blender#111099 2023-08-16 15:02:16 +02:00
AgX-Step5: Add AgX and its components

There was supposed to be another matrix after the LUT, and then apply display device's Guard Rail. But now they are all baked inside of this one single LUT.

Zijun Zhou commented on pull request blender/blender#111099 2023-08-16 15:00:56 +02:00
AgX-Step5: Add AgX and its components

Yes this is what the matrix is for, it's a rotation + inset.