Zijun Zhou Eary
  • Joined on 2019-09-02
Zijun Zhou commented on pull request blender/blender#111099 2023-08-16 14:59:11 +02:00
AgX-Step5: Add AgX and its components

The LUT is not really invertible, it is like the "smart clip" as how it was called in another discussion. You cannot just "unclip" something after they are clipped. This "smart clip" is used in…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-15 16:57:31 +02:00
AgX-Step5: Add AgX and its components

Not bug, like how Filmic sRGB was "added as texture colorspace" some time ago by removing its family: display, it is a hack by nature but it works in a lot of cases. Though it's important to…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-15 16:29:03 +02:00
AgX-Step5: Add AgX and its components

Inverse of view transform is a hack by nature anyways. And sometimes it also doesn't make sense to require inverse, The False Color for example. Hiding Guard Rails and False Color from the…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-15 15:25:11 +02:00
AgX-Step5: Add AgX and its components

A lot of color spaces define both from_scene_reference and to_scene_reference

This is by design since some LUTs are not reversible.

P.S. Also, is only now I've noticed it for the Filmic…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-15 14:27:48 +02:00
AgX-Step5: Add AgX and its components

Just updated the optimized LUTs. All LUTs are sized down, and some have changed shaper curve to optimize for precision. AgX view transforms now each use their own packed LUT. Although I would…

Zijun Zhou commented on pull request blender/blender#111099 2023-08-15 10:23:46 +02:00
AgX-Step5: Add AgX and its components

Yes I have been trying to optimize the LUTs, and yes some info about time cost can be helpful.

Zijun Zhou commented on pull request blender/blender#111099 2023-08-14 12:19:07 +02:00
AgX-Step5: Add AgX and its components

I see change in the startup.blend. Is it for making the AgX the default view? If so, I think current preferred way is to go via versioning_defaults.c. I can help with that.

Oh didn't know…

Zijun Zhou commented on pull request blender/blender#106355 2023-08-14 03:16:52 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Step 5 PR has been posted #111099

Zijun Zhou created pull request blender/blender#111099 2023-08-14 03:16:05 +02:00
AgX-Step5: Add AgX and its components
Zijun Zhou commented on pull request blender/blender#110941 2023-08-09 15:52:41 +02:00
AgX-Step4: Add and Rename Colorspaces

do you mind updating the description to reflect the updated state of added and renamed color spaces? That will help a lot for the final commit message :)

Sure, done.

Zijun Zhou commented on pull request blender/blender#110941 2023-08-09 13:46:53 +02:00
AgX-Step4: Add and Rename Colorspaces

I believe all comments are addressed. Though I left Linear DCI-P3 D65 to have D65 in its name since we are not using the Theater white point here.

Zijun Zhou commented on pull request blender/blender#110941 2023-08-09 13:34:23 +02:00
AgX-Step4: Add and Rename Colorspaces

They can just have Standard for now, and better transforms can be added later.

There are also complications like we need to have multiple versions that are 1000 nits limited and P3 limited…

Zijun Zhou commented on pull request blender/blender#110941 2023-08-09 13:06:37 +02:00
AgX-Step4: Add and Rename Colorspaces

I have experimented with Rec.2100 but I don't have a finished version of AgX for it. Still experimenting.

Zijun Zhou commented on pull request blender/blender#110941 2023-08-09 13:01:39 +02:00
AgX-Step4: Add and Rename Colorspaces

It's needed for AgX's LUT input encoding. Also there are people using E-Gamut for interop, this repository for example: https://github.com/gralk/images

Zijun Zhou commented on pull request blender/blender#110941 2023-08-09 12:58:43 +02:00
AgX-Step4: Add and Rename Colorspaces

It's supposed to refer to the view transforms, should the family just go blank or should it be replaced with some other family name?

Zijun Zhou commented on pull request blender/blender#110941 2023-08-09 12:18:19 +02:00
AgX-Step4: Add and Rename Colorspaces

This is actually Apple's Display P3, which is common on Mac devices.

Zijun Zhou commented on pull request blender/blender#106355 2023-08-09 07:01:26 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Step 4 PR has been posted #110941

Zijun Zhou created pull request blender/blender#110941 2023-08-09 06:59:05 +02:00
AgX-Step4: Add and Rename Colorspaces
Zijun Zhou commented on pull request blender/blender#110913 2023-08-08 11:30:40 +02:00
AgX-Step3: Refactor OCIO config to be CIE XYZ I-E based

Commets are adressed.

Zijun Zhou commented on pull request blender/blender#106355 2023-08-08 06:17:18 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Step 3 PR has been posted #110913