Zijun Zhou Eary
  • Joined on 2019-09-02
Zijun Zhou created pull request blender/blender#110913 2023-08-08 06:12:48 +02:00
AgX-Step3: Refactor OCIO config to be CIE XYZ I-E based
Zijun Zhou commented on pull request blender/blender#106355 2023-08-02 06:31:19 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Step 2 PR has been #110712

Zijun Zhou created pull request blender/blender#110712 2023-08-02 06:29:46 +02:00
AgX-Step2: Use OCIO's built-in function for sRGB
Zijun Zhou commented on pull request blender/blender#106355 2023-07-30 20:47:59 +02:00
Replace Default OCIO config with AgX (Filmic v2)

In fact, the technical secretary of the body that developed the sRGB standard spoke up on the topic (Quote pulled from this overview, which is worth a read on its own, along with its comment…

Zijun Zhou commented on pull request blender/blender#110559 2023-07-28 17:19:48 +02:00
AgX-Step1: Clean up no longer used colorspaces, display device, and LUTs

Yes it's a compatiibility with the original Filmic-Blender on GitHub. Though upon double check, they used capital letter for "Colour". will update the fix.

Zijun Zhou commented on pull request blender/blender#110559 2023-07-28 15:54:46 +02:00
AgX-Step1: Clean up no longer used colorspaces, display device, and LUTs

Ok, None view is renamed back to Raw

Zijun Zhou commented on pull request blender/blender#110559 2023-07-28 15:05:45 +02:00
AgX-Step1: Clean up no longer used colorspaces, display device, and LUTs

does it mean both display and view transforms are not performed, or is the display transform is still performed? Having it named as "Raw" kind of implies that no transforms performed at…

Zijun Zhou commented on pull request blender/blender#106355 2023-07-28 11:50:19 +02:00
Replace Default OCIO config with AgX (Filmic v2)

if people are knowingly not calibrating to the standard, then they are probably doing so for a reason, knowing that some/all of their colors will still be encoded with the actual sRGB transfer…

Zijun Zhou commented on pull request blender/blender#106355 2023-07-28 08:19:25 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Step 1 PR has been posted #110559

Zijun Zhou created pull request blender/blender#110559 2023-07-28 08:13:32 +02:00
AgX-Step1: Clean up no longer used colorspaces, display device, and LUTs
Zijun Zhou closed pull request blender/blender#106355 2023-07-28 07:25:08 +02:00
Replace Default OCIO config with AgX (Filmic v2)
Zijun Zhou commented on pull request blender/blender#106355 2023-07-28 07:25:07 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Closing this PR since we decided to do it incrementally

Zijun Zhou commented on pull request blender/blender#106355 2023-07-27 15:45:58 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Interesting, but that would probably be a project of its own. What we did in our LUTs are kind of brute force, we simply calculate the data's original luminance, offset the data until there is no…

Zijun Zhou commented on pull request blender/blender#106355 2023-07-27 15:18:32 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Imagine for a moment we have some smart logic in the OCIO GPU shader (and its CPU side friend for the file output) which does smarter thing than simply clipping individual channels. Will doing so…

Zijun Zhou commented on pull request blender/blender#106355 2023-07-26 23:12:58 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Thanks for the reply, that settles a lot of questions for me.

On a higher level there are couple of points which I am curious about when it comes to adding view transforms and display…

Zijun Zhou commented on pull request blender/blender#106355 2023-07-22 13:09:13 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Do you mean we will discuss the points on the list in the review process? I am confused.

After reading a bit more times, I think I understand now.

Do you mean we need to start from the…

Zijun Zhou commented on pull request blender/blender#106355 2023-07-22 00:36:44 +02:00
Replace Default OCIO config with AgX (Filmic v2)

The way I see the breakdown is:

  • Have few EXR images which demonstrates the benefit of AgX the best (helps for communication and demonstration, but also to ensure that changes we do as…
Zijun Zhou commented on pull request blender/blender#106355 2023-07-21 18:33:48 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Thanks for the testings!

A lot of images are now rendering noticably brighter, even though they do not use any image textures and use Standard view transform.

I believe this is due to…

Zijun Zhou commented on pull request blender/blender#106355 2023-07-19 20:17:51 +02:00
Replace Default OCIO config with AgX (Filmic v2)

Note that by adding the AgX - prefix, the looks won't show up under AgX Log, Guard Rail, ect.

But this doesn't sound ideal. I would like AgX Log and Guard Rail etc. to be able to…

Zijun Zhou opened issue blender/blender#109938 2023-07-10 22:16:18 +02:00
OCIO Grading Primary Transform Error on Metal Shder