Germain-Le-Chapelain
  • Joined on 2023-12-31
b88d4095f7 Read the weight at `1' by default,
Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 21:19:33 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

(And ty for unreachable!.)

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 21:19:14 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

So it's still wrong I am fairly certain however, it's not worse than what's in (curve's already 0-to-1) so there is no reason to hold-this change, I can open another issue or put a little…

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 21:17:17 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

So normally this code is updated in my change but my projects.blender.org is all jacked-up.

(Is this a GitLab instance, GitHub instance ? Anyways why don't we use Subversion, that'd be fixed ? …

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 21:15:23 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

I'm resolving this one even though I'm not putting r_nu. Do you want me to do that instead, @mod_moder ?

Rather, I have used a Span and used r_ in the static functions in the C++ file.

6718f188d2 Flattened. Merged-in main. With corrections from feedback.
1d94c34f2a Merge branch 'blender-v4.2-release'
91d45db8bb Remove use of potentially unsafe strncat & strcpy
346ed47c3e Merge branch 'blender-v4.2-release'
a5f331afc0 Fix linux build error in x265.cmake
Compare 1316 commits »
Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 04:21:40 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

Yeah from create_curve() just above, with which it could be merged.. Food for thoughts I have moved it in its own static const variable (probably should be using constexpr ? Hey..)

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 04:14:04 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

(I think it's cool. It helps a great deal cleaning-up unrequired dependencies.)

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 04:12:01 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

OK. I think the compiler will say no for the const in the static cast, lets see

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 04:10:27 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

Yes: it should be a size_t. However I understood you were not taking a liking to it :P.

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 04:08:15 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

Thank you ! The code is not correct here either: I think it should be the values of the 1st and last knot

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 04:04:55 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

Thank you! I shamelessly copied that code, but was going to make a point of using the size of param instead!

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 00:47:52 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

Oh I did not write that.. It's going to have to be a bad merge, sloppy copy-paste or something.

Thank you I'll find what happened here when I go over all your comments

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 00:45:53 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

Yes this is wrong BTW, thank you!

I was a bit overly-excited when I removed the WIP but I think this needs being addressed: We will have 3 coordinate point (and 1 will be implied.

I don't…

Germain-Le-Chapelain commented on issue blender/blender#119359 2024-06-12 00:26:15 +02:00
Support for free-form surfaces import/export as Wavefront .OBJ

☝️ As per above! Ready to check-in for this issue! I am moving onto the FreeCAD side-of-things now :] o/

Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-06-12 00:17:44 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

image

Finally! (I was mixed-up in my last comment: it is bezierthat is being used in the function BKE_nurb_knot_calc_u. endpoint is…

28a78793fb Cleaner change.
56b3a442ad OH YEAH!!!...
12c6fa9ab1 Idk .. :|
Germain-Le-Chapelain commented on pull request blender/blender#117371 2024-05-18 04:50:49 +02:00
Add support for NURBS surfaces in Wavefront .OBJ files.

... I can ...

The offer alone is a huge cheer-up. Thank you ! Sadly, we've got all the files we need (both working and not. I think.)

What I'm leaning toward we should create