Joseph Eagar JosephEagar
9 Followers · 0 Following
  • Sacramento, California, USA
  • Joined on 2004-09-20
Repositories
1
 Projects Public Activity Starred Repositories
Joseph Eagar commented on pull request blender/blender#113270 2023-10-21 04:11:15 +02:00
WIP: Sculpt: Repeat last stroke for sculpt

It's not , it's calculate per dab.

Joseph Eagar pushed to temp-sculpt-repeat-last-stroke at JosephEagar/blender 2023-10-20 23:01:55 +02:00
204ef4f107 Remove unnecassary inversion
Joseph Eagar pushed to temp-sculpt-repeat-last-stroke at JosephEagar/blender 2023-10-20 22:57:53 +02:00
07c3b51d34 Merge branch 'main' into temp-sculpt-repeat-last-stroke
b18810d2aa Merge branch 'blender-v4.0-release'
0e9f472726 Fix #113773: repeat zone does not propagate anonymous attributes sometimes
e52b269283 Cleanup: Use simpler copying with begin iterator and count
8ec6260ed5 Cleanup: Consistent use of curves::has_anything_selected
Compare 621 commits »
Joseph Eagar pushed to temp-dyntopo-bmlog at JosephEagar/blender 2023-10-17 19:22:18 +02:00
2aa59e1605 Use unique_ptr
Joseph Eagar commented on pull request blender/blender#113539 2023-10-17 18:43:44 +02:00
Sculpt: Rewrite BMLog to support customdata and geometry undo steps

I'm actually not sure this is needed at all, you might be right. I'll try removing it.

Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-10-13 22:45:00 +02:00
8889a48166 temp-sculpt-dyntopo: Fix surface_smooth_v_safe not respecting sharpangle
Joseph Eagar pushed to temp-sculpt-dyntopo at blender/blender 2023-10-13 21:31:29 +02:00
7d7d5d3c9b temp-sculpt-dyntopo: Collapse callbacks are function pointers again
a491c9fc95 Merge branch 'main' into temp-sculpt-dyntopo
a92cfc2754 GPv3: Set Spline Resolution
d3fea733a1 GPv3: Set Spline Cyclic
493674435f GPv3: Set Curve Tilt
Compare 332 commits »
Joseph Eagar pushed to temp-dyntopo-bmlog at JosephEagar/blender 2023-10-13 20:11:12 +02:00
c36f0e2504 Merge branch 'main' into temp-dyntopo-bmlog
a92cfc2754 GPv3: Set Spline Resolution
d3fea733a1 GPv3: Set Spline Cyclic
493674435f GPv3: Set Curve Tilt
3a998fc461 Fix EEVEE-Next: Linking error cause by closure_to_rgba
Compare 164 commits »
Joseph Eagar pushed to temp-dyntopo-pbvh-balance at JosephEagar/blender 2023-10-13 20:11:02 +02:00
29ea837d55 Merge branch 'main' into temp-dyntopo-pbvh-balance
a92cfc2754 GPv3: Set Spline Resolution
d3fea733a1 GPv3: Set Spline Cyclic
493674435f GPv3: Set Curve Tilt
3a998fc461 Fix EEVEE-Next: Linking error cause by closure_to_rgba
Compare 164 commits »
Joseph Eagar commented on pull request blender/blender#113539 2023-10-12 21:06:30 +02:00
Sculpt: Rewrite BMLog to support customdata and geometry undo steps

Which uses of CD_FLAG_TEMPORARY? Do you mean the idmap attributes?

Okay, yeah that's the part I didn't look into in depth in this PR. But yes, I do mean those. Just to be clear, the main…

Joseph Eagar commented on pull request blender/blender#113539 2023-10-12 21:05:13 +02:00
Sculpt: Rewrite BMLog to support customdata and geometry undo steps

The print function is called by sculpt_undo's debug printing.

Joseph Eagar pushed to temp-dyntopo-bmlog at JosephEagar/blender 2023-10-12 21:03:54 +02:00
e20054b1e6 * Fix crash
Joseph Eagar pushed to temp-dyntopo-bmlog at JosephEagar/blender 2023-10-12 20:34:17 +02:00
f1b8e3465b Delete virtual base methods
Joseph Eagar pushed to temp-dyntopo-bmlog at JosephEagar/blender 2023-10-12 20:33:24 +02:00
f62cb04ebe Remove mempool wrapper
Joseph Eagar commented on pull request blender/blender#113539 2023-10-12 20:21:14 +02:00
Sculpt: Rewrite BMLog to support customdata and geometry undo steps

I could go with a dependency injection pattern, bundle the API methods I need into a separate struct that forwards back to BMEntry.

Joseph Eagar commented on pull request blender/blender#113539 2023-10-12 20:18:46 +02:00
Sculpt: Rewrite BMLog to support customdata and geometry undo steps

I'd forgotten that master's PBVH_BMESH forcibly triangulates everything.

Joseph Eagar commented on pull request blender/blender#113539 2023-10-12 20:17:58 +02:00
Sculpt: Rewrite BMLog to support customdata and geometry undo steps

The problem is that BMLogFace is a non-trivial type so it's constructor has to be called via in-place new. Maybe I should make a PR for this though.

Joseph Eagar pushed to temp-dyntopo-bmlog at JosephEagar/blender 2023-10-12 19:58:34 +02:00
36b104b071 Rewrite customdata_layout_is_same to compare structures
Joseph Eagar commented on pull request blender/blender#113539 2023-10-12 19:51:01 +02:00
Sculpt: Rewrite BMLog to support customdata and geometry undo steps

That's a nice little class.

Joseph Eagar pushed to temp-dyntopo-bmlog at JosephEagar/blender 2023-10-12 19:48:20 +02:00
1cfaaea4f6 Use enum class