Julian Eisel JulianEisel
  • Amsterdam
  • Asset system (development lead), UI (developer & module coordindator), VR (initial development).

  • Joined on 2013-12-12
Julian Eisel pushed to bundled-assets at JacquesLucke/blender 2023-02-13 15:51:00 +01:00
064747a3a0 Merge branch 'main' into bundled-assets
9fecf1f8b8 Cycles: Replace resolution divider loop with an analytical formula
99e71ec1f2 Assets: Store pointer to owning asset library in asset representation
4f19e99cb1 Tests: add unit test for BLI_strnlen
147c75b831 Cleanup: EEVEE-Next: Fix typo
Compare 53 commits »
Julian Eisel commented on pull request blender/blender#104474 2023-02-13 13:05:55 +01:00
Assets: bundle essentials with Blender

I created #104686 and am trying to get this done for the 3.5 release still, otherwise the import method selection becomes too confusing with the append-only essentials.

For this I also pushed…

Julian Eisel pushed to main at blender/blender 2023-02-13 12:57:17 +01:00
99e71ec1f2 Assets: Store pointer to owning asset library in asset representation
Julian Eisel created pull request blender/blender#104688 2023-02-13 12:23:18 +01:00
WIP: Assets: Preference for default import method for an asset library
Julian Eisel pushed to temp-asset-import-method-in-prefs at JulianEisel/blender 2023-02-13 12:21:02 +01:00
8da8bc4e3f Assets: Preference for default import method for an asset library
701f90c677 Gizmo: make cage gizmo follow the cursor exactly when scaling
9f4ee75c9b Fix #80307: Underline shortcut not working in enum context menus
2e19aa1399 UI: add camera passepartout color to theme
918cf6cd77 Fix #104341: Handle edge case in Curve to Mesh node
Compare 10 commits »
Julian Eisel created branch temp-asset-import-method-in-prefs in JulianEisel/blender 2023-02-13 12:21:02 +01:00
Julian Eisel opened issue blender/blender#104686 2023-02-13 11:49:43 +01:00
Improve import method selection for assets
Julian Eisel commented on pull request blender/blender#104474 2023-02-13 11:02:19 +01:00
Assets: bundle essentials with Blender

Personally I prefer is_never_link to make clear this is getting, not setting.

Julian Eisel commented on issue blender/blender#104582 2023-02-10 19:13:42 +01:00
Fixing undo overreach after RNA property changes done through UI.

Code that changes scene data should do an undo push when done. If the undo doesn't behave as expected, that specific case should be investigated. I know that there were indeed cases with brush…

Julian Eisel commented on pull request blender/blender#104474 2023-02-10 15:28:52 +01:00
Assets: bundle essentials with Blender

Why is any of this needed? Just passing ASSET_LIBRARY_ESSENTIALS as the value should be fine.

Julian Eisel commented on pull request blender/blender#104474 2023-02-10 15:28:30 +01:00
Assets: bundle essentials with Blender

I thought it would be fine since during loading you have access to the nested library, but I missed that here, where you need to do the query, you can only access the "All" one. I'd suggest to let…

Julian Eisel commented on pull request blender/blender#104474 2023-02-09 19:43:41 +01:00
Assets: bundle essentials with Blender

This may in fact not be necessary, see blender/blender#104474 (comment).

Julian Eisel suggested changes for blender/blender#104474 2023-02-09 19:42:20 +01:00
Assets: bundle essentials with Blender

Wait the big green button is more than "Send" :)

Julian Eisel commented on pull request blender/blender#104474 2023-02-09 19:40:54 +01:00
Assets: bundle essentials with Blender

Would suggest something like: "Show the basic building blocks and utilities coming with Blender.

Julian Eisel commented on pull request blender/blender#104474 2023-02-09 19:40:54 +01:00
Assets: bundle essentials with Blender

I'd call this file AS_essentials_library.h and name functions and all accordingly. Just use the same term as in Blender, avoids confusion (Bundle vs. Essentials).

Julian Eisel commented on pull request blender/blender#104474 2023-02-09 19:40:54 +01:00
Assets: bundle essentials with Blender

Why ED_? Suggest AS_essentials_library_contains_path().

Julian Eisel commented on pull request blender/blender#104474 2023-02-09 19:40:54 +01:00
Assets: bundle essentials with Blender

This should be in the include_generated block I guess (the name is terrible^^).

Julian Eisel approved blender/blender#104474 2023-02-09 19:40:54 +01:00
Assets: bundle essentials with Blender
  • The UI needs some updates to reflect the "never-link" assets. Discussed what to do exactly with Dalai and I'll try to work on this. It's important for this feature I think, but I'll work on it separately.