Julian Eisel JulianEisel
12 Followers · 1 Following
  • Amsterdam

  • Asset system (development lead), UI (developer & module coordindator), VR (initial development).

  • Joined on 2013-12-12
Overview Repositories
9
 Projects Public Activity Starred Repositories
1
Julian Eisel pushed to main at JulianEisel/.profile 2024-09-16 11:30:01 +02:00
1f0e1f3abe September 9 - 15
Julian Eisel pushed to main at JulianEisel/.profile 2024-09-16 11:27:13 +02:00
e5b0b25395 September 2 - 8
Julian Eisel suggested changes for blender/blender#124412 2024-09-16 11:01:39 +02:00
UI: Frame Specific Axes

This is more of an animation module change than a mere UI change, so they should review it too.

Julian Eisel commented on pull request blender/blender#124412 2024-09-16 11:01:38 +02:00
UI: Frame Specific Axes

Same as above re tooltip.

Julian Eisel commented on pull request blender/blender#124412 2024-09-16 11:01:37 +02:00
UI: Frame Specific Axes

Same as above re ot->prop.

Julian Eisel commented on pull request blender/blender#124412 2024-09-16 11:01:35 +02:00
UI: Frame Specific Axes

Explaining "Dimensions" with "Dimensions to modify" doesn't actually add any more information, better use a more descriptive description/tooltip. You might find some tips in the tooltip guidelines.

Julian Eisel commented on pull request blender/blender#124412 2024-09-16 11:01:34 +02:00
UI: Frame Specific Axes

Assigning to ot->prop shouldn't be needed here. I see the previous properties do this too (and I don't see a reason for it), but best don't override it again, since that could be an unintentional behavior change.

Julian Eisel pushed to main at blender/blender-developer-docs 2024-09-16 11:00:01 +02:00
c89eeeb13c HIG: More formatting fixes for tooltip page
Julian Eisel pushed to main at blender/blender-developer-docs 2024-09-16 10:47:10 +02:00
930623c1e8 HIG: Fix formatting for tooltip page, remove status info
Julian Eisel commented on pull request blender/blender#127204 2024-09-06 16:50:09 +02:00
Grease Pencil: Properly support brushes with draw mode primitive tools

The 'USE_BRUSHES' flags are commented out and there's a TODO comment. This is just so this doesn't depend on !125911 and compiles/runs without it. Pretend this wasn't the case for review :)

Julian Eisel pushed to temp-brush-assets-gpencil-followups at JulianEisel/blender 2024-09-06 16:13:34 +02:00
8794c9ac36 Cleanup: Correct function name
Julian Eisel pushed to temp-brush-assets-gpencil-followups at JulianEisel/blender 2024-09-06 16:04:41 +02:00
727a0e24d5 Avoid reusing data_block tool field, add more specific one
Julian Eisel pushed to temp-brush-assets-gpencil-followups at JulianEisel/blender 2024-09-06 15:50:35 +02:00
de34223fc6 Fix errors after changes from !125911
Julian Eisel pushed to temp-brush-assets-gpencil-followups at JulianEisel/blender 2024-09-06 15:45:36 +02:00
7ab2551ef2 Add more missing renames
10ceab1c9d Include changes from !127204
Compare 2 commits »
Julian Eisel pushed to temp-brush-asset-tool-brush-flag at JulianEisel/blender 2024-09-06 15:45:05 +02:00
a737935050 Add more missing renames
Julian Eisel pushed to temp-brush-assets-gpencil-followups at JulianEisel/blender 2024-09-06 14:30:22 +02:00
1f896ddaaa Apply changes from review in !125911
Julian Eisel commented on pull request blender/blender#125911 2024-09-06 14:25:18 +02:00
Refactor: Tools: Change how tools are marked as using brushes

Note that !125449 brings back a version of data_block, but it's just for the few tools meant for a specific brush type (like the grease pencil eraser or fill tools). I think I'll also change…

Julian Eisel pushed to temp-brush-asset-tool-brush-flag at JulianEisel/blender 2024-09-06 14:23:07 +02:00
8fa38fea20 Add missing changes, somehow file didn't get saved
Julian Eisel pushed to temp-brush-asset-tool-brush-flag at JulianEisel/blender 2024-09-06 14:18:17 +02:00
94e9aa2d40 Address comments from review
10caa4a56f Avoid depending on #125911