@mont29 what do you think, would you say this fix is safe enough for 4.2 or should I stick to a simpler workaround, like I proposed in blender/blender#125466?
Looking at the actual change in…
Please keep the increased size and the bug fix in separate commits. It's not nice if visual changes are hidden in a bug fix commit (means they can slip through, e.g. in scripts collecting user visible changes).
I would rather avoid the term "library" on its own. The UI uses "Asset Library" to differentiate it from a library data-block. So far I've been trying to be strict about this.
So "All Asset…
Don't think this function is the right place for this logic. It is run for every region for every redraw. I think the NC_WINDOW
in ED_screen_do_listen
could handle this. A NC_WINDOW
notifier is sent on every theme change. I'd also put this into a separate function, so it's clear that this is all doing a specific task.