Catching up on open patches, this one has appears to have fallen through the cracks, sorry it took this long
No issues building on windows, but the only consumer of this is cycles standalone afaik, which i admit I do not have in my regular testing matrix.
Given this is a C++ file now, some more cleanups can be done, WRL was already used in the trackpad code, so that be safe to use, comutil for the _variant_t
and _bstr_t
types is new (but…
While i'm happy to see any iostreams includes being removed, probably best to have the people that actually work with this code have a look, the removal print_as_lines
may be a bit too…
Eventually all of that will make it back in, that work was done when i had lots of time to spare, currently much less so, if there's specific projects you'd like to be done, you can always hit me…
it's all good, thanks for following up on that!