libxvid could be removed under the condition that ffmpeg's internal codepath would be used for this, removing xvid completely from the UI is not what was agreed upon. It would need to stay working
lgtm , @JacquesLucke feel free to land, I didn't want to land it and go awol for 8+ hours
there's a check that errors if it's not WIN32 a few lines above that , so defined(WIN32) this can be safely removed.
this has to be done the same way as I linked, including cleanup
Just keep the file names as they are being output by the build, in the past we tried to bend the build system to get it to generate the "old" names, but after a couple of years of that you tend to end up in a situation where you go "but why does it have such a weird name?" and no-one knows. I've been trying to clean up these instances as I update deps.
That's a Band-Aid, not a fix, all inclusions that lead to windows.h being included, have been [guarded](https://projects.blender.org/blender/blender/src/branch/main/source/blender/blenlib/BLI_enu…
Do you have a repro to get the error? I'd like to take a closer look what's happening there
There's a few technical problems, the printf's, the goto's etc, but nothing unsurmountable, before we spend time on that i'd like the UI people to sign off on this first.
cc: @pablovazquez
It's been building for a few hours already, given it was a full clean build, it'll "be a bit"
So we could consider the patch assigning copyright to BF to be a reasonable assumption
I may have understood what you are trying to say here, so i apologize if i misunderstood, but you can't…
Think it's important to establish there isn't a single copyright holder for a file, multiple entities can have copyright on various parts of the file.
If you added some_function to…
The FAQ @Sergey linked in the opening post, mentions how chromium deals with this, personally I'd be more comfortable going that route. It keeps the noise in every code file to a minimum, and…