Lukas Tönne LukasTonne
Lukas Tönne commented on pull request blender/blender#119039 2024-03-04 17:44:34 +01:00
GPv3: Primitive Tools: Line, Polyline, Arc, Curve, Box and Circle Tool.

Upper case, missing dot

Lukas Tönne commented on pull request blender/blender#119039 2024-03-04 17:44:33 +01:00
GPv3: Primitive Tools: Line, Polyline, Arc, Curve, Box and Circle Tool.

Is this going to be implemented?

Lukas Tönne commented on pull request blender/blender#119039 2024-03-04 17:44:32 +01:00
GPv3: Primitive Tools: Line, Polyline, Arc, Curve, Box and Circle Tool.

The wait_for_input property is not defined for any of the new operators, i get a bunch of warnings:

Lukas Tönne commented on pull request blender/blender#119039 2024-03-04 17:44:31 +01:00
GPv3: Primitive Tools: Line, Polyline, Arc, Curve, Box and Circle Tool.

This should be an actual enum property instead of a bool, and then use expand=True in the ui code to draw as toggle buttons rather than drawing two buttons for the same property.

Lukas Tönne pushed to gp3-texture-modifier at LukasTonne/blender 2024-03-04 17:00:56 +01:00
766cc069ee Merge branch 'main' into gp3-texture-modifier
d6aadd6692 GPv3: Outline modifier
6290ead143 Merge branch 'blender-v4.1-release'
a8cc2e4d96 Fix: Add missing iostream include
5f16d23971 Fix: Null pointer dereference in node editor ID remapping
Compare 18 commits »
Lukas Tönne deleted branch gp3-outline-modifier from LukasTonne/blender 2024-03-04 16:54:22 +01:00
Lukas Tönne merged pull request blender/blender#118911 2024-03-04 16:54:19 +01:00
GPv3: Outline modifier
Lukas Tönne pushed to main at blender/blender 2024-03-04 16:54:18 +01:00
d6aadd6692 GPv3: Outline modifier
Lukas Tönne commented on pull request blender/blender#118911 2024-03-04 16:53:19 +01:00
GPv3: Outline modifier

Curves are copied in their entirety first, then point attributes get rewritten: bke::CurvesGeometry dst_curves(src_curves). It's fine, couldn't find anything wrong in testing either, custom…

Lukas Tönne commented on pull request blender/blender#118911 2024-03-04 15:48:43 +01:00
GPv3: Outline modifier
Lukas Tönne pushed to gp3-outline-modifier at LukasTonne/blender 2024-03-04 15:48:35 +01:00
7a0a521236 Cleanup: formatting.
Lukas Tönne opened issue blender/blender#119055 2024-03-04 15:24:48 +01:00
GPv3: Eraser changes cap type in unrelated strokes
Lukas Tönne commented on pull request blender/blender#118911 2024-03-04 14:58:42 +01:00
GPv3: Outline modifier
Lukas Tönne pushed to gp3-outline-modifier at LukasTonne/blender 2024-03-04 14:25:29 +01:00
0293f50a8b Always return a valid point index as the closest.
07a298f005 Comment on the offset value.
a483689f6a Comment on reorder_cyclic_curve_points function.
4887a6bcf7 Merge branch 'main' into gp3-outline-modifier
b3e46b65b9 GPv3: Fix: Memory corruption after modifier conversion
Compare 23 commits »
Lukas Tönne suggested changes for blender/blender#114772 2024-03-04 13:58:33 +01:00
GPv3: Fill texture coordinates data storage

I think we should change the attributes to store a loc/rot/scale transform instead of the barycentric vectors + offset. I don't want to expose the legacy 3-point method unless necessary. And if the texture transform is already stored as general barycentric unit vectors then we might as well store the linear transform directly.

Lukas Tönne commented on pull request blender/blender#114772 2024-03-04 13:58:32 +01:00
GPv3: Fill texture coordinates data storage

Could use math::from_origin_transform for this

Lukas Tönne commented on pull request blender/blender#114772 2024-03-04 13:58:31 +01:00
GPv3: Fill texture coordinates data storage

math::safe_rcp does 1/x with a null check

Lukas Tönne commented on pull request blender/blender#114772 2024-03-04 13:58:30 +01:00
GPv3: Fill texture coordinates data storage

I suggest to just store the loc/rot/scale instead of three vectors. That's a bit more flexible and doesn't rely so much on this arbitrary GPv2 method of picking three points to generate the transform.

Lukas Tönne commented on pull request blender/blender#114772 2024-03-04 13:58:29 +01:00
GPv3: Fill texture coordinates data storage

This function is used only inside grease_pencil.cc, doesn't need to be exposed in the header.

Lukas Tönne commented on pull request blender/blender#114772 2024-03-04 13:58:29 +01:00
GPv3: Fill texture coordinates data storage

For applying a transform to a point use