Lukas Tönne LukasTonne
Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-19 13:35:25 +01:00
58cd018064 Better enum propagation with change detection for limited updates.
a6d6a71934 Merge branch 'main' into nodes-menu-switch
e87b67398c Extensions: add/remove bl_ext sub-modules when repo.enabled is toggled
0ec50b56ad Extensions: add option to enable/disable an extensions repo
dfce570198 Cleanup: move extensions flag to DNA_userdef_types.h, rename flag
Compare 24 commits »
Lukas Tönne commented on pull request blender/blender#113445 2023-12-19 11:06:24 +01:00
Geometry Nodes: Menu Switch Node

I think i need to add another update flag NTREE_CHANGED_ENUM to keep track of which nodes are actually affected by enum changes. RNA would also set this more specifically, instead of the generic…

Lukas Tönne closed issue blender/blender#116301 2023-12-19 10:35:39 +01:00
Wayland: surface is null while debugging
Lukas Tönne commented on issue blender/blender#116301 2023-12-19 10:35:37 +01:00
Wayland: surface is null while debugging

Seems like it's working now. haven't been able to repro the issue. Thanks!

Lukas Tönne commented on pull request blender/blender#113445 2023-12-19 10:26:24 +01:00
Geometry Nodes: Menu Switch Node

If any enum changes are included in the interface_changed flag then we may not need to distinguish these two cases after all. It would mean the interface gets fully updated and the modifier is…

Lukas Tönne commented on pull request blender/blender#113445 2023-12-18 19:02:23 +01:00
Geometry Nodes: Menu Switch Node

I still need to implement better right-to-left propagation within the node for this to work. If the menu switch is set to "Menu" socket type the output is a menu. Initially this output is an empty…

Lukas Tönne commented on pull request blender/blender#113445 2023-12-18 18:53:10 +01:00
Geometry Nodes: Menu Switch Node

Reverted by changes to MOD_nodes_update_interface.

Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-18 18:50:53 +01:00
5f5a3ece4d Cleanup: fix comment.
ae22469bb6 Cleanup: "this->" prefix for function calls in NodeTreeMainUpdater.
Compare 2 commits »
Lukas Tönne commented on pull request blender/blender#113445 2023-12-18 18:46:16 +01:00
Geometry Nodes: Menu Switch Node

I made two separate update functions out of MOD_nodes_update_interface now, let me know if that looks ok: b0e76d531742c5d348babb0d968ab62950a442c3

Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-18 18:44:32 +01:00
b0e76d5317 Clearer API for updating the nodes modifier after tree changes.
Lukas Tönne commented on pull request blender/blender#113445 2023-12-18 17:59:18 +01:00
Geometry Nodes: Menu Switch Node

IIRC i added this because the modifier ID properties need to be updated when the enum definition changes, which is not covered by the interface_changed flag. So the MOD_nodes_update_interface

Lukas Tönne commented on pull request blender/blender#113445 2023-12-18 17:38:58 +01:00
Geometry Nodes: Menu Switch Node

Removed the flag and now API calls tag the node tree directly.

Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-18 17:38:19 +01:00
e0a158e5db Removed the NODE_ENUM_DEFINITION_CHANGED flag and tag ntree directly.
Lukas Tönne commented on pull request blender/blender#113445 2023-12-18 16:50:23 +01:00
Geometry Nodes: Menu Switch Node

There should not be an attribute switch for the enum property in the modifier, even when the enum is a field. That's be cause we don't support enum attributes.

I've added a special case to…

Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-18 16:44:20 +01:00
0c6d8993a0 Hide the input attribute toggle in the modifier for menu sockets.
Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-18 15:19:51 +01:00
35cf5005a6 Fix link invalidation due to missing enum items.
63f7a2098a Handle SOCK_MENU case in node declaration builder functions.
Compare 2 commits »
Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-18 14:58:06 +01:00
822b89a828 Merge branch 'main' into nodes-menu-switch
0ceb272832 Curves: Support View Selected in edit mode
0b00b360f7 Fix #116058: 'Align Rotation to Target' does not consider object orientation
f2cd1873ea Fix #116275: Snap (align to target) crash without valid target location
e1cec452da Lookdev: Use Mid Grey for Diffuse HDRI Sphere
Compare 9 commits »
Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-18 14:47:37 +01:00
9610fac94e Fix inverted error check.
Lukas Tönne opened issue blender/blender#116301 2023-12-18 14:38:55 +01:00
Wayland: surface is null while debugging
Lukas Tönne pushed to nodes-menu-switch at LukasTonne/blender 2023-12-18 14:12:46 +01:00
9568e36458 Clear the runtime data of menu sockets on file read.
1e74ce03c6 Use strong user count instead of weak users for enum items in sockets.
Compare 2 commits »