Lukas Tönne LukasTonne
8 Followers · 0 Following
Repositories
6
 Projects Public Activity Starred Repositories
6
Lukas Tönne commented on pull request blender/blender#115270 2023-12-12 17:54:50 +01:00
Geometry Nodes: initial Volume Grid socket support

@blender-bot build

Lukas Tönne commented on pull request blender/blender#115270 2023-12-12 17:54:12 +01:00
Geometry Nodes: initial Volume Grid socket support

Regarding the GVolumeGridPtr/VolumeGridPtr<T>: IIRC we briefly touched on removing the typed pointer variant and just use a generic ImplicitSharingPtr. Such pointers will always return a…

Lukas Tönne pushed to volume-grid-sockets at LukasTonne/blender 2023-12-12 17:31:39 +01:00
6c8211baf2 Fix for USD volume bounds calculation, have to load the grid first.
Lukas Tönne pushed to volume-grid-sockets at LukasTonne/blender 2023-12-12 16:43:16 +01:00
2f2a784fbd Fix cycles test: Replace the grid when unloading instead of new tree.
Lukas Tönne pushed to volume-grid-sockets at LukasTonne/blender 2023-12-12 16:17:48 +01:00
6d7effb088 Unnamed grids are valid, ignore grid names in file cache keys.
Lukas Tönne approved blender/blender#116010 2023-12-12 13:59:58 +01:00
Cleanup: Fix compiler warning
Lukas Tönne pushed to volume-grid-sockets at LukasTonne/blender 2023-12-12 13:54:56 +01:00
7d84a84d2f Merge branch 'main' into volume-grid-sockets
858349d821 Fix #113728: fireflies in Principled Hair Huang with MIS
a43f847d54 Cleanup: compiler warning
d015e98ee6 Fix Cycles ASAN error with boolean kernel arguments
16705f078c Fix #116000: Face set toggle visibility not working correctly
Compare 13 commits »
Lukas Tönne deleted branch volume-grid-sockets-cache-rewrite from LukasTonne/blender 2023-12-12 13:01:12 +01:00
Lukas Tönne pushed to volume-grid-sockets at LukasTonne/blender 2023-12-12 13:00:56 +01:00
869cf6bb30 Reimplemented the file cache for volume grids.
Lukas Tönne pushed to volume-grid-sockets-cache-rewrite at LukasTonne/blender 2023-12-12 12:49:12 +01:00
eede157835 Fix memory leak by allocating the file cache inside the get function.
Lukas Tönne pushed to volume-grid-sockets-cache-rewrite at LukasTonne/blender 2023-12-12 11:52:59 +01:00
7e7465cd53 Fix dereference.
Lukas Tönne pushed to volume-grid-sockets-cache-rewrite at LukasTonne/blender 2023-12-12 11:43:54 +01:00
d2aa05622f Reimplemented simplification levels by storing levels in the cache.
Lukas Tönne pushed to volume-grid-sockets-cache-rewrite at LukasTonne/blender 2023-12-12 09:29:15 +01:00
f8f5f5532b Merge branch 'volume-grid-sockets' into volume-grid-sockets-cache-rewrite
e834b3498a Merge branch 'main' into volume-grid-sockets
f66ad2d919 Cleanup: Suppress Unused Variables In Release Builds
3b2ed40250 Windows: Remove workaround for ARM64/WSL Mesa drivers
857714ceff WM: warn about suspicious event time-stamps in debug builds
Compare 55 commits »
Lukas Tönne pushed to volume-grid-sockets at LukasTonne/blender 2023-12-12 09:29:00 +01:00
e834b3498a Merge branch 'main' into volume-grid-sockets
f66ad2d919 Cleanup: Suppress Unused Variables In Release Builds
3b2ed40250 Windows: Remove workaround for ARM64/WSL Mesa drivers
857714ceff WM: warn about suspicious event time-stamps in debug builds
7f64bf482e Cleanup: rename GHOST event processing arguments
Compare 53 commits »
Lukas Tönne pushed to volume-grid-sockets-cache-rewrite at LukasTonne/blender 2023-12-11 18:26:36 +01:00
9a6837ebab Integrate simplification levels into the file grid cache.
Lukas Tönne pushed to volume-grid-sockets-cache-rewrite at LukasTonne/blender 2023-12-11 14:59:22 +01:00
82347908cb Explicit flag to indicate when a volume grid tree has been loaded.
Lukas Tönne commented on pull request blender/blender#115270 2023-12-11 11:43:31 +01:00
Geometry Nodes: initial Volume Grid socket support

It feels like we don't really need BKE_volume_grid_ensure_tree_loaded if we do the load lazily when accessing VolumeGrid::grid() That could work, it's what the C api does now too:…

Lukas Tönne commented on pull request blender/blender#115270 2023-12-11 11:13:47 +01:00
Geometry Nodes: initial Volume Grid socket support

It's a bit confusing how there is a BKE_volume_load (loads metadata for all grids) and a BKE_volume_grid_load (loads actual tree data) function. I'd like to make naming a bit more explicit: -…

Lukas Tönne commented on pull request blender/blender#114362 2023-12-11 10:48:49 +01:00
ID properties: Support enum values with items

@ideasman42 Thanks for the explanation, i think this is a compelling argument. If @HooglyBoogly agrees i will implement it that way to get this thing un-stuck.

Lukas Tönne pushed to volume-grid-sockets-cache-rewrite at LukasTonne/blender 2023-12-11 10:36:54 +01:00
d1e85592bf Merge branch 'volume-grid-sockets' into volume-grid-sockets-cache-rewrite
0c788585ca Return grid pointer directly when extracting grid inputs.
7af2717b1c Remove potential grid copy in VolumeGridPtr accessors.
Compare 3 commits »