Lukas Tönne LukasTonne
7 Followers · 0 Following
Repositories
6
 Projects Public Activity Starred Repositories
6
Lukas Tönne created pull request blender/blender#111956 2023-09-05 09:25:02 +02:00
Fix #111950: missing "hide value" and "compact" flags for group sockets
Lukas Tönne pushed to fix-socket-hide-flag at LukasTonne/blender 2023-09-05 09:22:31 +02:00
30e592f9b7 Fix for missing "hide value" and "compact" flags for node group sockets.
02736d28cd Fix error batch renaming light probes
644297cc6e Cleanup: Remove mistanly committed timer
646b3555ff Cleanup: Use C++ Set for expand snap enabled face sets
e52404db95 Cleanup: Use simpler face vert iteration in sculpt expand
Compare 10 commits »
Lukas Tönne created branch fix-socket-hide-flag in LukasTonne/blender 2023-09-05 09:22:31 +02:00
Lukas Tönne commented on pull request blender/blender#111800 2023-09-04 17:52:55 +02:00
New test for node group versioning

changed to

    # Test properties of a node group item and associated node socket with spec data.
    def compare_group_socket_to_spec(self, item, node, spec: SocketSpec, test_links=Tru…
Lukas Tönne pushed to test_nodegroup_compat at LukasTonne/blender 2023-09-04 17:52:00 +02:00
169c42965c Cleanup: Dots after comments.
d98fe9a370 Renamed function and added comment for clarity.
05dbe238e3 Removed unnecessary global.
Compare 3 commits »
Lukas Tönne commented on pull request blender/blender#111800 2023-09-04 17:48:28 +02:00
New test for node group versioning

No it's not, removed it.

Lukas Tönne commented on pull request blender/blender#111800 2023-09-04 17:47:08 +02:00
New test for node group versioning

Added a test for this, works fine.

Lukas Tönne pushed to test_nodegroup_compat at LukasTonne/blender 2023-09-04 17:46:47 +02:00
9e8c6386f8 Added test for file versions to detect possible save with wrong version.
a5de408021 Merge branch 'fix-versioning-26-node-groups' into test_nodegroup_compat
cc23d2cd07 Merge branch 'main' into fix-versioning-26-node-groups
58ea865f09 Added missing 'compact' flag for sockets.
bad7e18689 Initialize socket typeinfo before node typeinfo.
Compare 12 commits »
Lukas Tönne pushed to test_nodegroup_compat at LukasTonne/blender 2023-09-04 17:37:05 +02:00
34d36f30ed Merge branch 'main' into test_nodegroup_compat
10e1bfd963 Cleanup: formatting.
564bbdf6e7 I18n: disambiguate and extract a few messages
9e129abcf2 Fix #111905: Filewrite: Do not write ShapeKeys of unused geometry.
ad60d40ed3 Cleanup: Move 'uneditable' info message about item renaming in Outliner to INFO.
Compare 19 commits »
Lukas Tönne commented on pull request blender/blender#111800 2023-09-04 17:36:14 +02:00
New test for node group versioning

I find it more readable with a single line per socket and the auto-formatting disabled. Can turn that back on if you feel strongly about it.

After make format:

        self.compare_s…
Lukas Tönne pushed to fix-versioning-26-node-groups at LukasTonne/blender 2023-09-04 17:23:47 +02:00
cc23d2cd07 Merge branch 'main' into fix-versioning-26-node-groups
564bbdf6e7 I18n: disambiguate and extract a few messages
9e129abcf2 Fix #111905: Filewrite: Do not write ShapeKeys of unused geometry.
ad60d40ed3 Cleanup: Move 'uneditable' info message about item renaming in Outliner to INFO.
4c8847ec4f Cleanup: Remove extern "C" from DNA headers
Compare 18 commits »
Lukas Tönne commented on pull request blender/blender#111704 2023-09-04 16:52:25 +02:00
Fix versioning old 2.6 node groups, causing dangling link pointers

@blender-bot build

Lukas Tönne pushed to test_nodegroup_compat at LukasTonne/blender 2023-09-04 16:32:44 +02:00
50c1d1af9b Completed test for 2.5 nodes as much as possible.
Lukas Tönne pushed to fix-versioning-26-node-groups at LukasTonne/blender 2023-09-04 16:29:41 +02:00
58ea865f09 Added missing 'compact' flag for sockets.
bad7e18689 Initialize socket typeinfo before node typeinfo.
4f84995bca Use warning instead of error for modifier issues to avoid test crash.
57b17483e8 Removed invalid nodeUniqueName calls.
bf3c7aedc0 Removed old 2.5 after_linking code that is already broken.
Compare 5 commits »
Lukas Tönne commented on pull request blender/blender#111704 2023-09-04 15:31:39 +02:00
Fix versioning old 2.6 node groups, causing dangling link pointers

I can't figure this out (in reasonable time and with acceptable sanity loss). I "fixed" the 2.5 after_linking code, but it still does not work because socket identifiers in the bNodeTree are…

Lukas Tönne commented on issue blender/blender#105722 2023-09-04 12:38:13 +02:00
Comb brush improvements

It's on hold, there were other priorities. Might come back to this or it might become part of the node tools project, no clear plans atm.

@SimonThommes no testing at this point, not sure if it…

Lukas Tönne pushed to test_nodegroup_compat at LukasTonne/blender 2023-09-04 11:26:13 +02:00
e1fab5a55b Started a versioning test for 2.5 node groups.
Lukas Tönne pushed to test_nodegroup_compat at LukasTonne/blender 2023-09-04 11:19:49 +02:00
fa8a74ab85 Test for node links as well to cover possible identifier mismatch.
792350a108 Added external links to the node group instance and test for count.
Compare 2 commits »
Lukas Tönne commented on pull request blender/blender#111704 2023-09-04 10:33:06 +02:00
Fix versioning old 2.6 node groups, causing dangling link pointers

Do you happen to know when the node systems that we use nowadays have been introduced?

Depends on what you mean by "systems that we use nowadays". Oldest commit to the nodes folder is from…

Lukas Tönne pushed to test_nodegroup_compat at LukasTonne/blender 2023-09-04 10:23:18 +02:00
3f82287faa Merge branch 'main' into test_nodegroup_compat
30de3d7c1a EEVEE-Next: Move LUT to C++ and eevee-next folder
8fe1ec100b BLI: Math: Allow vector of 1 component
760aa0e917 Cleanup: EEVEE-Next: Rename LookUpTable to Precompute
ad71a04de0 EEVEE-Next: Fix G1_V term used to compute the GGX pdf
Compare 75 commits »