Lukas Tönne LukasTonne
7 Followers · 0 Following
Repositories
6
 Projects Public Activity Starred Repositories
6
Lukas Tönne pushed to node-panels-final at LukasTonne/blender 2023-08-23 14:43:59 +02:00
0829157962 Copy all properties and flags when constructing legacy sockets.
e2e019f573 Ensure the legacy sockets are always freed after versioning.
Compare 2 commits »
Lukas Tönne pushed to node-panels-final at LukasTonne/blender 2023-08-23 13:13:58 +02:00
f8c1fe3830 Fix forward compatibility for node group interfaces.
Lukas Tönne pushed to node-panels-final at LukasTonne/blender 2023-08-23 11:04:44 +02:00
8ae73bdaa6 Merge branch 'main' into node-panels-final
b4c380acb4 Fix #109427: Shortcut missing in animation editors channel context menu
e2a35debde Fix #94129: Unable to remove added keying set from context menu
26e2f07dad Fix #111381: Crash when inserting a node onto a link inside a frame
0f0a2d9038 Correct error printing NDOF rotation
Compare 31 commits »
Lukas Tönne commented on pull request blender/blender#111348 2023-08-23 10:37:22 +02:00
Nodes: Panels integration with blend files and UI

Thanks for the reviews, i know it's a lot of code.

I wonder if we really want to use the green color for the backdrop. It seems like many node trees will be very green that way. Did we…

Lukas Tönne commented on pull request blender/blender#111348 2023-08-23 09:53:34 +02:00
Nodes: Panels integration with blend files and UI

Went over all the unwanted formatting changes, should be ok.

Lukas Tönne pushed to main at blender/blender 2023-08-23 08:51:14 +02:00
26e2f07dad Fix #111381: Crash when inserting a node onto a link inside a frame
Lukas Tönne deleted branch fix-discover-zones-crash from LukasTonne/blender 2023-08-23 08:51:14 +02:00
Lukas Tönne closed issue blender/blender#111381 2023-08-23 08:51:13 +02:00
Regression: Nodes: Crash when inserting on a link inside a frame
Lukas Tönne merged pull request blender/blender#111383 2023-08-23 08:51:12 +02:00
Fix #111381: Crash when inserting a node onto a link inside a frame
Lukas Tönne opened issue blender/blender#111399 2023-08-22 17:33:21 +02:00
Experimental group node operators: Crash when applying operator that has unconnected Geometry output
Lukas Tönne opened issue blender/blender#111394 2023-08-22 17:10:26 +02:00
Nodes: Crash with two node editors and viewer nodes
Lukas Tönne commented on issue blender/blender#111381 2023-08-22 14:20:25 +02:00
Regression: Nodes: Crash when inserting on a link inside a frame

Note that this may not happen under all circumstances. The topology cache can be rebuilt by other operations, which hides this bug.

Lukas Tönne created pull request blender/blender#111383 2023-08-22 14:14:19 +02:00
Fix #111381: Crash when inserting a node onto a link inside a frame.
Lukas Tönne pushed to fix-discover-zones-crash at LukasTonne/blender 2023-08-22 14:12:48 +02:00
6533c14ef8 Fix #111381: Crash when inserting a node onto a link inside a frame.
Lukas Tönne created branch fix-discover-zones-crash in LukasTonne/blender 2023-08-22 14:12:48 +02:00
Lukas Tönne opened issue blender/blender#111381 2023-08-22 14:07:40 +02:00
Nodes: Crash when inserting on a link inside a frame
Lukas Tönne commented on pull request blender/blender#111348 2023-08-22 12:13:19 +02:00
Nodes: Panels integration with blend files and UI

I'll add a bNodeSocketType argument to that callback to make it a classmethod

Aaaand unfortunately this also does not work: The callback is a full member of the NodeSocket class and as…

Lukas Tönne commented on pull request blender/blender#111348 2023-08-22 11:46:10 +02:00
Nodes: Panels integration with blend files and UI

Found one more issue with custom socket types (we should turn the custom_nodes.py script into a test!): The [typeinfo->draw_color](https://projects.blender.org/LukasTonne/blender/src/commit/8693…

Lukas Tönne pushed to node-panels-final at LukasTonne/blender 2023-08-22 11:15:13 +02:00
4255705f4b Removed legacy sockets from copy/free code, not needed.
76a8e6994f const pointers for writing where possible.
c87e7af6da Added comment to explain why const_cast is needed when building cache.
f1a88f079a Moved versioning code back to where it belongs after merge.
e6bafce090 Move class member variables to the top.
Compare 5 commits »
Lukas Tönne commented on pull request blender/blender#111348 2023-08-22 11:14:32 +02:00
Nodes: Panels integration with blend files and UI

This is ancient drawing code, the panel is just a simplified version of sockets (see bNodeSocketRuntime above). I'd rather not add new code here unless necessary, this can be changed later. The…