Lukas Tönne LukasTonne
Lukas Tönne pushed to geometry-nodes-flip at LukasTonne/blender 2023-08-18 12:19:58 +02:00
3a3532a0e4 Fixed remaining issues with value conversion.
Lukas Tönne pushed to geometry-nodes-flip at LukasTonne/blender 2023-08-18 10:34:21 +02:00
09ed2e7664 Completed grid value converter for reinterpreting Blender math as OpenVDB types.
f16101c976 Fixed registration for the "set grid value" node.
Compare 2 commits »
Lukas Tönne pushed to geometry-nodes-flip at LukasTonne/blender 2023-08-17 18:32:46 +02:00
36fedfa64f Temp: progress with OpenVDB grid converters.
Lukas Tönne pushed to geometry-nodes-flip at LukasTonne/blender 2023-08-17 18:23:28 +02:00
d70d9ffa39 Temp: progress with OpenVDB grid converters.
Lukas Tönne pushed to geometry-nodes-flip at LukasTonne/blender 2023-08-17 17:35:27 +02:00
43d1589078 Need converter specialization for both MaskGrid and BoolGrid.
Lukas Tönne pushed to geometry-nodes-flip at LukasTonne/blender 2023-08-17 15:52:01 +02:00
3d99cd075d Merge branch 'main' into geometry-nodes-flip
Lukas Tönne pushed to geometry-nodes-flip at LukasTonne/blender 2023-08-17 15:45:59 +02:00
9020dc99d2 Merge branch 'main' into geometry-nodes-flip
6f9c3b1bd5 Vulkan: Report Incompatible Shaders
b1b20bea7b Fix Shader::print_log not handling warnings
0a04a6d1a1 Cleanup: quiet GCC's -Wsuggest-attribute=format warning
bbe4f6cf74 Fix: Compilation Error When Compiling with Vulkan
Compare 263 commits »
Lukas Tönne commented on pull request blender/blender#110433 2023-08-17 13:58:04 +02:00
Fix: Explicitly prevent capturing built-in attribute with bad mata data

Can use else {, we already check for attribute_matches above.

Lukas Tönne commented on pull request blender/blender#110433 2023-08-17 13:58:04 +02:00
Fix: Explicitly prevent capturing built-in attribute with bad mata data

I feel like such a check should be performed on a lower level. Maybe always return a default (no-op) validator from lookup_validator when there is no metadata match. It feels like try_capture_field_on_geometry is the wrong place to do such sanity checks.

Lukas Tönne commented on pull request blender/blender#110433 2023-08-17 13:07:07 +02:00
Fix: Explicitly prevent capturing built-in attribute with bad mata data

Do we have existing tests where a regression test could be added? This particular case would be fixed, but since most attributes don't have validators adding some code coverage there could help in…

Lukas Tönne commented on pull request blender/blender#110436 2023-08-17 12:58:47 +02:00
Cleanup: Geometry Nodes: Reduce templates for deal with geometry components

static_cast is fine here. We know the type is correct and we don't check the result. The old code does the same with

Lukas Tönne approved blender/blender#110436 2023-08-17 12:58:47 +02:00
Cleanup: Geometry Nodes: Reduce templates for deal with geometry components

Agreed, casting to specific components first and then back to generic components for joining attributes is confusing.

Lukas Tönne created pull request LukasTonne/blender#1 2023-08-17 11:55:54 +02:00
Part 3/3 of #109135, #110272
Lukas Tönne created branch node-panels-final in LukasTonne/blender 2023-08-17 11:51:20 +02:00
Lukas Tönne pushed to node-panels-final at LukasTonne/blender 2023-08-17 11:51:20 +02:00
8a8c02a383 Part 3/3 of #109135, #110272
Lukas Tönne commented on pull request blender/blender#110952 2023-08-17 11:34:18 +02:00
Node panels: RNA for node group interfaces
Lukas Tönne pushed to node-group-interface-ui at LukasTonne/blender 2023-08-17 11:33:16 +02:00
a39af81f55 Fix socket color callbacks for builtin types, must not depend on pointer.
Lukas Tönne pushed to node-group-interface-ui at LukasTonne/blender 2023-08-17 11:04:08 +02:00
428efdb7e3 Merge branch 'node-panels-rna' into node-group-interface-ui
8275674cd8 Cleanup: nullptr instead of NULL.
f89c86abe9 Use a simple static array for socket subtype names to avoid allocation.
3bb144060e Cleanup: Use "Note" instead of "XXX" for temporary comments.
aa28a7dfa6 Fixed changed header names after merge.
Compare 270 commits »