Block a user
Fix: Explicitly prevent capturing built-in attribute with bad mata data
Can use else {, we already check for attribute_matches above.
Fix: Explicitly prevent capturing built-in attribute with bad mata data
I feel like such a check should be performed on a lower level. Maybe always return a default (no-op) validator from lookup_validator when there is no metadata match. It feels like try_capture_field_on_geometry is the wrong place to do such sanity checks.
Fix: Explicitly prevent capturing built-in attribute with bad mata data
Do we have existing tests where a regression test could be added? This particular case would be fixed, but since most attributes don't have validators adding some code coverage there could help in…
Cleanup: Geometry Nodes: Reduce templates for deal with geometry components
static_cast is fine here. We know the type is correct and we don't check the result. The old code does the same with
Cleanup: Geometry Nodes: Reduce templates for deal with geometry components
Agreed, casting to specific components first and then back to generic components for joining attributes is confusing.
Part 3/3 of #109135, #110272