Lukas Tönne LukasTonne
Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 16:24:49 +02:00
Node panels: New DNA and C++ API for node group interfaces

fine ...

Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 16:20:07 +02:00
Node panels: New DNA and C++ API for node group interfaces

I copied the init code from existing node_socket.cc, which also [does nothing here](e1b1b2a8b4/source/blender/n

Lukas Tönne pushed to node-panels-dna at LukasTonne/blender 2023-08-08 16:07:24 +02:00
65bbe37402 Merge branch 'main' into node-panels-dna
e1b1b2a8b4 Fix (unreported) collection 'readfile' expand incorrect assertion.
5dfd3e3c28 Fix (unreported) missing handling of ViewLayer IDProperties in foreach_id code.
1bcf31a874 Color management: Refactor OCIO config to be CIE XYZ I-E based
b880485492 Nodes: add Floored Modulo mode to Math nodes
Compare 35 commits »
Lukas Tönne pushed to node-group-interface-ui at LukasTonne/blender 2023-08-08 16:06:54 +02:00
153301627d Merge branch 'node-panels-dna' into node-group-interface-ui
fd7adb892c Comment for active_index.
3e23273a47 Fixed comment.
0f231dbbeb Remove "e" prefix from NodeTreeInterfaceItemType.
9f15e7cf85 Simply pass nullptrs to the draw_color callback for undefined pointers.
Compare 13 commits »
Lukas Tönne pushed to node-panels-dna at LukasTonne/blender 2023-08-08 16:06:35 +02:00
fd7adb892c Comment for active_index.
3e23273a47 Fixed comment.
0f231dbbeb Remove "e" prefix from NodeTreeInterfaceItemType.
9f15e7cf85 Simply pass nullptrs to the draw_color callback for undefined pointers.
Compare 4 commits »
Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 15:47:07 +02:00
Node panels: New DNA and C++ API for node group interfaces

Oh, got it, fixed.

Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 15:35:02 +02:00
Node panels: New DNA and C++ API for node group interfaces

The null in the name indicates the end-of-line terminal. It's still a wrapper for real strings only.

@mod_moder I switched to StringRefNull because that guarantees a null-terminated string…

Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 15:23:31 +02:00
Node panels: New DNA and C++ API for node group interfaces

Wrt StringRefNull (can't find the comment any more): Problem is that this thing does not accept nullptr (or rather: accepts it and asserts internally). That just puts the burden of null checks…

Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 14:59:50 +02:00
Node panels: New DNA and C++ API for node group interfaces

I'd like to stick to the BKE naming scheme for freeing/copying ID datablocks here

Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 14:55:07 +02:00
Node panels: New DNA and C++ API for node group interfaces

As concluded in #109288 the draw_color callback should now support nullptr/None for both the context and the bNode pointer. This is technically a breaking change (note added to #110272) but very unlikely to cause trouble since very few addons implement interface classes and even fewer would have context-based colors.

Lukas Tönne pushed to node-panels-dna at LukasTonne/blender 2023-08-08 14:33:42 +02:00
2e19d859d3 Cleanup: Renaming and comments in interface classes.
Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 14:33:23 +02:00
Node panels: New DNA and C++ API for node group interfaces

But "self" would be the interface, not a panel

Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 14:10:26 +02:00
Node panels: New DNA and C++ API for node group interfaces

I'm guessing bNodeTreeInterfacePanel::name

Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 13:56:56 +02:00
Node panels: New DNA and C++ API for node group interfaces

Which field does this refer to?

Lukas Tönne pushed to node-panels-dna at LukasTonne/blender 2023-08-08 13:08:29 +02:00
ac5f63189a Use string identifiers for interface sockets for compatibility.
Lukas Tönne pushed to node-group-interface-ui at LukasTonne/blender 2023-08-08 13:08:27 +02:00
21d96c8e54 Merge branch 'node-panels-dna' into node-group-interface-ui
ac5f63189a Use string identifiers for interface sockets for compatibility.
04bf7e40f1 Use string identifiers for interface sockets for compatibility.
Compare 3 commits »
Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 13:04:39 +02:00
Node panels: New DNA and C++ API for node group interfaces

Yeah i'm just using a string identifier now, for the sake of simplicity and compatibility.

Lukas Tönne pushed to node-panels-dna at LukasTonne/blender 2023-08-08 12:22:40 +02:00
a057be8f37 Use StringRefNull and c_str accessor to guarantee null-terminated strings.
Lukas Tönne pushed to node-group-interface-ui at LukasTonne/blender 2023-08-08 12:22:37 +02:00
530a35820c Merge branch 'node-panels-dna' into node-group-interface-ui
a057be8f37 Use StringRefNull and c_str accessor to guarantee null-terminated strings.
1d3f9a6c06 Use StringRefNull and c_str accessor to guarantee null-terminated strings.
6930fefe32 Use this-> before member function calls.
7fac55e690 Added BLI_strdup_null function that handles nullptr gracefully.
Compare 5 commits »
Lukas Tönne commented on pull request blender/blender#110885 2023-08-08 12:02:22 +02:00
Node panels: New DNA and C++ API for node group interfaces

StringRef does not have c_str. Or was this referring to something else? Gitea seems to have lost track of what this comment refers to ...

Should i be using StringRefNull for anything that…