Lukas Tönne LukasTonne
Lukas Tönne pushed to node-group-interface-ui at LukasTonne/blender 2023-06-21 13:41:08 +02:00
b6cad48f65 Merge branch 'node-group-interface' into node-group-interface-ui
edf07f2adb Tentative sorting algorithm for panels and sockets.
Compare 2 commits »
Lukas Tönne pushed to node-group-interface at LukasTonne/blender 2023-06-21 13:41:06 +02:00
edf07f2adb Tentative sorting algorithm for panels and sockets.
Lukas Tönne pushed to node-group-interface-ui at LukasTonne/blender 2023-06-21 13:38:41 +02:00
158c51659f Added missing header.
Lukas Tönne commented on issue blender/blender#109135 2023-06-21 13:13:08 +02:00
New data structures for node group interface declaration
  • Renamed bNodeTreeDeclaration to bNodeTreeInterface
  • Changed panel assignment to a panel/parent pointer in sockets and panels respectively
Lukas Tönne created branch node-group-interface-ui in LukasTonne/blender 2023-06-21 12:42:39 +02:00
Lukas Tönne pushed to node-group-interface-ui at LukasTonne/blender 2023-06-21 12:42:39 +02:00
bd9e2c57a4 Tentative sorting algorithm for panels and sockets.
bb948255a3 Squashed commit of the following:
Compare 2 commits »
Lukas Tönne opened issue blender/blender#109171 2023-06-20 19:52:32 +02:00
"Duplicate Elements" node crashes with "-1" argument on splines
Lukas Tönne commented on issue blender/blender#109135 2023-06-20 16:56:27 +02:00
New data structures for node group interface declaration

That's already the case for meshes though, and means we don't constantly have to convert back and forth between the old and new versions when saving files for the foreseeable future, which is…

Lukas Tönne commented on issue blender/blender#109135 2023-06-20 16:07:07 +02:00
New data structures for node group interface declaration

What do you see as the benefit of this, for the code? In the UI it makes some sense, to simplify aligning sockets, but it seems like keeping a clear separation between inputs and outputs…

Lukas Tönne created pull request blender/blender#109158 2023-06-20 15:44:56 +02:00
WIP: Tree view for node group interfaces
Lukas Tönne deleted branch node-group-declaration from LukasTonne/blender 2023-06-20 14:59:09 +02:00
Lukas Tönne created branch node-group-interface in LukasTonne/blender 2023-06-20 14:58:52 +02:00
Lukas Tönne pushed to node-group-interface at LukasTonne/blender 2023-06-20 14:58:52 +02:00
ce8fa593af Renamed bNodeTreeDeclaration to bNodeTreeInterface.
Lukas Tönne pushed to node-group-declaration at LukasTonne/blender 2023-06-20 14:42:01 +02:00
756c1a25a5 API functions for adding and removing sockets and panels.
Lukas Tönne commented on issue blender/blender#109135 2023-06-20 12:19:21 +02:00
New data structures for node group interface declaration
  • Generally makes sense that the panels know about the contained sockets and not the other way around. In practice we may need a backpointer, but that can just be a cache.

Yes, there would be…

Lukas Tönne commented on pull request blender/blender#109039 2023-06-20 11:07:07 +02:00
Cleanup: Node panels fixing/simplification

Jacques defines it like so:

the *_for_write suffix on functions is only necessary if the function is doing extra work in this compared to the const version. (e.g. custom data layers may be…

Lukas Tönne commented on issue blender/blender#109135 2023-06-19 19:46:12 +02:00
New data structures for node group interface declaration

UI design task for node panels: #108895

Lukas Tönne opened issue blender/blender#109135 2023-06-19 19:40:43 +02:00
New data structures for node group interface declaration
Lukas Tönne commented on pull request blender/blender#109039 2023-06-19 18:42:15 +02:00
Cleanup: Node panels fixing/simplification

IIRC we use the _for_write suffix to be very clear about write access

Lukas Tönne commented on pull request blender/blender#109039 2023-06-19 18:36:51 +02:00
Cleanup: Node panels fixing/simplification

I'm fleshing out a new struct for node tree declarations that will include the current bNodeTree::inputs, outputs, and panels. The primary API can be in C++ since we have C++ RNA now for…