Lukas Tönne LukasTonne
7 Followers · 0 Following
Repositories
6
 Projects Public Activity Starred Repositories
6
Lukas Tönne merged pull request blender/blender#106919 2023-04-24 14:26:28 +02:00
Simulation nodes: UI for simulation state items in sidebar
Lukas Tönne pushed to geometry-nodes-simulation at blender/blender 2023-04-24 14:26:28 +02:00
8446b2cad1 Simulation nodes: UI for simulation state items in sidebar
Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-24 12:06:16 +02:00
2653fdf5de Cleanup: renamed items_mutable_span to items_span_for_write.
Lukas Tönne commented on pull request blender/blender#106919 2023-04-24 11:53:02 +02:00
Simulation nodes: UI for simulation state items in sidebar

I opted for items_span_for_write now, if that's ok for you.

Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-24 11:48:26 +02:00
1248a0bb2f Remove else after return.
f8c0330f84 Cleanup: comment line style.
e3d10f73db Cleanup: doxygen return statement style.
45d99b3e11 Use "items" instead of "state items" as UI text for simulation zones.
237619e4f2 Cleanup: dots after comments.
Compare 7 commits »
Lukas Tönne commented on pull request blender/blender#106919 2023-04-24 11:46:52 +02:00
Simulation nodes: UI for simulation state items in sidebar

We already have NodeSimulationItem *items for the array, so Span<NodeSimulationItem> items() is a conflict, otherwise items + items_for_write would work.

Lukas Tönne commented on pull request blender/blender#106919 2023-04-24 11:21:45 +02:00
Simulation nodes: UI for simulation state items in sidebar

Didn't realize we had a dedicated operator py file for geonodes, will move it there.

Lukas Tönne commented on pull request blender/blender#106919 2023-04-24 11:21:32 +02:00
Simulation nodes: UI for simulation state items in sidebar

For the color thing, I think I still prefer clarity/simplicity in the API and pushing the complexity to an RNA helper function.

Problem is the std_node_socket_colors list is currently part…

Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-24 11:14:28 +02:00
7f7fd97fad Merge branch 'geometry-nodes-simulation' into geometry-nodes-simulation-item-ui
c396f41e14 Merge branch 'main' into geometry-nodes-simulation
a9f02cd8d8 Geometry Nodes: add map from bsocket index to lf socket index
1e81e27557 Cleanup: use hash value that fits into int to fix compile error
8523e361e8 BLI: use decay_t to determine type to hash
Compare 80 commits »
Lukas Tönne commented on pull request blender/blender#107133 2023-04-24 11:07:06 +02:00
Add support for attributes storage in simulation state

Renamed the functions and added comments for clarity. Also the copy_simulation_state_to_output_param function is now shared by input and output node, they both need to do this: input node when…

f8ffd4f5b8 Functional cast for enum class result checks.
cfe957c584 Cleanup: Comments and better description of the input/output copy functions.
4f32d1dbc9 Merge branch 'geometry-nodes-simulation' into geometry-nodes-simulation-attribute-support
c396f41e14 Merge branch 'main' into geometry-nodes-simulation
a9f02cd8d8 Geometry Nodes: add map from bsocket index to lf socket index
1e81e27557 Cleanup: use hash value that fits into int to fix compile error
Compare 81 commits »
Lukas Tönne commented on pull request blender/blender#107133 2023-04-22 10:28:52 +02:00
Add support for attributes storage in simulation state

Was just an ad-hoc name: it's copying from the simulation state into the output parameter for the next iteration. I'll add some comments.

Lukas Tönne commented on pull request blender/blender#107133 2023-04-22 10:25:20 +02:00
Add support for attributes storage in simulation state

Implicit cast to bool does not work with enum class unfortunately (suggested by Jacques above). Functional cast should be fine though.

75eea532d0 Cleanup: const variables and functional-style cast for enums.
ce48300fc6 Extend comment for multi-pass field type propagation.
4dea23a734 Cleanup: Use enum class and a NONE item for the eFieldStateSyncResult.
Compare 3 commits »
Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-21 12:00:41 +02:00
0ae64ec056 Cleanup: use early exit for consistency.
Lukas Tönne commented on pull request blender/blender#106919 2023-04-21 11:58:15 +02:00
Simulation nodes: UI for simulation state items in sidebar

Removed the unused function though.

Lukas Tönne commented on pull request blender/blender#106919 2023-04-21 11:57:30 +02:00
Simulation nodes: UI for simulation state items in sidebar

Also note i've added C++ spans to the NodeGeometrySimulationOutput now to make this a bit nicer.