Lukas Tönne LukasTonne
7 Followers · 0 Following
Repositories
6
 Projects Public Activity Starred Repositories
6
Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 14:43:46 +02:00
Add support for attributes storage in simulation state

I reverted the changes to SimulationStateItem and the templated copy functions. There are dummy functions now that simply output the default value based on the CPPType. This can be implemented…

5eeef12f96 Reverted SimulationStateItem changes and templated copy functions.
d17ad3f7fb WIP: use templated item class only for simple data types.
Compare 2 commits »
e904bac1ca Remove unused comparison operators for SocketFieldState.
Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 12:27:48 +02:00
Add support for attributes storage in simulation state

Don't actually need them any more since i only look at requires_single now, but will keep it in mind for later.

Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 12:18:13 +02:00
Add support for attributes storage in simulation state

TBH i just added a bunch of common constructors without considering the details, just to get it working.

3184d3499b Use bNodeSocketType to get CPPTypes for simulation items.
Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 12:16:08 +02:00
Add support for attributes storage in simulation state

Yeah that works too. I just wanted to keep it simple, considering we have to do a bunch of type switches elsewhere anyway. Have to get the type idname from the eNodeSocketDatatype, then get…

dd0fc76ba0 Cleanup: Use enum types and const parameters where possible.
c528579b34 Comment on index offset in simulation input node output parameters.
dfe18c5112 Cleanup: Clang formatting
695258c4d4 ENUM_OPERATORS for eFieldStateSyncResult to use it as a flag instead of int.
aa9c2b11f6 Use backslash style of doxygen syntax.
Compare 5 commits »
fce480ce1e Merge branch 'geometry-nodes-simulation' into geometry-nodes-simulation-attribute-support
80fdf4a88d Merge branch 'main' into geometry-nodes-simulation
716b9cff23 Fix: Search in node editors missing items
945d71b56b Merge branch 'main' into geometry-nodes-simulation
5ca7e1301f Cleanup: Remove redundant custom data initialization
Compare 42 commits »
60f1e7fe76 Simplified field state syncing.
Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 10:24:47 +02:00
Add support for attributes storage in simulation state

I wonder if is_field_source has to be propagated

It's not obvious from the state struct what gets propagated where, but looking if i'm not mistaken:

  • requires_single is propagated R->L to…
Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 09:52:13 +02:00
Add support for attributes storage in simulation state

I'd be fine with only handling the UI part in this patch (so the field inferencing). These sockets can just be ignored during evaluation for now. I think it would be easier to solve that in a…

Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 09:50:17 +02:00
Add support for attributes storage in simulation state

I found one correctness issue. The position input here should have a dot in the socket because it's currently a single value but can be a field.

Yeah, the sync_field_states currently…

Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 09:43:09 +02:00
Add support for attributes storage in simulation state

You're right, combining states first and then comparing is a lot shorter.

5681327da9 Fix merge error.
Lukas Tönne created pull request blender/blender#107133 2023-04-19 16:15:12 +02:00
Add support for attributes storage in simulation state.
a0f113a408 Merge branch 'geometry-nodes-simulation' into geometry-nodes-simulation-attribute-support
a5140712cc Merge branch 'main' into geometry-nodes-simulation
e45ed69349 Attributes: Integrate implicit sharing with the attribute API
19ac02767c Fix regression in recent BLI_path extension logic
fd10ecaeaf Fix bitwise logical operation in Metal backend
Compare 109 commits »
b5c9acf8c7 Forward propagation of field state including special sim zone dependencies.
15b9a3d099 Modified field state propagation function to include simulation zones.
057ccfa22a Add nominal field support to the sockets generated by simulation nodes.