Lukas Tönne LukasTonne
Lukas Tönne approved blender/blender#130437 2024-11-18 11:00:28 +01:00
Fix #130376: GPv3: Outline modifier traces flat caps incorrectly

The fix is correct, thanks!

Lukas Tönne commented on pull request blender/blender#130341 2024-11-18 10:42:43 +01:00
Fix #125559: Eraser does not find intersections at small scales

Hold on, this also deletes points outside of the circle

@frogstomp Thanks for catching this. I had a flipped a sign in the calculation, causing the distance to be inverted (stuff outside the…

Lukas Tönne pushed to fix-gpv3-eraser-small-scale at LukasTonne/blender 2024-11-18 10:41:49 +01:00
c30f3ebeec Fix inverted distance value, causing points outside the radius get deleted.
b92b3c8aeb Merge branch 'main' into fix-gpv3-eraser-small-scale
704d34fe0f Fix: properly save in-memory and packed textures during USD export
1a96d73f52 Fix: DRW: PassSimple do not pass resource_id correctly
94d2a1e6a2 GPU: GLSL CPP stubs: Allow printf in code
Compare 28 commits »
Lukas Tönne pushed to main at LukasTonne/.profile 2024-11-18 09:43:46 +01:00
3e0669d8c0 update
Lukas Tönne commented on pull request blender/blender#130341 2024-11-15 19:15:26 +01:00
Fix #125559: Eraser does not find intersections at small scales

Note that the factor 2 here is superfluous, but i left it in to keep changes minimal.

Lukas Tönne created pull request blender/blender#130341 2024-11-15 18:08:20 +01:00
Fix #125559: Eraser does not find intersections at small scales
Lukas Tönne pushed to fix-gpv3-eraser-small-scale at LukasTonne/blender 2024-11-15 18:07:35 +01:00
80667e2813 Fix #125559: Eraser does not find intersections at small scales.
87cf01efab Refactor: Grease Pencil: Port Vfx drawing to new draw manager
8e75b5f4c7 Merge branch 'blender-v4.3-release'
217fa8d09e Fix #130276: Trace operator needs to tag data after curves replacement
dbcc9d7820 Refactor: Keying set code
Compare 10 commits »
Lukas Tönne created branch fix-gpv3-eraser-small-scale in LukasTonne/blender 2024-11-15 18:07:34 +01:00
Lukas Tönne commented on issue blender/blender#125559 2024-11-15 17:34:06 +01:00
GPv3: Eraser is unable to erase some points

If anyone else has a hard time wrapping their head around the math: I made a geometry nodes setup to simulate the intersection test.

![intersection_math](/attachments/1820fa31-6349-467a-84a4-95d…

Lukas Tönne commented on issue blender/blender#125559 2024-11-15 16:09:54 +01:00
GPv3: Eraser is unable to erase some points

After lots of debug printing it looks like the root cause is a bug in the intersection math. A number of points that are clearly inside the circle do not detect any intersections of their…

Lukas Tönne pushed to fix-trace-sequence at LukasTonne/blender 2024-11-15 14:26:05 +01:00
6773f9fe0e Cleanup formatting.
Lukas Tönne pushed to fix-trace-sequence at LukasTonne/blender 2024-11-15 14:16:30 +01:00
5344a2efd4 Fix #130275: Trace sequence operator only uses first frame.
8e75b5f4c7 Merge branch 'blender-v4.3-release'
217fa8d09e Fix #130276: Trace operator needs to tag data after curves replacement
dbcc9d7820 Refactor: Keying set code
f20cd471fe Merge branch 'blender-v4.3-release'
Compare 1125 commits »
Lukas Tönne commented on pull request blender/blender#130317 2024-11-15 12:51:17 +01:00
Fix #130275: Trace sequence operator only uses first frame

Looks like you need to pull the changes I pushed to fix-gpv3-trace-race

Will do that when the other PR has landed, less hassle. This should also go into main rather than blender-v4.3-release,…

Lukas Tönne commented on issue blender/blender#125559 2024-11-15 12:30:07 +01:00
GPv3: Eraser is unable to erase some points

Thanks @frogstomp, i was able to repro it now. The issue seems to be that the last point of a stroke remains, but only when the stroke starts at the last point.

Lukas Tönne created pull request blender/blender#130317 2024-11-15 12:11:31 +01:00
Fix #130275: Trace sequence operator only uses first frame