Could support a type selection enum here, with a dropdown menu invoke.
I wonder if we could put the list in the existing
Nodesidebar tab instead of adding a new one. That might be a more consistent/expected place for it. What do you think about that?
Would be…
otherwise I think it would make more sense for that unification to happen first, better not to leave it like this longer term.
I'll give the copy unification #106852 a go and see if i run…
Assigning nullptr to a std::string is undefined behavior. We also ensure the item.name is never empty now, but it's better not to rely on that alone and check the char * as well.
This function is now also used to check for uniqueness of items that are already in the list. This check avoids detecting duplicates from the same socket.
Exposing socket type colors through ED_node_type_draw_color adds another bad level call. Since the same file already has other UI functions used this way it doesn't make things any worse at least.
Connecting the __extend__ socket updates both input and output node, but only because of the blanket NTREE_CHANGED_LINK handling which updates all nodes in the tree when a link is changed.