Lukas Tönne LukasTonne
75eea532d0 Cleanup: const variables and functional-style cast for enums.
ce48300fc6 Extend comment for multi-pass field type propagation.
4dea23a734 Cleanup: Use enum class and a NONE item for the eFieldStateSyncResult.
Compare 3 commits »
Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-21 12:00:41 +02:00
0ae64ec056 Cleanup: use early exit for consistency.
Lukas Tönne commented on pull request blender/blender#106919 2023-04-21 11:58:15 +02:00
Simulation nodes: UI for simulation state items in sidebar

Removed the unused function though.

Lukas Tönne commented on pull request blender/blender#106919 2023-04-21 11:57:30 +02:00
Simulation nodes: UI for simulation state items in sidebar

Also note i've added C++ spans to the NodeGeometrySimulationOutput now to make this a bit nicer.

Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-21 11:56:19 +02:00
6e2e398922 Use C++ span members in NodeGeometrySimulationOutput for cleaner code.
823f401c4d Ensure correct topology cache in the node search function for RNA.
877986ccda Remove unused node search function.
0fd13ae285 Fix typo.
Compare 4 commits »
Lukas Tönne commented on pull request blender/blender#106919 2023-04-21 10:50:56 +02:00
Simulation nodes: UI for simulation state items in sidebar

Downside of putting this in RNA is that we don't have access to the C++ functions like ntree->nodes_by_type there.

Lukas Tönne commented on pull request blender/blender#107133 2023-04-21 10:32:24 +02:00
Add support for attributes storage in simulation state

Sorry, it's kinda hard to figure out the correct behavior here. I think i've fixed it now by syncing only the output field states. This should work, because the requires_single flag on inputs…

d3a8401d7b Only sync field state for the output sockets.
Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-20 18:16:21 +02:00
485f0644c0 Use std::to_string to construct simulation state socket identifiers.
Lukas Tönne commented on pull request blender/blender#106919 2023-04-20 18:15:24 +02:00
Simulation nodes: UI for simulation state items in sidebar

I'm not sure what you mean here. I'm checking the iterator here to avoid comparing it to itself, to prevent fake name collision. Otherwise having an existing item "XY" and entering the name "XY"…

Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 18:04:35 +02:00
Add support for attributes storage in simulation state

Now this socket seems to be wrong. It should be a field. Currently it would be possible to connect this socket to e.g. a cube node without any visible warning in the ui. ![image](/attachments/…

7d7b631863 Fix propagation of the is_single field state.
Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 17:48:52 +02:00
Add support for attributes storage in simulation state

Am I missing something or is this now breaking simulations completely?

Should be fixed, now geometry sockets should be working again. Other data types just use a dummy state item that doesn't…

9a4a331df9 Restore default behavior for GeometrySet simulation state items.
Lukas Tönne commented on pull request blender/blender#106919 2023-04-20 17:12:35 +02:00
Simulation nodes: UI for simulation state items in sidebar

Hah, i always forget how this number-to-string stuff works in C++, somehow find it easier to remember old BLI.

Lukas Tönne commented on pull request blender/blender#107133 2023-04-20 17:11:02 +02:00
Add support for attributes storage in simulation state

Yeah i removed all the copying of state item data in the process of removing the templated types. Could add that back for the geometry i suppose.

Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-20 17:07:15 +02:00
30d86535ac Use a filter with node_socket_data_type_items instead of a custom items list.
e0d2be408e Fix missing EnumProperty import.
Compare 2 commits »
Lukas Tönne commented on pull request blender/blender#106919 2023-04-20 16:36:15 +02:00
Simulation nodes: UI for simulation state items in sidebar

Adding a "color" property to SimulationStateItem really doesn't feel like the right way to draw them in the UI. That information should probably only be accessible from the socket types. Could…

Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-20 16:31:46 +02:00
66c5f8cf96 Revert "Replaced color property of state items with a static method in RNA."
Lukas Tönne pushed to geometry-nodes-simulation-item-ui at LukasTonne/blender 2023-04-20 16:28:45 +02:00
ef3ed4f652 Replaced color property of state items with a static method in RNA.
9a2cdd99a3 Change panel title for state items to "Simulation State".
0db57ca8fb Move the simulation state panel into the "Node" sidebar category.
Compare 3 commits »