Lukas Tönne LukasTonne
8 Followers · 0 Following
Repositories
6
 Projects Public Activity Starred Repositories
6
Lukas Tönne commented on pull request blender/blender#129943 2024-11-07 16:30:35 +01:00
Fix #129346: GPv3: Merge layers into correct groups when applying modifier

Ah wait, this needs to be rebased onto blender-v4.3-release.

Fixed

Lukas Tönne pushed to gpv3-apply-modifier-layer-groups at LukasTonne/blender 2024-11-07 16:29:57 +01:00
deaaafb5ab Fix layer groups when applying modifiers.
4ba30cf82e Fix #129417: Geometry Nodes gizmos don't create keyframes when auto keying is on
658700ddff Fix #126364: Metal: modified texture usage flags causing cache misses
d9748470fa Fix #125230: Issues when loading file with pinning gpencil brush material
c182dadf9f Fix (unreported) GPv3 Undo: memory-after-use.
Compare 71 commits »
Lukas Tönne commented on issue blender/blender#129324 2024-11-07 15:59:56 +01:00
Grease Pencil - Merge Down operator causes layer order to change

This sounds like an issue i noticed in #129943 as well: geometry::merge_layers does not include layer groups, and then adding/sorting the layers one-by-one ignores groups, which float to the top…

Lukas Tönne approved blender/blender#129918 2024-11-07 13:57:42 +01:00
Fix #129900: GPv3: Invalid handling of unused drawings removal.
Lukas Tönne approved blender/blender#129960 2024-11-07 13:38:35 +01:00
Fix #126076: GPv3: Strokes in multi-frame mode always use onion skinning colors
Lukas Tönne approved blender/blender#129959 2024-11-07 13:35:12 +01:00
Fix #129642: material lost after first frame in uncached simulation zone
Lukas Tönne pushed to main at blender/blender 2024-11-07 13:33:56 +01:00
41b3f05a63 Merge branch 'blender-v4.3-release'
dc04d9abc7 Fix (unreported): GPv3: Incorrect user count for drawing at index 0
Compare 2 commits »
Lukas Tönne deleted branch fix-gp-drawing-zero-user-count from LukasTonne/blender 2024-11-07 13:31:51 +01:00
Lukas Tönne merged pull request blender/blender#129955 2024-11-07 13:31:47 +01:00
Fix (unreported): GPv3: Incorrect user count for drawing at index 0
Lukas Tönne pushed to blender-v4.3-release at blender/blender 2024-11-07 13:31:46 +01:00
dc04d9abc7 Fix (unreported): GPv3: Incorrect user count for drawing at index 0
Lukas Tönne commented on pull request blender/blender#129955 2024-11-07 12:56:08 +01:00
Fix (unreported): GPv3: Incorrect user count for drawing at index 0

@blender-bot build

Lukas Tönne created pull request blender/blender#129955 2024-11-07 12:54:35 +01:00
Fix (unreported): incorrect user count for GP drawing 0
Lukas Tönne pushed to fix-gp-drawing-zero-user-count at LukasTonne/blender 2024-11-07 12:53:22 +01:00
039f24bcdd Fix (unreported): incorrect user count for GP drawing 0.
831166b4dc Fix #129907: Grease Pencil brush size gets stuck at 0
30ba6bfa7e Cleanup: Unused function argument
f3342fa680 Fix #129708: Vulkan: Add limit checks when creating images
f896242477 Vulkan: Disable GPU depth picking on official AMD/NVIDIA drivers
Compare 10 commits »
Lukas Tönne created branch fix-gp-drawing-zero-user-count in LukasTonne/blender 2024-11-07 12:53:22 +01:00
Lukas Tönne commented on pull request blender/blender#129918 2024-11-07 12:48:59 +01:00
Fix #129900: GPv3: Invalid handling of unused drawings removal.

I can confirm that:

  1. This fixes the update_drawing_users_for_layer user counting, so drawing 0 actually gets a user increment from layers using it:
diff --git a/source/blender/blenke…
Lukas Tönne commented on pull request blender/blender#129918 2024-11-07 12:37:04 +01:00
Fix #129900: GPv3: Invalid handling of unused drawings removal.

I made a unit test for this case - and while writing that found another bug (whaaaaaaaaa).

unit test 
TEST(greasepencil, remove_drawings_last_unused)
{…
Lukas Tönne commented on issue blender/blender#129346 2024-11-07 11:26:46 +01:00
Grease Pencil - Applying modifier makes layers hierarchy lose track of group - layer relations

@Marco-Rotili I added my own PR, sorry for stealing the thunder 😁 I ended up rewriting much of that function, it seemed better to make a new one.

Lukas Tönne commented on pull request blender/blender#129943 2024-11-07 11:24:16 +01:00
Fix #129346: GPv3: Merge layers into correct groups when applying modifier

Here's a test file to help catch some more interesting cases:

  • multiple groups
  • mixed layers/groups
  • geonodes inserting new layers
Lukas Tönne created pull request blender/blender#129943 2024-11-07 11:21:19 +01:00
Fix #129346: GPv3: Merge layers into correct groups when applying modifier
Lukas Tönne pushed to gpv3-apply-modifier-layer-groups at LukasTonne/blender 2024-11-06 16:43:32 +01:00
e43f9e358d Fix layer groups when applying modifiers.
6ba58a8303 Fix (unreported) unclear potential invalid readfile behavior on unknown BHead type.
2f6197daa9 Assets: Update assets repository hash for essentials library updates
a3b04dffbc Fix #129798: GPv3: Selection to Cursor/Grid missing immediate update
74f98b1e92 Fix: Geometry Nodes: crash when converting layers to instances
Compare 10 commits »