Lukas Tönne LukasTonne
7 Followers · 0 Following
Repositories
6
 Projects Public Activity Starred Repositories
6
Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 17:29:00 +02:00
GPv3: Interpolate Tool

@blender-bot build

Lukas Tönne pushed to gpv3-interpolate-tool at LukasTonne/blender 2024-06-18 17:28:35 +02:00
036b4e0831 Fix outdated function calls after changing a bool parameter to float.
Lukas Tönne commented on pull request blender/blender#123383 2024-06-18 17:17:59 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

Ah yes, correct. My point is: it doesn't affect resolution of the straight sections, which is what i would expect when reading "subdivisions".

Lukas Tönne suggested changes for blender/blender#123383 2024-06-18 16:43:14 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

Looks good, just have some suggestions for making parameters more intuitive.

Lukas Tönne commented on pull request blender/blender#123383 2024-06-18 16:43:13 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

Comments would be good here (see other comments about changing parameters):

Lukas Tönne commented on pull request blender/blender#123383 2024-06-18 16:43:12 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

Rename subdivisions to cap_subdivisions, since they only affect cap resolution.

Lukas Tönne commented on pull request blender/blender#123383 2024-06-18 16:43:11 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

I'm not sure if the keep_shape argument makes sense. It just makes it ignore the radius_offset for the actual outline, in that case the radius is only used for the resulting stroke radius. This is confusing, but i just copied what works for GPv2.

Lukas Tönne pushed to geometry-nodes-rb-component-cache at LukasTonne/blender 2024-06-18 15:39:38 +02:00
91f0262610 Merge branch 'geometry-nodes-rb-component' into geometry-nodes-rb-component-cache
1273654646 Merge branch 'main' into geometry-nodes-rb-component
8cd282e48c Merge branch 'blender-v4.2-release'
979e142965 Fix: EEVEE: Object holdout not working
56c1163c21 Fix: Cycles OptiX wrong stack size for OSL pipeline
Compare 35 commits »
Lukas Tönne pushed to geometry-nodes-rb-component at LukasTonne/blender 2024-06-18 15:39:34 +02:00
1273654646 Merge branch 'main' into geometry-nodes-rb-component
8cd282e48c Merge branch 'blender-v4.2-release'
979e142965 Fix: EEVEE: Object holdout not working
56c1163c21 Fix: Cycles OptiX wrong stack size for OSL pipeline
71c716d8c0 Vulkan: Fix incorrect texture update
Compare 34 commits »
Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 15:32:35 +02:00
GPv3: Interpolate Tool

@blender-bot build

Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 15:32:10 +02:00
GPv3: Interpolate Tool

This now uses the shared resample_curve_attribute method, same as the resampling code.

Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 15:30:56 +02:00
GPv3: Interpolate Tool

Reverse mode is now a flag of the sample_uniform function.

Lukas Tönne pushed to gpv3-interpolate-tool at LukasTonne/blender 2024-06-18 15:29:25 +02:00
b8ca841990 Remove unused depsgraph tag.
6d29bcf96a Use the layer(index) accessor instead of layers()[index].
95907afeb1 Sanity check for frame_at return value.
6d05aeae5e Use the existing iterator getter for finding a keyframe interval.
2fb6f59f07 Rename FramesMapKeyIntervalT for consistency with FramesMapKeyT
Compare 7 commits »
Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 14:38:31 +02:00
GPv3: Interpolate Tool

I've added a new API function resample_curve_attribute which is now used both by the resampling and curve interpolation code. It has a mix_weight factor that allows it to be used for plain…

Lukas Tönne deleted branch gpv3-interpolate-tool-shared-code from LukasTonne/blender 2024-06-18 14:33:54 +02:00
Lukas Tönne deleted branch gpv3-interpolate-tool-refactor from LukasTonne/blender 2024-06-18 14:33:45 +02:00
Lukas Tönne pushed to gpv3-interpolate-tool at LukasTonne/blender 2024-06-18 14:33:20 +02:00
ff6c29813e Merge branch 'main' into gpv3-interpolate-tool
966547114f Use the generic curve attribute interpolation function for the interpolation tool as well.
eb731c036b Refactor: Anim filtering, avoid passing bDopesheet *ads parameter
f1fa7e180b Remove outdated comment
d6ed221d6e Remove static type dispatch when interpolating to evaluated, duplicate.
Compare 48 commits »
Lukas Tönne pushed to gpv3-interpolate-tool-shared-code at LukasTonne/blender 2024-06-18 14:31:30 +02:00
966547114f Use the generic curve attribute interpolation function for the interpolation tool as well.
Lukas Tönne pushed to gpv3-interpolate-tool-shared-code at LukasTonne/blender 2024-06-18 12:39:42 +02:00
d6ed221d6e Remove static type dispatch when interpolating to evaluated, duplicate.
Lukas Tönne pushed to gpv3-interpolate-tool-shared-code at LukasTonne/blender 2024-06-18 12:31:00 +02:00
34bbd04b0a New API function for resampling a curve attribute array.