Lukas Tönne LukasTonne
8 Followers · 0 Following
Repositories
7
 Projects Public Activity Starred Repositories
6
Lukas Tönne pushed to gpv3-fix-time-offset-chain-insert at LukasTonne/blender 2024-06-19 10:30:14 +02:00
4f51033708 Nodes: Implement Gabor noise
df78d23f93 Merge branch 'blender-v4.2-release'
6eb2b5f47b Fix local extension errors being shown as remote errors
d70bd00422 Merge branch 'blender-v4.2-release'
86e1ef2e31 Fix: Memory leak in purge orphans with no unused data-blocks
Compare 10 commits »
Lukas Tönne pushed to gpv3-interpolate-tool at LukasTonne/blender 2024-06-19 09:38:44 +02:00
c26f335e6d Updated comment.
Lukas Tönne pushed to gpv3-interpolate-tool at LukasTonne/blender 2024-06-18 18:30:18 +02:00
17ee73c20c Use local lambda to get a const interpolated value.
fa9ff6200e Merge branch 'main' into gpv3-interpolate-tool
6ad04beff8 Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc
3013630137 Refactor: simplify make_new_animlistelem() by returning early
e55af25f38 VSE: Enable "Preview During Transform" by default
Compare 24 commits »
Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 18:29:55 +02:00
GPv3: Interpolate Tool

Yeah the comment isn't quite right. How about

\param use_evaluated_points: Samples are for evaluated points instead of control points.

It means that the sample_indices refer to a data array…

Lukas Tönne pushed to geometry-nodes-rb-component at LukasTonne/blender 2024-06-18 18:12:45 +02:00
a5c3078542 Fix merge errors.
Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 18:00:06 +02:00
GPv3: Interpolate Tool

@blender-bot build

Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 17:59:52 +02:00
GPv3: Interpolate Tool

Looks like scripts/presets/keyconfig/keymap_data/blender_default.py.orig made it into this PR by mistake

Oops, fixed.

Lukas Tönne pushed to gpv3-interpolate-tool at LukasTonne/blender 2024-06-18 17:59:07 +02:00
2dae218042 Delete accidentally staged file.
Lukas Tönne approved blender/blender#123383 2024-06-18 17:57:22 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc
Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 17:29:00 +02:00
GPv3: Interpolate Tool

@blender-bot build

Lukas Tönne pushed to gpv3-interpolate-tool at LukasTonne/blender 2024-06-18 17:28:35 +02:00
036b4e0831 Fix outdated function calls after changing a bool parameter to float.
Lukas Tönne commented on pull request blender/blender#123383 2024-06-18 17:17:59 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

Ah yes, correct. My point is: it doesn't affect resolution of the straight sections, which is what i would expect when reading "subdivisions".

Lukas Tönne suggested changes for blender/blender#123383 2024-06-18 16:43:14 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

Looks good, just have some suggestions for making parameters more intuitive.

Lukas Tönne commented on pull request blender/blender#123383 2024-06-18 16:43:13 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

Comments would be good here (see other comments about changing parameters):

Lukas Tönne commented on pull request blender/blender#123383 2024-06-18 16:43:12 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

Rename subdivisions to cap_subdivisions, since they only affect cap resolution.

Lukas Tönne commented on pull request blender/blender#123383 2024-06-18 16:43:11 +02:00
Cleanup: GPv3: Move create_curves_outline into grease_pencil_geom.cc

I'm not sure if the keep_shape argument makes sense. It just makes it ignore the radius_offset for the actual outline, in that case the radius is only used for the resulting stroke radius. This is confusing, but i just copied what works for GPv2.

Lukas Tönne pushed to geometry-nodes-rb-component-cache at LukasTonne/blender 2024-06-18 15:39:38 +02:00
91f0262610 Merge branch 'geometry-nodes-rb-component' into geometry-nodes-rb-component-cache
1273654646 Merge branch 'main' into geometry-nodes-rb-component
8cd282e48c Merge branch 'blender-v4.2-release'
979e142965 Fix: EEVEE: Object holdout not working
56c1163c21 Fix: Cycles OptiX wrong stack size for OSL pipeline
Compare 35 commits »
Lukas Tönne pushed to geometry-nodes-rb-component at LukasTonne/blender 2024-06-18 15:39:34 +02:00
1273654646 Merge branch 'main' into geometry-nodes-rb-component
8cd282e48c Merge branch 'blender-v4.2-release'
979e142965 Fix: EEVEE: Object holdout not working
56c1163c21 Fix: Cycles OptiX wrong stack size for OSL pipeline
71c716d8c0 Vulkan: Fix incorrect texture update
Compare 34 commits »
Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 15:32:35 +02:00
GPv3: Interpolate Tool

@blender-bot build

Lukas Tönne commented on pull request blender/blender#122155 2024-06-18 15:32:10 +02:00
GPv3: Interpolate Tool

This now uses the shared resample_curve_attribute method, same as the resampling code.