Michael Jones (Apple) Michael-Jones
  • Joined on 2021-10-07
Michael Jones (Apple) created branch mjones/VolumePerfExperiment in Michael-Jones/blender 2024-06-06 17:03:39 +02:00
f5ef41801c Experiment with __VOLUME__ perf
Michael Jones (Apple) commented on pull request blender/blender#122670 2024-06-05 10:27:42 +02:00
WIP: extend "Struct-of-array-of-packed-structs" to all devices

the tricks with offsets is needed only for Apple as other platforms do have un-padded float3, maybe that simplifies things? I've rebased the changes on top of master, not started to implement a…

Michael Jones (Apple) commented on pull request blender/blender#122670 2024-06-04 16:12:07 +02:00
WIP: extend "Struct-of-array-of-packed-structs" to all devices

I mean that we could derive offsets/sizes numerically instead of relying on symbols (e.g. memcpy(current_offset, ...); ... ; current_offset += 1; instead of `memcpy(&integrator_state_gpu_.parent_…

Michael Jones (Apple) commented on pull request blender/blender#122670 2024-06-04 15:00:16 +02:00
WIP: extend "Struct-of-array-of-packed-structs" to all devices

I had a quick pass at making this a runtime check, but the changeset started getting quite big. A couple of approaches I started on:

  1. Define two versions of IntegratorStateGPU, one for the…
Michael Jones (Apple) deleted branch mjones/PackedState from Michael-Jones/blender 2024-06-04 14:53:45 +02:00
Michael Jones (Apple) pushed to main at blender/blender 2024-06-04 14:53:43 +02:00
5be30b7d2b Cycles: "Struct-of-array-of-packed-structs" for parts of the integrator state
Michael Jones (Apple) merged pull request blender/blender#122015 2024-06-04 14:53:42 +02:00
Cycles: "Struct-of-array-of-packed-structs" for parts of the integrator state
Michael Jones (Apple) pushed to mjones/PackedState at Michael-Jones/blender 2024-06-04 14:49:05 +02:00
1ee5010cfd __INTEGRATOR_GPU_PACKED_STATE__ is only enabled on arm64 builds (more explicit #if check)
Michael Jones (Apple) commented on pull request blender/blender#122015 2024-06-04 14:46:48 +02:00
Cycles: "Struct-of-array-of-packed-structs" for parts of the integrator state

I'm fine with this problem being solved in either PR, just needs to be done before oneAPI support can land.

I'd like to solve this as a follow on. I couldn't find a concise way to make it…

1d6a9e9f9f auto str -> const char * const str`
Michael Jones (Apple) commented on pull request blender/blender#122373 2024-05-31 23:55:31 +02:00
Cycles: Enable adaptive compilation on Metal

Out of curiosity I was trying to gain performance improvements, but our performance benchmark did not show anything beyond of regular fluctuations. Attached the result just in case.

Hmm. On…

Michael Jones (Apple) pushed to mjones/PackedState at Michael-Jones/blender 2024-05-31 22:36:30 +02:00
91e28e69bf Address PR feedback
Michael Jones (Apple) commented on pull request blender/blender#122015 2024-05-31 15:45:01 +02:00
Cycles: "Struct-of-array-of-packed-structs" for parts of the integrator state

Wish I could tell you why I added that... 🤔

Michael Jones (Apple) commented on pull request blender/blender#122373 2024-05-31 15:38:20 +02:00
Cycles: Enable adaptive compilation on Metal
  • Changing a scene setting can cause all materials to be recompiled, and compilation times are already an issue.

Compilation times shouldn't be adversely affected. Adaptive compilation is…

Michael Jones (Apple) commented on pull request blender/blender#122015 2024-05-30 18:58:53 +02:00
Cycles: "Struct-of-array-of-packed-structs" for parts of the integrator state

Thanks for taking a look at the CUDA performance, @brecht. It's a shame that it didn't have a positive effect, and I don't exactly know how to explain that.

I've pushed a new revision:

  • Only…
Michael Jones (Apple) pushed to mjones/PackedState at Michael-Jones/blender 2024-05-30 18:32:33 +02:00
c548500d76 make format
87919f1ac8 Autogenerate packed structs (for structs declared using KERNEL_STRUCT_BEGIN_PACKED)
Compare 2 commits »
Michael Jones (Apple) pushed to mjones/PackedState at Michael-Jones/blender 2024-05-30 18:22:33 +02:00
c6bfee8bb1 Autogenerate packed structs (for structs declared using KERNEL_STRUCT_BEGIN_PACKED)
Michael Jones (Apple) created pull request blender/blender#122373 2024-05-28 15:03:34 +02:00
Cycles: Enable adaptive compilation on Metal
650dfdf2b8 Cycles: Enable adaptive compilation on Metal
ceeaea0c8a Fix: Switch to scheduled trigger for appropriate permission scope in workflow
b15bc1b5bb Extensions: add the blender version to the remote URL
171319d9ef Extensions: send access token for HTTP requests
a55c3f503c Cleanup: quiet switch warning
Compare 10 commits »