Mikhail Rachinskiy MikhailRachinskiy
  • Joined on 2010-02-17
Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-03-17 11:36:46 +01:00
3D Print Toolbox: Add hollow out

OK it's ready for merge. There is just one more thing that I wanted to discuss with you.

I noticed there are two reasons hollow gives empty result (object with no mesh):

  1. Offset value is…
Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-03-17 06:07:03 +01:00
3D Print Toolbox: Add hollow out

Enum values are supposed to be in UPPERCASE

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-03-17 06:03:22 +01:00
3D Print Toolbox: Add hollow out

You did not expand enum property so it currently shows as dropdown list.

Add draw method to the operator, right before execute method and manually compose UI:

def draw(self,
Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-03-17 05:33:46 +01:00
3D Print Toolbox: Add hollow out

Adding presets was is just a suggestion,

Mikhail Rachinskiy suggested changes for blender/blender-addons#105194 2024-03-14 08:02:39 +01:00
3D Print Toolbox: Add hollow out

Nice to have you back, meanwhile I got the flu and currently coughing my lungs out, but it's getting better.

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-03-14 08:02:39 +01:00
3D Print Toolbox: Add hollow out

I think that simple checkbox called inside is not user friendly, it is fine with on/off options, but with something more complex it's better to make all available options visible right away (even when there is only two options).

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-03-14 08:02:39 +01:00
3D Print Toolbox: Add hollow out

The scene settings have to go, it's hidden behavior and is really convoluted without clear benefit, and for reusing settings it is better to use presets.

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-03-14 08:02:39 +01:00
3D Print Toolbox: Add hollow out

default=1

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-29 00:22:13 +01:00
3D Print Toolbox: Add hollow out

I'm not suggesting removing the bi-directional offset functionality, just flip the sign, so positive would mean inward and negative outward, similar to solidify modifier.

The only software that I…

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:13 +01:00
3D Print Toolbox: Add hollow out

These comments are redundant, it's obvious why you flip normals, why you move new object to a location of current object, or why you remove mesh (you could name it mesh_temp to emphasize intent).

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:13 +01:00
3D Print Toolbox: Add hollow out

Part of this code should be outside if block, currently selection changes only when hollow duplicate is created. It should change regardless of that, new object is added to the scene - it should be selected and active.

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:13 +01:00
3D Print Toolbox: Add hollow out
  • Operator should be called Hollow, it is short and widely accepted terminology.
Mikhail Rachinskiy suggested changes for blender/blender-addons#105194 2024-02-27 21:37:13 +01:00
3D Print Toolbox: Add hollow out

It's a lot, but after that it all done for the exception of one issue which we'll discuss later after UI part is handled.

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:13 +01:00
3D Print Toolbox: Add hollow out

Double newline only allowed in-between class and function definitions, everything inside function body should be separated by 1 line max.

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:13 +01:00
3D Print Toolbox: Add hollow out

The name of the panel should be changed from Transform to Edit, Hollow tool should be placed first (no additional label needed).

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:12 +01:00
3D Print Toolbox: Add hollow out

If you find matrix stuff confusing, then you could write it as:

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:12 +01:00
3D Print Toolbox: Add hollow out

Again, you don't need to comment on every line, there is a check above if create_hollow and you are using bpy.data.objects.new right after it, the code is self-explanatory.

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:12 +01:00
3D Print Toolbox: Add hollow out

This code block is useless, just do if self.offset > 0.0

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:12 +01:00
3D Print Toolbox: Add hollow out

It's better to avoid negation, if possible, it just makes harder to follow the logic.

Mikhail Rachinskiy commented on pull request blender/blender-addons#105194 2024-02-27 21:37:12 +01:00
3D Print Toolbox: Add hollow out

Offset