It should be something like this:
git checkout mybranch
git merge origin/main
git push
Hi, could you please bring this branch up to date and remove redundant comment? I will merge it right away.
In my testing I found that this: If min value magnitude less then 2 * voxel size was not a reliable way to test.
- Suzanne model unmodified
- Inside offset 0.1
- Voxel size 0.3
I…
OK it's ready for merge. There is just one more thing that I wanted to discuss with you.
I noticed there are two reasons hollow gives empty result (object with no mesh):
- Offset value is…
Enum values are supposed to be in UPPERCASE
You did not expand enum property so it currently shows as dropdown list.
Add draw method to the operator, right before execute method and manually compose UI:
def draw(self,…Adding presets was is just a suggestion,
Nice to have you back, meanwhile I got the flu and currently coughing my lungs out, but it's getting better.
default=1
I think that simple checkbox called inside is not user friendly, it is fine with on/off options, but with something more complex it's better to make all available options visible right away (even when there is only two options).
The scene settings have to go, it's hidden behavior and is really convoluted without clear benefit, and for reusing settings it is better to use presets.
I'm not suggesting removing the bi-directional offset functionality, just flip the sign, so positive would mean inward and negative outward, similar to solidify modifier.
The only software that I…
The name of the panel should be changed from Transform to Edit, Hollow tool should be placed first (no additional label needed).
Double newline only allowed in-between class and function definitions, everything inside function body should be separated by 1 line max.
These comments are redundant, it's obvious why you flip normals, why you move new object to a location of current object, or why you remove mesh (you could name it mesh_temp to emphasize intent).
- Operator should be called
Hollow, it is short and widely accepted terminology.