Pratik Borhade PratikPB2123
23 Followers · 9 Following
  • Kalyan, India
  • Joined on 2020-12-12
Repositories
3
 Projects Public Activity Starred Repositories
1
Pratik Borhade commented on issue blender/blender#130513 2024-11-20 08:02:12 +01:00
Grease Pencil - Pin mode between Material and Vertex Color overrides Pin mode in other tools

Possibly introduced with new brush asset code?

Pratik Borhade commented on issue blender/blender#130571 2024-11-20 07:33:48 +01:00
GPv3: "Boundary -> Edit Lines" setting for fill tool behaves the same as "Strokes"

Fix !130578

Pratik Borhade pushed to 130571-fill-editlines at PratikPB2123/blender 2024-11-20 07:32:00 +01:00
c4ee37c482 Fix format
Pratik Borhade created pull request blender/blender#130578 2024-11-20 07:31:27 +01:00
Fix #130571: Fill to Edit lines is not working
Pratik Borhade created branch 130571-fill-editlines in PratikPB2123/blender 2024-11-20 07:29:56 +01:00
Pratik Borhade pushed to 130571-fill-editlines at PratikPB2123/blender 2024-11-20 07:29:56 +01:00
90ff3545d7 Fix #130571: Fill to Edit lines is not working
73a3ebea56 Fix #129389: Lineart modifier updates when camera changes
2dd0946e97 CMake: Windows: Revert flag change that snuck into previous commit
536937b4d4 CMake: Windows: Fix CMP0177 policy warnings
c57ebc99eb Cleanup: Use StringRef instead of std::string in a few cases
Compare 10 commits »
Pratik Borhade commented on issue blender/blender#130571 2024-11-20 06:31:14 +01:00
GPv3: "Boundary -> Edit Lines" setting for fill tool behaves the same as "Strokes"

I do have a quick fix for this, ignoring thickness attribute calculated from radius when draw_mode=edit_lines. Will check

Pratik Borhade commented on issue blender/blender#130571 2024-11-20 05:59:00 +01:00
GPv3: "Boundary -> Edit Lines" setting for fill tool behaves the same as "Strokes"

AFAICS, eGP_FillDrawModes is not handled in grease_pencil_apply_fill() -> draw_grease_pencil_strokes()

Pratik Borhade commented on issue blender/blender#130559 2024-11-20 05:34:12 +01:00
Armature to Gpencil

Yes, works fine for me as well. Possibly some reproducing step is missing

Pratik Borhade commented on issue blender/blender#130571 2024-11-20 05:17:17 +01:00
GPv3: "Boundary -> Edit Lines" setting for fill tool behaves the same as "Strokes"

Hi, thanks for the report. Can confirm. cc @LukasTonne

Pratik Borhade commented on issue blender/blender#130537 2024-11-20 04:46:59 +01:00
Crash in couple of seconds after opening "2D Animation" template

I believe this is due to "material preview' shading mode and the thumbnail loading of brush assets.

Pratik Borhade closed issue blender/blender#130497 2024-11-20 04:33:49 +01:00
Overlay Next: GPencil selection mode overlay from edit mode visible in sculpt mode
Pratik Borhade commented on issue blender/blender#130497 2024-11-20 04:33:45 +01:00
Overlay Next: GPencil selection mode overlay from edit mode visible in sculpt mode

Ah ok that's good to know! If it's intentional then let's keep it that way. I didn't see the point in it before.

Closing then? :)

Pratik Borhade closed issue blender/blender#130533 2024-11-20 04:28:13 +01:00
GreasePencil : in edit mode, the context menu is absent on segment mode
Pratik Borhade commented on issue blender/blender#130533 2024-11-20 04:28:09 +01:00
GreasePencil : in edit mode, the context menu is absent on segment mode

I'll add 0b18eaf43c9ecf0c786326aa77fb458419034c0a to backporting list :) Sorry for inconvenience. I should have changed the target branch from PR header before Falk merged that.

Pratik Borhade commented on issue blender/blender#130533 2024-11-20 04:26:39 +01:00
GreasePencil : in edit mode, the context menu is absent on segment mode

@Alaska hi, no need for bisecting. It's my commit but mistakenly landed to main directly, I believe 😅

Pratik Borhade commented on pull request blender/blender#130512 2024-11-19 12:39:48 +01:00
GPv3: channel_color property

Should be array of size 3 but I don't know, build was failing when I did that.

Pratik Borhade commented on issue blender/blender#130370 2024-11-19 12:38:29 +01:00
GPv3: Missing Layer channel_color property

Hi, fixed the "random color" issue in 4.3 by removing the function: d7d7a6ef97b80e2eb6408b646f065b8bcb360cdf Re missing property, created a PR for it targeting 4.4: !130512

Pratik Borhade created pull request blender/blender#130512 2024-11-19 12:35:36 +01:00
GPv3: channel_color property
Pratik Borhade created branch gpv3-channelcol-prop in PratikPB2123/blender 2024-11-19 12:34:38 +01:00