Pratik Borhade PratikPB2123
  • Kalyan, India
  • Joined on 2020-12-12
Pratik Borhade created pull request blender/blender#129960 2024-11-07 13:10:46 +01:00
Fix #126076: GPv3 strokes in multiframe edit always use onion skinning colors
Pratik Borhade pushed to 126076-gpv3-onionskin at PratikPB2123/blender 2024-11-07 13:09:14 +01:00
d8f18d419a Fix #126076: GPv3 strokes in multiframe edit always use onion skinning colors
Pratik Borhade created branch 126076-gpv3-onionskin in PratikPB2123/blender 2024-11-07 13:09:14 +01:00
Pratik Borhade pushed to gpv3-showmultiframe-onionskin at PratikPB2123/blender 2024-11-07 12:53:21 +01:00
b6de15c6b5 Revert onion skinning fix
Pratik Borhade commented on pull request blender/blender#129944 2024-11-07 12:26:47 +01:00
Fix: GPv3: "Only In Multiframe" overlay not working

AFAICS grease_pencil_layer_final_tint_and_alpha_get wrongly sets custom onion skinning color to "gpLayerTint" Maybe that's the reason why onion skinning colors are always visible?

Pratik Borhade pushed to gpv3-showmultiframe-onionskin at PratikPB2123/blender 2024-11-07 12:22:53 +01:00
80881ece82 Check do_onion before giving onionskin color
Pratik Borhade commented on pull request blender/blender#129944 2024-11-07 12:01:46 +01:00
Fix: GPv3: "Only In Multiframe" overlay not working

In that case, both "onion skinning toggle" and "only in multiframe" are not really usable, unless there is another way to tackle the issue 😅

Pratik Borhade commented on pull request blender/blender#129944 2024-11-07 11:47:06 +01:00
Fix: GPv3: "Only In Multiframe" overlay not working

I see, would it work if we pass onion_skining (DRW_context_state_get()->v3d->gp_flag) value to retrieve_visible_drawingsingrease_pencil_geom_batch_ensure`? 👀

Pratik Borhade commented on issue blender/blender#129873 2024-11-07 11:38:13 +01:00
GPv3: Some grease pencil overlays do not work

Made PR !129944 This works pretty well but I'm not 100% sure if that's correct way to handle it.

Pratik Borhade created pull request blender/blender#129944 2024-11-07 11:35:41 +01:00
Fix: GPv3: Only in multiframe overlay not working
Pratik Borhade pushed to gpv3-showmultiframe-onionskin at PratikPB2123/blender 2024-11-07 11:34:18 +01:00
8a4b58b0e0 Fix: GPv3: Only in multiframe overlay not working
97e44901b4 Fix #129892: Retiming selection is broken
5e688ffa73 Fix: UI: Missing redraws when clicking on catalogs in asset shelf popup
198688dfbd Fix: UI: Asset shelf clamped to half the width on HiDPI screens
ca1353237f Fix #129797: bpy.data.libraries.write() is no longer saving the asset_data associated with the ID-block.
Compare 10 commits »
Pratik Borhade created branch gpv3-showmultiframe-onionskin in PratikPB2123/blender 2024-11-07 11:34:18 +01:00
Pratik Borhade commented on pull request blender/blender#129933 2024-11-07 11:26:35 +01:00
Fix: Outliner not immediately updated when parent bone property changed

Hi, I think fix is correct (will check locally). Could you add one or two lines of description? Video itself is not enough for landing the PR :)

Pratik Borhade commented on pull request blender/blender#129937 2024-11-07 10:47:48 +01:00
Fix #129907: Grease Pencil brush size gets stuck at 0

Wrong target branch :/ @Sean-Kim @filedescriptor could you cherry pick the commit to 4.3? otherwise I'll do that :)

Pratik Borhade commented on issue blender/blender#129873 2024-11-07 10:34:42 +01:00
GPv3: Some grease pencil overlays do not work

or maybe I'm wrong, it also involves glsl code o_o

Pratik Borhade commented on issue blender/blender#129873 2024-11-07 09:34:55 +01:00
GPv3: Some grease pencil overlays do not work

I can check the "only in multiframe" case. Possibly some mistake in boolean value in gpencil_engine_c.cc

Pratik Borhade commented on issue blender/blender#129873 2024-11-07 07:48:36 +01:00
GPv3: Some grease pencil overlays do not work

but I don't think I understand what "only in multiframe" does

Only edit lines will be visible for non-active drawings when above toggle + multiframe are enabled

Pratik Borhade closed issue blender/blender#128572 2024-11-07 07:19:04 +01:00
4.1.1 Memory Leak (baking cloth physics)
Pratik Borhade commented on issue blender/blender#128572 2024-11-07 07:19:00 +01:00
4.1.1 Memory Leak (baking cloth physics)

No activity for more than a week. As per the tracker policy we assume the issue is gone and can be closed.

Thanks again for the report. If the problem persists please open a new report with the…

Pratik Borhade closed issue blender/blender#128582 2024-11-07 07:18:16 +01:00
when opening shader, blender closes