Nikita Sirgienko Sirgienko
1 Followers · 0 Following
  • Joined on 2020-12-10
Repositories
1
 Projects Public Activity Starred Repositories
Nikita Sirgienko closed issue blender/blender#125093 2024-09-16 16:38:15 +02:00
oneAPI Embree GPU, transparent shadows will render opaque if transparent bounces is modulo 256
Nikita Sirgienko merged pull request blender/blender#127404 2024-09-16 16:38:14 +02:00
Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024
719fea0b0f Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024
d3b655f76d Fix: #127135: Curve and hair drawing asserting on 0 sized VBO
4be5d7f99f Vulkan: Refactor cached compiler instance
a5d7684539 Fix: Small layout jumps of tool settings header in some paint modes
f8ff74f821 GPU: Update stubs of shader builder
Compare 284 commits »
Nikita Sirgienko commented on pull request blender/blender#127404 2024-09-16 16:33:34 +02:00
Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024

> Not sure if you want extra people to test it on actual GPU? @Sergey , not really - the changes are quite straightforward and there is no expectation of functionality changes (well, besides…

Nikita Sirgienko commented on pull request blender/blender#127404 2024-09-16 02:47:09 +02:00
Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024

Adding @Sergey for review. Sergey, could you please take a look?

Nikita Sirgienko commented on pull request blender/blender#127404 2024-09-10 13:57:48 +02:00
Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024

According to my performance testing on different machines with Intel GPUs, I haven't noticed any significant performance difference, just small variations. So, these changes are purely functional…

Nikita Sirgienko commented on pull request blender/blender#127404 2024-09-10 13:51:32 +02:00
Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024

@blender-bot build

Nikita Sirgienko created pull request blender/blender#127404 2024-09-10 13:46:24 +02:00
Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024
Nikita Sirgienko created branch fix_transperent_shadow_embree_bug_125093 in Sirgienko/blender 2024-09-10 13:44:10 +02:00
709269f1c6 Fix #125093: Cycles: oneAPI: transparent shadows opaque when bounces>=1024
4556624edd VSE: Draw thumbnails in timeline by default
957330043f Refactor: Attributes: support different source and destination domains in propagation utilities
168c568058 Fix #126946: GPv3: Handle erase mode when using a tablet pen
59fa82118e Vulkan: Blendfile thumbnail generation
Compare 10 commits »
Nikita Sirgienko commented on pull request blender/blender#125453 2024-09-09 18:16:54 +02:00
Fix #125392: Cycles: Unnecessary recreation of denoiser

I can also confirm that all works as expected and this changes are addressing the reported problem with unnecessary denoiser recreation: Before this Patch:

Time:00:02.08
Nikita Sirgienko commented on pull request blender/blender#125453 2024-09-09 17:35:32 +02:00
Fix #125392: Cycles: Unnecessary recreation of denoiser

Just some thoughts on the overall situation with this part of the code: the entire reason we even have this logic about denoiser_params versus effective_denoiser_params is that we're trying to…

Nikita Sirgienko approved blender/blender#125453 2024-09-09 16:41:13 +02:00
Fix #125392: Cycles: Unnecessary recreation of denoiser

Looks good for me, and thanks @Sergey and @Alaska for the progress with initial review. I haven't compiled the latest version of the patch yet, but I am doing it at the moment just to ensure that it still fixes the reported issue.

Nikita Sirgienko commented on pull request blender/blender#125453 2024-09-05 15:57:53 +02:00
Fix #125392: Cycles: Unnecessary recreation of denoiser

> Not sure if @Sirgienko wants to have a look here before landing. @Alaska @Sergey , Yes, I would like to take a look - I will do it today and tomorrow, so I kindly ask do not land this…

Nikita Sirgienko commented on issue blender/blender#126818 2024-09-05 11:29:31 +02:00
The --cycles-device command line option does nothing

@Anti-Distinctlyminty There is an easy way to check, if something wrong with arguments or something wrong with an enviromental setup: you could try to run this command `blender -b --python-expr…

Nikita Sirgienko commented on pull request blender/blender#127114 2024-09-03 18:40:31 +02:00
Fix #124811: Cycles: oneAPI: no hair strands in viewport with Embree

@blender-bot build

Nikita Sirgienko commented on pull request blender/blender#127114 2024-09-03 18:10:57 +02:00
Fix #124811: Cycles: oneAPI: no hair strands in viewport with Embree

@Sergey, if you will be fine with this changes, then we wound need to backport them to the 4.2 LTS stable branch in order to fix it there as wel.

Nikita Sirgienko created pull request blender/blender#127114 2024-09-03 18:09:36 +02:00
Fix #124811: Cycles: oneAPI: no hair strands in viewport with Embree
7660d244db Fix #124811: Cycles: oneAPI: no hair strands in viewport with Embree
fc7de7c92f Cleanup: Sculpt: Use specific node types for original data access
aaf445830c Fix: Sculpt: Geodesic distances crash after recent cleanup
4f23e4c6b0 Fix: Crash in some cases after disabling dynamic topology
43a96d6b8d Fix: Compile error from missing includes after attribute ID refactor
Compare 10 commits »