Nikita Sirgienko Sirgienko
1 Followers · 0 Following
  • Joined on 2020-12-10
Repositories
1
 Projects Public Activity Starred Repositories
Nikita Sirgienko commented on issue blender/blender#125093 2024-09-03 17:48:08 +02:00
oneAPI Embree GPU, transparent shadows will render opaque if transparent bounces is modulo 256

@Alaska @weizhen I will take a look at this – if I remember correctly, it was an optimization from either Stefan Werner or myself, and Blender was gaining some performance or memory usage…

Nikita Sirgienko commented on issue blender/blender#124811 2024-08-28 12:37:31 +02:00
4.2 oneAPI "Embree on GPU" (HWRT) no hair strands in viewport

I found a root cause of the reported issue - the bug is located in this line 84bab7f300/intern/cycles/kernel/de…

Nikita Sirgienko commented on pull request blender/blender#125453 2024-07-26 12:53:26 +02:00
Fix #125392: Cycles: Unnecessary recreation of denoiser

@Alaska , could you please clarify what is a problem, which you try to solve here and how to reproduce it? I was trying to cause this multiple "Loading Denoising Kernels" message when Denoiser is…

Nikita Sirgienko pushed to main at blender/blender-developer-docs 2024-07-15 17:10:05 +02:00
a47a545041 4.2: Cycles: Fix incorrect line break
Nikita Sirgienko commented on pull request blender/blender#124085 2024-07-03 10:13:00 +02:00
Cycles: oneAPI: Fix undefined behavior when embree fails initializing

@Sergey, can you please take a look on this bug fix?

Nikita Sirgienko created pull request blender/blender#124085 2024-07-03 10:11:50 +02:00
Cycles: oneAPI: Fix unintended fallback to non-Hardware ray-tracing Path
403a2e0753 Cycles: oneAPI: Fix unintended fallback to non-Hardware ray-tracing Path
463c05b341 Extensions: fix missing redraw after setting tags, report adding a repo
e2b24904c9 Extensions: add buttons to select tags
edd1749e22 Fix #124049: object losing user count in geometry nodes modifier
8718aa5513 Fix: EEVEE: Film: Sub-optimal sampling at lower filter size
Compare 10 commits »
Nikita Sirgienko created branch fix_unintended_fallback_for_no_rthw in Sirgienko/blender 2024-07-03 10:07:50 +02:00
Nikita Sirgienko commented on pull request blender/blender#124001 2024-07-01 21:37:48 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

I have tested a build from the build bot, and I can confirm that the reported issue is indeed gone with this changes. Howewer, it looks like denoiser couldn't be actually created from the CUDA…

Nikita Sirgienko commented on pull request blender/blender#124001 2024-07-01 21:03:35 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

@Sergey , so essentially you want to go from `device.type == DEVICE_CUDA

Nikita Sirgienko commented on pull request blender/blender#124001 2024-07-01 18:59:22 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

The only problem I can think of now is that the driver requirements for CUDA is different from OptiX. So a user could have two NVIDIA GPUs, both with Compute Capabiltiy 5.0 or higher, but one is…

Nikita Sirgienko commented on pull request blender/blender#124001 2024-07-01 18:41:08 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

@blender-bot package

Nikita Sirgienko approved blender/blender#124001 2024-07-01 18:40:24 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

Looks good to me, but I think it make sense to test the changes first before merging them.

Nikita Sirgienko suggested changes for blender/blender#124001 2024-07-01 18:31:33 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

Alaska, let's discuss if we want a static check for support, or dynamic one.

Nikita Sirgienko commented on pull request blender/blender#124001 2024-07-01 18:31:32 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

@Alaska , what about more dynamic check? With assumption what Blender is built with Optix 7.3.0, I think we could use such condition - but I haven't tested it yet:

Nikita Sirgienko commented on pull request blender/blender#124001 2024-07-01 18:14:07 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

We could resolve this issue by only allowing OptiX devices to use the OptiX denoiser. But so far Cycles and OptiX seems to have been happy using CUDA or OptiX devices for OptiX denoising, as…

Nikita Sirgienko suggested changes for blender/blender#124001 2024-07-01 17:43:25 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

Thanks Alaska, good catch of this issue! I am overall agreed with a fix, but I think it make sense to restructure its code a bit.

Nikita Sirgienko commented on pull request blender/blender#124001 2024-07-01 17:43:24 +02:00
Cycles: Fix crash using OptiX denoiser with unsupported device selected

@Alaska, could you please move this new check to the new method OIDNDenoiserGPU::is_device_supported(const DeviceInfo &device) in a similar manner to how it's implemented for OIDNDenoiserGPU in the following code below? I believe the most logical approach would be to have the Denoiser subclass determine support capability rather than incorporating direct checks and conditions into the Denoiser::create method.

Nikita Sirgienko approved blender/blender#123593 2024-06-23 21:20:23 +02:00
Cycles: Use denoising device info to pick automatic denoiser

Looks good and correct! Although I haven't actually run it, but I think it should work.

Nikita Sirgienko commented on pull request blender/blender#123530 2024-06-21 19:47:32 +02:00
Fix #123528: Cycles backend denoiser choice did not match UI on NVIDIA

I hit an assertion

intern/cycles/integrator/denoiser_oidn_gpu.cpp Lines 126 to 128 in 685817888e
case DEVICE_CPU:
/* This is the GPU denoiser - CPU devices shouldn't end up here. */
assert(0);

Hi Weizhen, you…