Attila Áfra aafra
  • Joined on 2019-02-12
Attila Áfra commented on issue blender/blender#115045 2024-01-27 14:19:42 +01:00
OpenImageDenoise GPU acceleration

I'm aware of these GPUs, and I tried to look into this a while ago but I couldn't find any mention of checking for tensor core support in the CUDA documentation. I also couldn't find any mention…

Attila Áfra commented on issue blender/blender#115045 2023-12-12 17:08:10 +01:00
OpenImageDenoise GPU acceleration

I managed to implement a minimal CUDART on top of the driver API, and so far it works great. We could replace the proprietary CUDART with this shim starting with the next OIDN release. So this…

Attila Áfra commented on issue blender/blender#115045 2023-11-28 01:44:20 +01:00
OpenImageDenoise GPU acceleration

A minimal open source CUDART shim seems like the most promising alternative to me. There are only a few functions that need to be implemented for OIDN, and this doesn't seem too complicated. I…

Attila Áfra commented on issue blender/blender#115045 2023-11-27 16:38:10 +01:00
OpenImageDenoise GPU acceleration

What's the deadline for enabling HIP, CUDA (if possible) and Metal support (will ship soon in OIDN 2.2) in Blender 4.1? Do these need to be added in Bcon1 or Bcon2 is fine too?

Attila Áfra commented on pull request blender/blender#115242 2023-11-27 14:41:24 +01:00
Compositor: Enable GPU denoising for OpenImageDenoise

Sure! I agree that such a comment should be added.

Attila Áfra commented on issue blender/blender#115045 2023-11-24 21:31:47 +01:00
OpenImageDenoise GPU acceleration

A possibly more precise terminology would be "implicit linking" but it seems there's not a lot of consensus on this. dlopen() is platform-specific.

The bottom line is that it seems we could…

Attila Áfra commented on issue blender/blender#115045 2023-11-24 20:51:44 +01:00
OpenImageDenoise GPU acceleration

So this means that HIP support should be fine since it doesn't require shipping any runtime/non-free dependency?

Attila Áfra commented on issue blender/blender#115045 2023-11-24 20:34:00 +01:00
OpenImageDenoise GPU acceleration

What about the HIP runtime? That is shipped with the AMD drivers. Is it OK to link against that DLL/SO statically?

Does the fact that OIDN loads its CUDA and HIP backends with dlopen() make any…

Attila Áfra commented on issue blender/blender#115045 2023-11-24 20:31:13 +01:00
OpenImageDenoise GPU acceleration

I agree that ideally we should use the driver API but it's not really up to us. CUTLASS uses the runtime, so we would have to fork it and modify it somehow, which could be a lot of extra work.

Attila Áfra commented on pull request blender/blender#115242 2023-11-24 17:25:23 +01:00
Compositor: Enable GPU denoising for OpenImageDenoise

I don't think so. "Host memory" in a GPU compute context often means host pinned memory which is always supported. That's not what this flag indicates. CUDA calls it "system allocated memory",…