Alexander Gavrilov angavrilov
  • Cyprus
  • Joined on 2015-08-20
Alexander Gavrilov commented on pull request blender/blender#116356 2023-12-19 17:28:44 +01:00
Fix: Cycle aware keying inserting first key

There is no such thing as 'bookend keys'. It would be completely detrimental to mandate keys to be placed at any specific point on all channels. The only thing that matters is the distance between…

Alexander Gavrilov commented on pull request blender/blender#104463 2023-12-08 09:31:58 +01:00
Shape Keys: support locking to protect from accidental editing.

Why is this change necessary? In which case do you expect this to return false in the future? Without this info, the return true seems entirely unnecessary.

This question is still…

Alexander Gavrilov commented on pull request blender/blender#115814 2023-12-06 14:35:28 +01:00
WIP: Anim: Add python api to insert keyframes

This seems to miss the point: there are already methods for keyframing a property from the…

Alexander Gavrilov pushed to main at blender/blender-addons 2023-11-21 13:07:03 +01:00
100288bef8 Rigify: allow subclasses of spline_tentacle to lock the Tip Control option.
Alexander Gavrilov commented on pull request blender/blender#104456 2023-11-20 21:29:35 +01:00
WIP: all of my pending patches.

@blender-bot package

Alexander Gavrilov pushed to pending-combined at angavrilov/blender 2023-11-20 21:29:15 +01:00
e7da57ec2b fixup
810c6279db Merge branches 'pr-driver-var-default', 'pr-shapekey-locking', 'pr-shapekey-smoothing' and 'pr-shrinkwrap-tproj' into pending-combined
2ee7bba933 Shrinkwrap: fix stability of the Target Normal Project mode.
92437c113e Shape Keys: support locking to protect from accidental editing.
a6023a8e07 Shape Keys: replace the BKE_keyblock_from_key function with find_index.
Compare 8194 commits »
Alexander Gavrilov deleted branch dev-shapekeys from angavrilov/blender 2023-11-20 21:19:03 +01:00
Alexander Gavrilov deleted branch dev-bbones from angavrilov/blender 2023-11-20 21:18:00 +01:00
Alexander Gavrilov commented on pull request blender/blender#104463 2023-11-20 11:49:46 +01:00
Shape Keys: support locking to protect from accidental editing.

I changed the naming: init -> begin (i.e. named like original, but returns boolean); begin -> begin_post_undo.

Alexander Gavrilov commented on pull request blender/blender#104463 2023-11-20 11:48:07 +01:00
Shape Keys: support locking to protect from accidental editing.

There is no such thing as "nothing happens because of lock checks". Like I said, the whole point of those check functions not being those simple "is..." things you were suggesting is that they…

Alexander Gavrilov commented on pull request blender/blender#104463 2023-11-20 11:45:58 +01:00
Shape Keys: support locking to protect from accidental editing.

I split changes about this function into a separate commit to make them clear, and removed from_key.

Like I said, from_key was weird in that it returned null for index 0 instead of the…

Alexander Gavrilov commented on pull request blender/blender#104463 2023-11-20 11:43:44 +01:00
Shape Keys: support locking to protect from accidental editing.

I was thinking about reducing repetition by allowing to call the function on a null object without explicitly checking, but that's probably going too far, so removed this check.

Alexander Gavrilov pushed to pr-shrinkwrap-tproj at angavrilov/blender 2023-11-20 11:40:51 +01:00
2ee7bba933 Shrinkwrap: fix stability of the Target Normal Project mode.
323259a7da Fix: IO: C++ STL exporter using 'PLY' in error message
a0b9865aa6 Cleanup: Simplify crazyspace loop over mesh corners
4dede4efa8 Fix #115060: Swapped custom data mask in BMesh code
17c793e43c IO: C++ STL exporter
Compare 2494 commits »
Alexander Gavrilov pushed to pr-shapekey-locking at angavrilov/blender 2023-11-20 11:35:51 +01:00
92437c113e Shape Keys: support locking to protect from accidental editing.
a6023a8e07 Shape Keys: replace the BKE_keyblock_from_key function with find_index.
323259a7da Fix: IO: C++ STL exporter using 'PLY' in error message
a0b9865aa6 Cleanup: Simplify crazyspace loop over mesh corners
4dede4efa8 Fix #115060: Swapped custom data mask in BMesh code
Compare 3179 commits »
Alexander Gavrilov pushed to pr-shapekey-smoothing at angavrilov/blender 2023-11-19 22:04:04 +01:00
9a5ad2446d Mesh Edit: implement an operator to smooth shape key deformation.
323259a7da Fix: IO: C++ STL exporter using 'PLY' in error message
a0b9865aa6 Cleanup: Simplify crazyspace loop over mesh corners
4dede4efa8 Fix #115060: Swapped custom data mask in BMesh code
17c793e43c IO: C++ STL exporter
Compare 3662 commits »
Alexander Gavrilov pushed to dev at angavrilov/blender 2023-11-19 21:51:25 +01:00
a72cbbc904 Fix undo overreach in various paint modes for #104582.
97b22be075 Bone Overlay: support bone wireframe opacity depth fade.
323259a7da Fix: IO: C++ STL exporter using 'PLY' in error message
a0b9865aa6 Cleanup: Simplify crazyspace loop over mesh corners
4dede4efa8 Fix #115060: Swapped custom data mask in BMesh code
Compare 4074 commits »
Alexander Gavrilov commented on pull request blender/blender#110135 2023-11-14 17:18:56 +01:00
Drivers: implement fallback values for RNA path based variables.

You can't do this with a switch on enum. However I restructured the contents of the case branches.

Alexander Gavrilov commented on pull request blender/blender#110135 2023-11-14 17:18:14 +01:00
Drivers: implement fallback values for RNA path based variables.
  • Rebased on main to update and introduce the separate refactor commit.
  • Updated comments and messages.
  • Renamed defval to fallback_value - note that this breaks the example file a bit.
Alexander Gavrilov pushed to pr-driver-var-default at angavrilov/blender 2023-11-14 17:16:50 +01:00
208186205e Drivers: implement fallback values for RNA path based variables.
db4d97271f Drivers: refactor driver_get_variable_property to return an enum.
8018b9d7c9 Drivers Editor: apply red underline to drivers that failed evaluation.
1a8b5bcd43 Fix #114841: Sculpt Multires drawing broken with no mask
0bec7f7360 Fix: Vulkan Texel Buffers Texture Format
Compare 518 commits »
Alexander Gavrilov commented on pull request blender/blender#104463 2023-11-02 13:57:15 +01:00
Shape Keys: support locking to protect from accidental editing.

It is NOT a functional change. It encapsulates repeated pairs of apply + free, because now operators also need to check the boolean return code and convert it into an operator status enum value.