archive/attract
0
0
Fork 0
Code Issues 7 Pull Requests Projects Releases Wiki Activity

SVN log messages can be None.

Browse Source
This commit is contained in:
Sybren A. Stüvel
2016-08-31 15:59:45 +02:00
parent 268a40092e
commit 8b618c3ecb
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
attract_server/subversion.py
View File

@@ -40,6 +40,10 @@ class CommitLogObserver(object):
# assumption: revisions are always logged in strictly increasing order. # assumption: revisions are always logged in strictly increasing order.
self.last_seen_revision = log_entry.revision self.last_seen_revision = log_entry.revision
# Log entries can be None.
if not log_entry.msg:
continue
# Parse the commit log to see if there are any task markers. # Parse the commit log to see if there are any task markers.
lines = log_entry.msg.split('\n', 1) lines = log_entry.msg.split('\n', 1)
first_line = lines[0] first_line = lines[0]

2
tests/test_subversion.py
View File

@@ -27,7 +27,7 @@ SVN_LOG_BATCH_1 = [
LogEntry(date=datetime.datetime(2016, 4, 8, 13, 5, 39, 42537, tzinfo=tzutc()), LogEntry(date=datetime.datetime(2016, 4, 8, 13, 5, 39, 42537, tzinfo=tzutc()),
msg='Initial commit of layout files', revision=44, author='hjalti', changelist=None), msg='Initial commit of layout files', revision=44, author='hjalti', changelist=None),
LogEntry(date=datetime.datetime(2016, 4, 8, 13, 6, 18, 947830, tzinfo=tzutc()), LogEntry(date=datetime.datetime(2016, 4, 8, 13, 6, 18, 947830, tzinfo=tzutc()),
msg='Second commit of layout files', revision=45, author='hjalti', changelist=None), msg=None, revision=45, author='andy', changelist=None),
LogEntry(date=datetime.datetime(2016, 4, 8, 14, 22, 24, 411916, tzinfo=tzutc()), LogEntry(date=datetime.datetime(2016, 4, 8, 14, 22, 24, 411916, tzinfo=tzutc()),
msg="Add the eye lattices to the main group\n\nOtherwise when you link the agent group, those two lattices would be\nlinked as regular objects, and you'd need to move both proxy+lattices\nindividually.\n\n\n", msg="Add the eye lattices to the main group\n\nOtherwise when you link the agent group, those two lattices would be\nlinked as regular objects, and you'd need to move both proxy+lattices\nindividually.\n\n\n",
revision=46, author='pablo', changelist=None), revision=46, author='pablo', changelist=None),