archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Cleanup: remove immediate mode TODO

Browse Source 
We've managed without these functions and can add them if needed,
this TODO isn't helping.
This commit is contained in:
Campbell Barton
2019-01-29 08:40:46 +11:00
parent 68cab3aff6
commit 097b1cd08a
1 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
source/blender/gpu/GPU_vertex_buffer.h
View File

@@ -35,11 +35,13 @@
#include "GPU_vertex_format.h" #include "GPU_vertex_format.h"
#define VRAM_USAGE 1 #define VRAM_USAGE 1
/* How to create a GPUVertBuf: */ /**
/* 1) verts = GPU_vertbuf_create() or GPU_vertbuf_init(verts) */ * How to create a #GPUVertBuf:
/* 2) GPU_vertformat_attr_add(verts->format, ...) */ * 1) verts = GPU_vertbuf_create() or GPU_vertbuf_init(verts)
/* 3) GPU_vertbuf_data_alloc(verts, vertex_len) <-- finalizes/packs vertex format */ * 2) GPU_vertformat_attr_add(verts->format, ...)
/* 4) GPU_vertbuf_attr_fill(verts, pos, application_pos_buffer) */ * 3) GPU_vertbuf_data_alloc(verts, vertex_len) <-- finalizes/packs vertex format
* 4) GPU_vertbuf_attr_fill(verts, pos, application_pos_buffer)
*/
/* Is GPUVertBuf always used as part of a GPUBatch? */ /* Is GPUVertBuf always used as part of a GPUBatch? */
@@ -117,17 +119,6 @@ GPU_INLINE uint GPU_vertbuf_raw_used(GPUVertBufRaw *a)
void GPU_vertbuf_attr_get_raw_data(GPUVertBuf *, uint a_idx, GPUVertBufRaw *access); void GPU_vertbuf_attr_get_raw_data(GPUVertBuf *, uint a_idx, GPUVertBufRaw *access);
/* TODO: decide whether to keep the functions below */
/* doesn't immediate mode satisfy these needs? */
/* void setAttrib1f(uint a_idx, uint v_idx, float x); */
/* void setAttrib2f(uint a_idx, unsigned v_idx, float x, float y); */
/* void setAttrib3f(unsigned a_idx, unsigned v_idx, float x, float y, float z); */
/* void setAttrib4f(unsigned a_idx, unsigned v_idx, float x, float y, float z, float w); */
/* void setAttrib3ub(unsigned a_idx, unsigned v_idx, unsigned char r, unsigned char g, unsigned char b); */
/* void setAttrib4ub(unsigned a_idx, unsigned v_idx, unsigned char r, unsigned char g, unsigned char b, unsigned char a); */
void GPU_vertbuf_use(GPUVertBuf *); void GPU_vertbuf_use(GPUVertBuf *);
/* Metrics */ /* Metrics */