archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Fix T60840: Serious memleak in solidify modifier.

Browse Source 
Another one painful to pin down, due to misleading info in report, and
more than anything else, waaayyyyy too complex example file!
This commit is contained in:
Bastien Montagne
2019-01-28 21:46:05 +01:00
parent cad1016c20
commit 147e22ef70
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/modifiers/intern/MOD_solidify.c
View File

@@ -379,7 +379,10 @@ static Mesh *applyModifier(
CustomData_copy_data(&mesh->edata, &result->edata, 0, (int)numEdges, (int)numEdges);
CustomData_copy_data(&mesh->ldata, &result->ldata, 0, 0, (int)numLoops);
CustomData_copy_data(&mesh->ldata, &result->ldata, 0, (int)numLoops, (int)numLoops);
/* DO NOT copy here the 'copied' part of loop data, we want to reverse loops
* (so that winding of copied face get reversed, so that normals get reversed
* and point in expected direction...).
* If we also copy data here, then this data get overwritten (and allocated memory becomes memleak). */
CustomData_copy_data(&mesh->pdata, &result->pdata, 0, 0, (int)numFaces);
CustomData_copy_data(&mesh->pdata, &result->pdata, 0, (int)numFaces, (int)numFaces);