archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

Cleanup: clang-tidy quiet equals-default, nullptr warnings

Browse Source
This commit is contained in:
Campbell Barton
2021-06-23 11:58:41 +10:00
parent 0f427f4eb1
commit 2c916c97ac
2 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/blenlib/tests/BLI_math_time_test.cc
View File

@@ -20,15 +20,15 @@ TEST(math_time, SecondsExplode)
EXPECT_NEAR(9.0, r_seconds, epsilon); EXPECT_NEAR(9.0, r_seconds, epsilon);
EXPECT_NEAR(369.0, r_milliseconds, epsilon); EXPECT_NEAR(369.0, r_milliseconds, epsilon);
BLI_math_time_seconds_decompose(seconds, NULL, &r_hours, &r_minutes, &r_seconds, NULL); BLI_math_time_seconds_decompose(seconds, nullptr, &r_hours, &r_minutes, &r_seconds, nullptr);
EXPECT_NEAR(61.0, r_hours, epsilon); EXPECT_NEAR(61.0, r_hours, epsilon);
EXPECT_NEAR(33.0, r_minutes, epsilon); EXPECT_NEAR(33.0, r_minutes, epsilon);
EXPECT_NEAR(9.369, r_seconds, epsilon); EXPECT_NEAR(9.369, r_seconds, epsilon);
BLI_math_time_seconds_decompose(seconds, NULL, NULL, NULL, &r_seconds, NULL); BLI_math_time_seconds_decompose(seconds, nullptr, nullptr, nullptr, &r_seconds, nullptr);
EXPECT_NEAR(seconds, r_seconds, epsilon); EXPECT_NEAR(seconds, r_seconds, epsilon);
BLI_math_time_seconds_decompose(seconds, &r_days, NULL, &r_minutes, NULL, &r_milliseconds); BLI_math_time_seconds_decompose(seconds, &r_days, nullptr, &r_minutes, nullptr, &r_milliseconds);
EXPECT_NEAR(2.0, r_days, epsilon); EXPECT_NEAR(2.0, r_days, epsilon);
EXPECT_NEAR(813.0, r_minutes, epsilon); EXPECT_NEAR(813.0, r_minutes, epsilon);
EXPECT_NEAR(9369.0, r_milliseconds, epsilon); EXPECT_NEAR(9369.0, r_milliseconds, epsilon);

12
source/blender/blenlib/tests/BLI_string_test.cc
View File

@@ -421,9 +421,7 @@ TEST(string, StrFormatByteUnits)
} }
struct WordInfo { struct WordInfo {
WordInfo() WordInfo() = default;
{
}
WordInfo(int start, int end) : start(start), end(end) WordInfo(int start, int end) : start(start), end(end)
{ {
} }
@@ -441,9 +439,7 @@ static std::ostream &operator<<(std::ostream &os, const WordInfo &word_info)
class StringFindSplitWords : public testing::Test { class StringFindSplitWords : public testing::Test {
protected: protected:
StringFindSplitWords() StringFindSplitWords() = default;
{
}
/* If max_words is -1 it will be initialized from the number of expected /* If max_words is -1 it will be initialized from the number of expected
* words +1. This way there is no need to pass an explicit number of words, * words +1. This way there is no need to pass an explicit number of words,
@@ -807,9 +803,7 @@ TEST_F(StringCasecmpNatural, TextAndNumbers)
class StringEscape : public testing::Test { class StringEscape : public testing::Test {
protected: protected:
StringEscape() StringEscape() = default;
{
}
using CompareWordsArray = vector<std::array<const char *, 2>>; using CompareWordsArray = vector<std::array<const char *, 2>>;