Sculpt: Multithreading & PBVH Changes

* Sculpting, normal update and bounding box code is now multithreaded
  using OpenMP.
* Fix a number of update issues: normals on node boundaries, outdated
  bounding boxes, partial redraw, .. . There's probably still a few
  left, but should be better now.
* Clicking once now does a single paint instead of two (was also
  painting on mouse up event).
* Smooth shading now is enabled for the full mesh when the first face
  uses it (so it can be tested at least).

Implementation Notes:

* PBVH search can now be done either using a callback or bt gathering the
  nodes in an array. The latter makes multithreading with OpenMP easier.
* Normals update code is now inside PBVH, was doing it per node before but
  should do all faces first and only then vertices.
* Instead of using search modes + 1 modified flag, now nodes get 4 flags
  to indicate what needs to be updated for them, found that this makes it
  easier for me to understand the code and fix update bugs.
* PBVHNode is now exposed as an abstract type, I think this makes it more
  clear what is happening than having it's data passed as part of callback
  functions.
* Active_verts list was replaced by looping over nodes and the vertices
  inside them. However the grab brush still uses the active_verts system,
  will fix that later.
* Some micro-optimizations, like avoiding a few multiplications/divisions,
  using local variables instead of pointers, or looping over fewer vertices
  to update the bounding boxes.

source/blender/blenkernel/BKE_mesh.h

@@ -47,6 +47,7 @@ struct Object;
 struct MTFace;
 struct VecNor;
 struct CustomData;
+struct Scene;
 
 #ifdef __cplusplus
 extern "C" {

source/blender/blenkernel/intern/brush.c

@@ -83,7 +83,7 @@ Brush *add_brush(const char *name)
 	brush->clone.alpha= 0.5;
 	brush->sculpt_tool = SCULPT_TOOL_DRAW;
 
-	brush_curve_preset(brush, BRUSH_PRESET_SHARP);
+	brush_curve_preset(brush, BRUSH_PRESET_SMOOTH);
 
 	/* enable fake user by default */
 	brush->id.flag |= LIB_FAKEUSER;

source/blender/blenkernel/intern/cdderivedmesh.c

@@ -177,55 +177,6 @@ static void cdDM_getVertNo(DerivedMesh *dm, int index, float no_r[3])
 	no_r[2] = no[2]/32767.f;
 }
 
-/* Updates all the face and vertex normals in a node
-
-   Note: the correctness of some vertex normals will be a little
-   off, not sure if this will be noticeable or not */
-static void update_node_normals(const int *face_indices,
-				const int *vert_indices,
-				int totface, int totvert, void *data)
-{
-	DerivedMesh *dm = data;
-	CDDerivedMesh *cddm = data;
-	float (*face_nors)[3];
-	int i;
-
-	/* make a face normal layer if not present */
-	face_nors = CustomData_get_layer(&dm->faceData, CD_NORMAL);
-	if(!face_nors)
-		face_nors = CustomData_add_layer(&dm->faceData, CD_NORMAL, CD_CALLOC,
-		                                 NULL, dm->numFaceData);
-
-	/* Update face normals */
-	for(i = 0; i < totface; ++i) {
-		MFace *f = cddm->mface + face_indices[i];
-		float *fn = face_nors[face_indices[i]];
-
-		if(f->v4)
-			CalcNormFloat4(cddm->mvert[f->v1].co, cddm->mvert[f->v2].co,
-			               cddm->mvert[f->v3].co, cddm->mvert[f->v4].co, fn);
-		else
-			CalcNormFloat(cddm->mvert[f->v1].co, cddm->mvert[f->v2].co,
-			              cddm->mvert[f->v3].co, fn);
-	}
-
-	/* Update vertex normals */
-	for(i = 0; i < totvert; ++i) {
-		const int v = vert_indices[i];
-		float no[3] = {0,0,0};
-		IndexNode *face;
-
-		for(face = cddm->fmap[v].first; face; face = face->next)
-			VecAddf(no, no, face_nors[face->index]);
-
-		Normalize(no);
-		
-		cddm->mvert[v].no[0] = no[0] * 32767;
-		cddm->mvert[v].no[1] = no[1] * 32767;
-		cddm->mvert[v].no[2] = no[2] * 32767;
-	}
-}
-
 static ListBase *cdDM_getFaceMap(DerivedMesh *dm)
 {
 	CDDerivedMesh *cddm = (CDDerivedMesh*) dm;
@@ -244,7 +195,7 @@ static struct PBVH *cdDM_getPBVH(DerivedMesh *dm)
 	CDDerivedMesh *cddm = (CDDerivedMesh*) dm;
 
 	if(!cddm->pbvh) {
-		cddm->pbvh = BLI_pbvh_new(update_node_normals, cddm);
+		cddm->pbvh = BLI_pbvh_new();
 		BLI_pbvh_build(cddm->pbvh, cddm->mface, cddm->mvert,
 			       dm->getNumFaces(dm), dm->getNumVerts(dm));
 		printf("rebuild pbvh\n");
@@ -445,9 +396,7 @@ static void cdDM_drawLooseEdges(DerivedMesh *dm)
 static int nodes_drawn = 0;
 static int is_partial = 0;
 /* XXX: Just a temporary replacement for the real drawing code */
-static void draw_partial_cb(const int *face_indices,
+static void draw_partial_cb(PBVHNode *node, void *data)
-			    const int *vert_indices,
-			    int totface, int totvert, void *data_v)
 {
 	/* XXX: Just some quick code to show leaf nodes in different colors */
 	/*float col[3]; int i;
@@ -462,21 +411,16 @@ static void draw_partial_cb(const int *face_indices,
 	glMaterialfv(GL_FRONT_AND_BACK, GL_DIFFUSE, col);
 
 	glColor3f(1, 0, 0);*/
-	GPU_draw_buffers(data_v);
+	GPU_draw_buffers(BLI_pbvh_node_get_draw_buffers(node));
 	++nodes_drawn;
 }
 
-int find_all(float bb_min[3], float bb_max[3], void *data)
-{
-	return 1;
-}
-
 /* Adapted from:
    http://www.gamedev.net/community/forums/topic.asp?topic_id=512123
    Returns true if the AABB is at least partially within the frustum
    (ok, not a real frustum), false otherwise.
 */
-int planes_contain_AABB(float bb_min[3], float bb_max[3], void *data)
+int planes_contain_AABB(PBVHNode *node, float bb_min[3], float bb_max[3], void *data)
 {
 	float (*planes)[4] = data;
 	int i, axis;
@@ -520,21 +464,28 @@ static void cdDM_drawFacesSolid(DerivedMesh *dm,
 }
 
 	if(cddm->pbvh) {
-		BLI_pbvh_search(cddm->pbvh, BLI_pbvh_update_search_cb,
+		float (*face_nors)[3];
-				PBVH_NodeData, NULL, NULL,
+
-				PBVH_SEARCH_UPDATE);
+		/* make a face normal layer if not present */
+		face_nors = CustomData_get_layer(&dm->faceData, CD_NORMAL);
+		if(!face_nors)
+			face_nors = CustomData_add_layer(&dm->faceData, CD_NORMAL, CD_CALLOC,
+											 NULL, dm->numFaceData);
+
+		BLI_pbvh_update(cddm->pbvh, PBVH_UpdateNormals|PBVH_UpdateDrawBuffers,
+			face_nors, cdDM_getFaceMap(dm));
+
+		/* should be per face */
+		if(dm->numFaceData && mface->flag & ME_SMOOTH)
+			glShadeModel(GL_SMOOTH);
 
 		if(partial_redraw_planes) {
-			BLI_pbvh_search(cddm->pbvh, planes_contain_AABB,
+			BLI_pbvh_search_callback(cddm->pbvh, planes_contain_AABB,
-					partial_redraw_planes,
+					partial_redraw_planes, draw_partial_cb, NULL);
-					draw_partial_cb, PBVH_DrawData,
-					PBVH_SEARCH_MODIFIED);
 		}
 		else {
-			BLI_pbvh_search(cddm->pbvh, find_all, NULL,
+			BLI_pbvh_search_callback(cddm->pbvh, NULL, NULL,
-					draw_partial_cb, PBVH_DrawData,
+					draw_partial_cb, NULL);
-					PBVH_SEARCH_NORMAL);
-
 		}
 
 		is_partial = !!partial_redraw_planes;
@@ -542,6 +493,8 @@ static void cdDM_drawFacesSolid(DerivedMesh *dm,
 		//printf("nodes drawn=%d\n", nodes_drawn);
 		nodes_drawn = 0;
 
+		glShadeModel(GL_FLAT);
+
 		return;
 	}
 

source/blender/blenlib/BLI_pbvh.h

@@ -1,62 +1,98 @@
+/**
+ * A BVH for high poly meshes.
+ * 
+ * $Id$
+ *
+ * ***** BEGIN GPL LICENSE BLOCK *****
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ *
+ * ***** END GPL LICENSE BLOCK *****
+ */
+
+#ifndef BLI_PBVH_H
+#define BLI_PBVH_H
+
 struct MFace;
 struct MVert;
 struct PBVH;
+struct PBVHNode;
+struct ListBase;
 
-/* Returns 1 if the search should continue from this node, 0 otherwise */
+typedef struct PBVH PBVH;
-typedef int (*BLI_pbvh_SearchCallback)(float bb_min[3], float bb_max[3],
+typedef struct PBVHNode PBVHNode;
-				       void *data);
 
-typedef void (*BLI_pbvh_HitCallback)(const int *face_indices,
+/* Callbacks */
-				     const int *vert_indices,
-				     int totface, int totvert, void *data);
-int BLI_pbvh_search_range(float bb_min[3], float bb_max[3], void *data_v);
 
-typedef enum {
+/* returns 1 if the search should continue from this node, 0 otherwise */
-	PBVH_SEARCH_NORMAL,
+typedef int (*BLI_pbvh_SearchCallback)(PBVHNode *node,
+	float bb_min[3], float bb_max[3], void *data);
 
-	/* When the callback returns a 1 for a leaf node, that node will be
+typedef void (*BLI_pbvh_HitCallback)(PBVHNode *node, void *data);
-	   marked as modified */
-	PBVH_SEARCH_MARK_MODIFIED,
-	
-	/* Update gpu data for modified nodes. Also clears the Modified flag. */
-	PBVH_SEARCH_MODIFIED,
 
-	
+/* Building */
-	PBVH_SEARCH_UPDATE
-} PBVH_SearchMode;
 
-/* Pass the node as data to the callback */
+PBVH *BLI_pbvh_new(void);
-#define PBVH_NodeData (void*)0xa
+void BLI_pbvh_build(PBVH *bvh, struct MFace *faces, struct MVert *verts,
-/* Pass the draw buffers as data to the callback */
+		    int totface, int totvert);
-#define PBVH_DrawData (void*)0xb
+void BLI_pbvh_free(PBVH *bvh);
 
-void BLI_pbvh_search(struct PBVH *bvh, BLI_pbvh_SearchCallback scb,
+void BLI_pbvh_set_source(PBVH *bvh, struct MVert *, struct MFace *mface);
-		     void *search_data, BLI_pbvh_HitCallback hcb,
-		     void *hit_data, PBVH_SearchMode mode);
 
-/* The hit callback is called for all leaf nodes intersecting the ray;
+/* Hierarchical Search in the BVH, two methods:
+   * for each hit calling a callback
+   * gather nodes in an array (easy to multithread) */
+
+void BLI_pbvh_search_callback(PBVH *bvh,
+	BLI_pbvh_SearchCallback scb, void *search_data,
+	BLI_pbvh_HitCallback hcb, void *hit_data);
+
+void BLI_pbvh_search_gather(PBVH *bvh,
+	BLI_pbvh_SearchCallback scb, void *search_data,
+	PBVHNode ***array, int *tot);
+
+/* Raycast
+   the hit callback is called for all leaf nodes intersecting the ray;
    it's up to the callback to find the primitive within the leaves that is
    hit first */
-void BLI_pbvh_raycast(struct PBVH *bvh, BLI_pbvh_HitCallback cb, void *data,
+
+void BLI_pbvh_raycast(PBVH *bvh, BLI_pbvh_HitCallback cb, void *data,
 		      float ray_start[3], float ray_normal[3]);
 
+/* Node Access */
 
-int BLI_pbvh_update_search_cb(float bb_min[3], float bb_max[3], void *data_v);
+typedef enum {
+	PBVH_Leaf = 1,
 
-/* Get the bounding box around all nodes that have been marked as modified. */
+	PBVH_UpdateNormals = 2,
-void BLI_pbvh_modified_bounding_box(struct PBVH *bvh,
+	PBVH_UpdateBB = 4,
-				    float bb_min[3], float bb_max[3]);
+	PBVH_UpdateDrawBuffers = 8,
-void BLI_pbvh_reset_modified_bounding_box(struct PBVH *bvh);
+	PBVH_UpdateRedraw = 16
+} PBVHNodeFlags;
 
-/* Lock is off by default, turn on to stop redraw from clearing the modified
+void BLI_pbvh_node_mark_update(PBVHNode *node);
-   flag from nodes */
-void BLI_pbvh_toggle_modified_lock(struct PBVH *bvh);
 
+void BLI_pbvh_node_get_verts(PBVHNode *node, int **vert_indices, int *totvert);
+void BLI_pbvh_node_get_faces(PBVHNode *node, int **face_indices, int *totface);
+void *BLI_pbvh_node_get_draw_buffers(PBVHNode *node);
 
+/* Update Normals/Bounding Box/Draw Buffers/Redraw and clear flags */
 
-struct PBVH *BLI_pbvh_new(BLI_pbvh_HitCallback update_cb, void *update_cb_data);
+void BLI_pbvh_update(PBVH *bvh, int flags,
-void BLI_pbvh_build(struct PBVH *bvh, struct MFace *faces, struct MVert *verts,
+	float (*face_nors)[3], struct ListBase *fmap);
-		    int totface, int totvert);
+void BLI_pbvh_redraw_bounding_box(PBVH *bvh, float bb_min[3], float bb_max[3]);
-void BLI_pbvh_free(struct PBVH *bvh);
+
+#endif /* BLI_PBVH_H */
 
-void BLI_pbvh_set_source(struct PBVH *bvh, struct MVert *, struct MFace *mface);

source/blender/blenlib/intern/arithb.c

@@ -114,16 +114,17 @@ float sasqrtf(float fac)
 
 float Normalize(float *n)
 {
-	float d;
+	float d, invd;
 	
 	d= n[0]*n[0]+n[1]*n[1]+n[2]*n[2];
 	/* A larger value causes normalize errors in a scaled down models with camera xtreme close */
 	if(d>1.0e-35f) {
 		d= (float)sqrt(d);
+		invd= 1.0f/d;
 
-		n[0]/=d; 
+		n[0]*=invd; 
-		n[1]/=d; 
+		n[1]*=invd; 
-		n[2]/=d;
+		n[2]*=invd;
 	} else {
 		n[0]=n[1]=n[2]= 0.0f;
 		d= 0.0f;

source/blender/blenlib/intern/pbvh.c

@@ -1,3 +1,29 @@
+/**
+ * $Id$
+ *
+ * ***** BEGIN GPL LICENSE BLOCK *****
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+ *
+ * ***** END GPL LICENSE BLOCK *****
+ */
+
+#include <float.h>
+#include <stdlib.h>
+#include <string.h>
+
 #include "MEM_guardedalloc.h"
 
 #include "DNA_meshdata_types.h"
@@ -6,14 +32,11 @@
 #include "BLI_ghash.h"
 #include "BLI_pbvh.h"
 
+#include "BKE_mesh.h"
 #include "BKE_utildefines.h"
 
 #include "gpu_buffers.h"
 
-#include <float.h>
-#include <stdlib.h>
-#include <string.h>
-
 #define LEAF_LIMIT 10000
 
 //#define PERFCNTRS
@@ -41,11 +64,6 @@ void BLI_bitmap_clear(BLI_bitmap b, int index)
 	b[index >> 3] &= ~(1 << (index & 7));
 }
 
-typedef enum {
-	PBVH_Leaf = 1,
-	PBVH_Modified = 2
-} NodeFlags;
-
 /* Axis-aligned bounding box */
 typedef struct {
 	float bmin[3], bmax[3];
@@ -56,7 +74,7 @@ typedef struct {
 	float bmin[3], bmax[3], bcentroid[3];
 } BBC;
 
-typedef struct {
+struct PBVHNode {
 	/* Opaque handle for drawing code */
 	void *draw_buffers;
 
@@ -68,33 +86,26 @@ typedef struct {
 	/* For internal nodes */
 	int children_offset;
 
-	/* Range of faces used in the node */
+	/* Pointer into bvh face_indices */
-	int face_offset;
+	int *face_indices;
 
 	unsigned short totface;
 	unsigned short uniq_verts, face_verts;
 
 	char flag;
-} Node;
+};
 
-typedef struct PBVH {
+struct PBVH {
-	Node *nodes;
+	PBVHNode *nodes;
 	int node_mem_count, totnode;
 
 	int *face_indices;
 	int totface;
 
-	BB modified_bb;
-
-	BLI_pbvh_HitCallback update_cb;
-	void *update_cb_data;
-
 	/* Mesh data */
 	MVert *verts;
 	MFace *faces;
 
-	int modified_lock;
-
 	/* Only used during BVH build and update,
 	   don't need to remain valid after */
 	BLI_bitmap vert_bitmap;
@@ -102,7 +113,26 @@ typedef struct PBVH {
 #ifdef PERFCNTRS
 	int perf_modified;
 #endif
-} PBVH;
+};
+
+#define STACK_FIXED_DEPTH	100
+
+typedef struct PBVHStack {
+	PBVHNode *node;
+	int revisiting;
+} PBVHStack;
+
+typedef struct PBVHIter {
+	PBVH *bvh;
+	BLI_pbvh_SearchCallback scb;
+	void *search_data;
+
+	PBVHStack *stack;
+	int stacksize;
+
+	PBVHStack stackfixed[STACK_FIXED_DEPTH];
+	int stackspace;
+} PBVHIter;
 
 static void BB_reset(BB *bb)
 {
@@ -113,13 +143,11 @@ static void BB_reset(BB *bb)
 /* Expand the bounding box to include a new coordinate */
 static void BB_expand(BB *bb, float co[3])
 {
-	if(co[0] < bb->bmin[0]) bb->bmin[0] = co[0];
+	int i;
-	if(co[1] < bb->bmin[1]) bb->bmin[1] = co[1];
+	for(i = 0; i < 3; ++i) {
-	if(co[2] < bb->bmin[2]) bb->bmin[2] = co[2];
+		bb->bmin[i] = MIN2(bb->bmin[i], co[i]);
-
+		bb->bmax[i] = MAX2(bb->bmax[i], co[i]);
-	if(co[0] > bb->bmax[0]) bb->bmax[0] = co[0];
+	}
-	if(co[1] > bb->bmax[1]) bb->bmax[1] = co[1];
-	if(co[2] > bb->bmax[2]) bb->bmax[2] = co[2];
 }
 
 /* Expand the bounding box to include another bounding box */
@@ -163,28 +191,28 @@ static void BBC_update_centroid(BBC *bbc)
 }
 
 /* Not recursive */
-static void update_node_vb(PBVH *bvh, Node *node)
+static void update_node_vb(PBVH *bvh, PBVHNode *node)
 {
-	BB_reset(&node->vb);
+	BB vb;
+
+	BB_reset(&vb);
 	
 	if(node->flag & PBVH_Leaf) {
-		int i, j;
+		int i, totvert= node->uniq_verts + node->face_verts;
-		for(i = node->face_offset + node->totface - 1;
-		    i >= node->face_offset; --i) {
-			MFace *f = bvh->faces + bvh->face_indices[i];
-			const int sides = f->v4 ? 4 : 3;
 
-			for(j = 0; j < sides; ++j)
+		for(i = 0; i < totvert; ++i) {
-				BB_expand(&node->vb,
+			float *co= bvh->verts[node->vert_indices[i]].co;
-					  bvh->verts[*((&f->v1) + j)].co);
+			BB_expand(&vb, co);
 		}
 	}
 	else {
-		BB_expand_with_bb(&node->vb,
+		BB_expand_with_bb(&vb,
 				  &bvh->nodes[node->children_offset].vb);
-		BB_expand_with_bb(&node->vb,
+		BB_expand_with_bb(&vb,
 				  &bvh->nodes[node->children_offset + 1].vb);
 	}
+
+	node->vb= vb;
 }
 
 /* Adapted from BLI_kdopbvh.c */
@@ -222,13 +250,13 @@ void check_partitioning(int *face_indices, int lo, int hi, int axis,
 static void grow_nodes(PBVH *bvh, int totnode)
 {
 	if(totnode > bvh->node_mem_count) {
-		Node *prev = bvh->nodes;
+		PBVHNode *prev = bvh->nodes;
 		bvh->node_mem_count *= 1.33;
 		if(bvh->node_mem_count < totnode)
 			bvh->node_mem_count = totnode;
-		bvh->nodes = MEM_callocN(sizeof(Node) * bvh->node_mem_count,
+		bvh->nodes = MEM_callocN(sizeof(PBVHNode) * bvh->node_mem_count,
 					 "bvh nodes");
-		memcpy(bvh->nodes, prev, bvh->totnode * sizeof(Node));
+		memcpy(bvh->nodes, prev, bvh->totnode * sizeof(PBVHNode));
 		MEM_freeN(prev);
 	}
 
@@ -259,19 +287,19 @@ static void map_insert_vert(PBVH *bvh, GHash *map,
 }
 
 /* Find vertices used by the faces in this node and update the draw buffers */
-static void build_leaf_node(PBVH *bvh, Node *node)
+static void build_leaf_node(PBVH *bvh, PBVHNode *node)
 {
 	GHashIterator *iter;
 	GHash *map;
-	int i, j;
+	int i, j, totface;
 
 	map = BLI_ghash_new(BLI_ghashutil_inthash, BLI_ghashutil_intcmp);
 	
 	node->uniq_verts = node->face_verts = 0;
+	totface= node->totface;
 
-	for(i = node->face_offset + node->totface - 1;
+	for(i = 0; i < totface; ++i) {
-	    i >= node->face_offset; --i) {
+		MFace *f = bvh->faces + node->face_indices[i];
-		MFace *f = bvh->faces + bvh->face_indices[i];
 		int sides = f->v4 ? 4 : 3;
 
 		for(j = 0; j < sides; ++j) {
@@ -300,7 +328,7 @@ static void build_leaf_node(PBVH *bvh, Node *node)
 
 	node->draw_buffers =
 		GPU_build_buffers(map, bvh->verts, bvh->faces,
-				  bvh->face_indices + node->face_offset,
+				  node->face_indices,
 				  node->totface, node->vert_indices,
 				  node->uniq_verts,
 				  node->uniq_verts + node->face_verts);
@@ -329,7 +357,7 @@ void build_sub(PBVH *bvh, int node_index, BB *cb, BBC *prim_bbc,
 	if(count <= LEAF_LIMIT) {
 		bvh->nodes[node_index].flag |= PBVH_Leaf;
 
-		bvh->nodes[node_index].face_offset = offset;
+		bvh->nodes[node_index].face_indices = bvh->face_indices + offset;
 		bvh->nodes[node_index].totface = count;
 
 		/* Still need vb for searches */
@@ -398,7 +426,7 @@ void BLI_pbvh_build(PBVH *bvh, MFace *faces, MVert *verts, int totface, int totv
 		bvh->totnode = 0;
 		if(bvh->node_mem_count < 100) {
 			bvh->node_mem_count = 100;
-			bvh->nodes = MEM_callocN(sizeof(Node) *
+			bvh->nodes = MEM_callocN(sizeof(PBVHNode) *
 						 bvh->node_mem_count,
 						 "bvh initial nodes");
 		}
@@ -408,8 +436,6 @@ void BLI_pbvh_build(PBVH *bvh, MFace *faces, MVert *verts, int totface, int totv
 	bvh->verts = verts;
 	bvh->vert_bitmap = BLI_bitmap_new(totvert);
 
-	BB_reset(&bvh->modified_bb);
-
 	BB_reset(&cb);
 
 	/* For each face, store the AABB and the AABB centroid */
@@ -437,12 +463,9 @@ void BLI_pbvh_build(PBVH *bvh, MFace *faces, MVert *verts, int totface, int totv
 	MEM_freeN(bvh->vert_bitmap);
 }
 
-PBVH *BLI_pbvh_new(BLI_pbvh_HitCallback update_cb, void *update_cb_data)
+PBVH *BLI_pbvh_new(void)
 {
 	PBVH *bvh = MEM_callocN(sizeof(PBVH), "pbvh");
-	
-	bvh->update_cb = update_cb;
-	bvh->update_cb_data = update_cb_data;
 
 	return bvh;
 }
@@ -469,113 +492,339 @@ void BLI_pbvh_set_source(PBVH *bvh, MVert *mvert, MFace *mface)
 	bvh->faces = mface;
 }
 
-static void do_hit_callback(PBVH *bvh, Node *node,
+static void do_hit_callback(PBVH *bvh, PBVHNode *node,
 			    BLI_pbvh_HitCallback cb, void *data)
 {
-	if(cb) {
+	if(cb)
-		cb(bvh->face_indices + node->face_offset, node->vert_indices,
+		cb(node, data);
-		   node->totface, node->uniq_verts, data);
-	}
 }
 
-static int search_sub(PBVH *bvh, Node *node,
+static void pbvh_iter_begin(PBVHIter *iter, PBVH *bvh, BLI_pbvh_SearchCallback scb, void *search_data)
-		      BLI_pbvh_SearchCallback scb, void *search_data_f,
-		      BLI_pbvh_HitCallback hcb, void *hit_data_f,
-		      PBVH_SearchMode mode)
 {
-	void *search_data = search_data_f;
+	iter->bvh= bvh;
-	void *hit_data = hit_data_f;
+	iter->scb= scb;
+	iter->search_data= search_data;
 
-	if(search_data_f == PBVH_NodeData)
+	iter->stack= iter->stackfixed;
-		search_data = &node->flag;
+	iter->stackspace= STACK_FIXED_DEPTH;
-	if(hit_data_f == PBVH_DrawData)
+
-		hit_data = node->draw_buffers;
+	iter->stack[0].node= bvh->nodes;
+	iter->stack[0].revisiting= 0;
+	iter->stacksize= 1;
+}
+
+static void pbvh_iter_end(PBVHIter *iter)
+{
+	if(iter->stackspace > STACK_FIXED_DEPTH)
+		MEM_freeN(iter->stack);
+}
+
+static void pbvh_stack_push(PBVHIter *iter, PBVHNode *node, int revisiting)
+{
+	if(iter->stacksize == iter->stackspace) {
+		PBVHStack *newstack;
+
+		iter->stackspace *= 2;
+		newstack= MEM_callocN(sizeof(PBVHStack)*iter->stackspace, "PBVHStack");
+		memcpy(newstack, iter->stack, sizeof(PBVHStack)*iter->stacksize);
+
+		if(iter->stackspace > STACK_FIXED_DEPTH)
+			MEM_freeN(iter->stack);
+		iter->stack= newstack;
+	}
+
+	iter->stack[iter->stacksize].node= node;
+	iter->stack[iter->stacksize].revisiting= revisiting;
+	iter->stacksize++;
+}
+
+static PBVHNode *pbvh_iter_next(PBVHIter *iter)
+{
+	PBVHNode *node;
+	int revisiting;
+	void *search_data;
+
+	/* purpose here is to traverse tree, visiting child nodes before their
+	   parents, this order is necessary for e.g. computing bounding boxes */
+
+	while(iter->stacksize) {
+		/* pop node */
+		iter->stacksize--;
+		node= iter->stack[iter->stacksize].node;
+		revisiting= iter->stack[iter->stacksize].revisiting;
+
+		/* revisiting node already checked */
+		if(revisiting)
+			return node;
+
+		/* check search callback */
+		search_data= iter->search_data;
+
+		if(iter->scb && !iter->scb(node, node->vb.bmin, node->vb.bmax, search_data))
+			continue; /* don't traverse, outside of search zone */
 
-	if(scb(node->vb.bmin, node->vb.bmax, search_data)) {
 		if(node->flag & PBVH_Leaf) {
-			switch(mode) {
+			/* immediately hit leaf node */
-			case PBVH_SEARCH_MARK_MODIFIED:
+			return node;
-				node->flag |= PBVH_Modified;
-#ifdef PERFCNTRS
-				++bvh->perf_modified;
-#endif
-				break;
-			case PBVH_SEARCH_MODIFIED:
-				if(node->flag & PBVH_Modified) {
-					if(bvh->update_cb) {
-						do_hit_callback
-							(bvh, node,
-							 bvh->update_cb,
-							 bvh->update_cb_data);
-					}
-
-					GPU_update_buffers(node->draw_buffers,
-							   bvh->verts,
-							   node->vert_indices,
-							   node->uniq_verts +
-							   node->face_verts);
-				}
-			default:
-				break;
-			}
-
-			do_hit_callback(bvh, node, hcb, hit_data);
 		}
 		else {
-			int mod = 0;
+			/* come back later when children are done */
-			if(search_sub(bvh, bvh->nodes + node->children_offset,
+			pbvh_stack_push(iter, node, 1);
-				      scb, search_data_f, hcb,hit_data_f, mode))
-				mod = 1;
-			if(search_sub(bvh,
-				      bvh->nodes + node->children_offset + 1,
-				      scb, search_data_f, hcb,hit_data_f, mode))
-				mod = 1;
 
-			if(mod)
+			/* push two child nodes on the stack */
-				node->flag |= PBVH_Modified;
+			pbvh_stack_push(iter, iter->bvh->nodes+node->children_offset+1, 0);
+			pbvh_stack_push(iter, iter->bvh->nodes+node->children_offset, 0);
 		}
 	}
 
-	if(mode == PBVH_SEARCH_MODIFIED) {
+	return NULL;
-#ifdef PERFCNTRS
-		if(node->flag & PBVH_Modified && node->flag & PBVH_Leaf)
-			--bvh->perf_modified;
-#endif
-		if(!bvh->modified_lock)
-			node->flag &= ~PBVH_Modified;
-	}
-	else if(mode == PBVH_SEARCH_UPDATE) {
-		if(node->flag & PBVH_Modified) {
-			update_node_vb(bvh, node);
-			if(node->flag & PBVH_Leaf)
-				BB_expand_with_bb(&bvh->modified_bb, &node->vb);
-		}
-	}
-
-	return node->flag & PBVH_Modified;
 }
 
-void BLI_pbvh_search(PBVH *bvh, BLI_pbvh_SearchCallback scb, void *search_data,
+void BLI_pbvh_search_gather(PBVH *bvh,
-		     BLI_pbvh_HitCallback hcb, void *hit_data,
+	BLI_pbvh_SearchCallback scb, void *search_data,
-		     PBVH_SearchMode mode)
+	PBVHNode ***r_array, int *r_tot)
 {
-#ifdef PERFCNTRS
+	PBVHIter iter;
-	printf("search mode=%s\n",
+	PBVHNode **array= NULL, **newarray, *node;
-	       mode==PBVH_SEARCH_MARK_MODIFIED?"mark-modified":
+	int tot= 0, space= 0;
-	       mode==PBVH_SEARCH_MODIFIED?"modified":
-	       mode==PBVH_SEARCH_UPDATE?"update":
-	       mode==PBVH_SEARCH_NORMAL?"normal":"unknown-mode");
-	if(mode == PBVH_SEARCH_MARK_MODIFIED)
-		bvh->perf_modified = 0;
-#endif
 
-	search_sub(bvh, bvh->nodes, scb, search_data, hcb, hit_data, mode);
+	pbvh_iter_begin(&iter, bvh, scb, search_data);
-#ifdef PERFCNTRS
+
-	printf("%d nodes marked modified\n", bvh->perf_modified);
+	while((node=pbvh_iter_next(&iter))) {
-	printf("search complete\n\n");
+		if(node->flag & PBVH_Leaf) {
-#endif
+			if(tot == space) {
+				/* resize array if needed */
+				space= (tot == 0)? 32: space*2;
+				newarray= MEM_callocN(sizeof(PBVHNode)*space, "PBVHNodeSearch");
+
+				if(array) {
+					memcpy(newarray, array, sizeof(PBVHNode)*tot);
+					MEM_freeN(array);
+				}
+
+				array= newarray;
+			}
+
+			array[tot]= node;
+			tot++;
+		}
+	}
+
+	pbvh_iter_end(&iter);
+
+	*r_array= array;
+	*r_tot= tot;
 }
 
+void BLI_pbvh_search_callback(PBVH *bvh,
+	BLI_pbvh_SearchCallback scb, void *search_data,
+	BLI_pbvh_HitCallback hcb, void *hit_data)
+{
+	PBVHIter iter;
+	PBVHNode *node;
+
+	pbvh_iter_begin(&iter, bvh, scb, search_data);
+
+	while((node=pbvh_iter_next(&iter)))
+		if(node->flag & PBVH_Leaf)
+			do_hit_callback(bvh, node, hcb, hit_data);
+
+	pbvh_iter_end(&iter);
+}
+
+static int update_search_cb(PBVHNode *node,
+	float bb_min[3], float bb_max[3], void *data_v)
+{
+	if(node->flag & PBVH_Leaf)
+		return (node->flag & (PBVH_UpdateNormals|PBVH_UpdateBB|PBVH_UpdateDrawBuffers|PBVH_UpdateRedraw));
+	
+	return 1;
+}
+
+static void pbvh_update_face_normals(PBVH *bvh, PBVHNode **nodes,
+	int totnode, float (*face_nors)[3])
+{
+	PBVHNode *node;
+	int n;
+
+	#pragma omp parallel for private(n) schedule(static)
+	for(n = 0; n < totnode; n++) {
+		node= nodes[n];
+
+		if((node->flag & PBVH_UpdateNormals)) {
+			int i, totface, *faces;
+
+			BLI_pbvh_node_get_faces(node, &faces, &totface);
+
+			for(i = 0; i < totface; ++i) {
+				MFace *f = bvh->faces + faces[i];
+				float *fn = face_nors[faces[i]];
+
+				if(f->v4)
+					CalcNormFloat4(bvh->verts[f->v1].co, bvh->verts[f->v2].co,
+								   bvh->verts[f->v3].co, bvh->verts[f->v4].co, fn);
+				else
+					CalcNormFloat(bvh->verts[f->v1].co, bvh->verts[f->v2].co,
+								  bvh->verts[f->v3].co, fn);
+			}
+		}
+	}
+}
+
+static void pbvh_update_BB_normals(PBVH *bvh, PBVHNode **nodes,
+	int totnode, int flag, float (*face_nors)[3], ListBase *fmap)
+{
+	PBVHNode *node;
+	int n;
+
+	/* update BB, vertex normals, redraw flag */
+	#pragma omp parallel for private(n) schedule(static)
+	for(n = 0; n < totnode; n++) {
+		node= nodes[n];
+
+		if((flag & PBVH_UpdateBB) && (node->flag & PBVH_UpdateBB)) {
+			update_node_vb(bvh, node);
+			/* don't clear flag yet, leave it for flushing later */
+		}
+
+		if((flag & PBVH_UpdateNormals) && (node->flag & PBVH_UpdateNormals)) {
+			int i, *verts, totvert;
+
+			BLI_pbvh_node_get_verts(node, &verts, &totvert);
+
+			for(i = 0; i < totvert; ++i) {
+				const int v = verts[i];
+				float no[3] = {0,0,0};
+				IndexNode *face;
+
+				for(face = fmap[v].first; face; face = face->next)
+					VecAddf(no, no, face_nors[face->index]);
+
+				Normalize(no);
+				
+				bvh->verts[v].no[0] = no[0] * 32767;
+				bvh->verts[v].no[1] = no[1] * 32767;
+				bvh->verts[v].no[2] = no[2] * 32767;
+			}
+
+			node->flag &= ~PBVH_UpdateNormals;
+		}
+
+		if((flag & PBVH_UpdateRedraw) && (node->flag & PBVH_UpdateRedraw))
+			node->flag &= ~PBVH_UpdateRedraw;
+	}
+}
+
+static void pbvh_update_draw_buffers(PBVH *bvh, PBVHNode **nodes, int totnode)
+{
+	PBVHNode *node;
+	int n;
+
+	/* can't be done in parallel with OpenGL */
+	for(n = 0; n < totnode; n++) {
+		node= nodes[n];
+
+		if(node->flag & PBVH_UpdateDrawBuffers) {
+			GPU_update_buffers(node->draw_buffers,
+					   bvh->verts,
+					   node->vert_indices,
+					   node->uniq_verts +
+					   node->face_verts);
+
+			node->flag &= ~PBVH_UpdateDrawBuffers;
+		}
+	}
+}
+
+static int pbvh_flush_bb(PBVH *bvh, PBVHNode *node)
+{
+	int update= 0;
+
+	/* difficult to multithread well, we just do single threaded recursive */
+	if(node->flag & PBVH_Leaf) {
+		update= (node->flag & PBVH_UpdateBB);
+		node->flag &= ~PBVH_UpdateBB;
+		return update;
+	}
+	else {
+		update |= pbvh_flush_bb(bvh, bvh->nodes + node->children_offset);
+		update |= pbvh_flush_bb(bvh, bvh->nodes + node->children_offset + 1);
+
+		if(update)
+			update_node_vb(bvh, node);
+	}
+
+	return update;
+}
+
+void BLI_pbvh_update(PBVH *bvh, int flag, float (*face_nors)[3], ListBase *fmap)
+{
+	PBVHNode **nodes;
+	int totnode;
+
+	BLI_pbvh_search_gather(bvh, update_search_cb, NULL, &nodes, &totnode);
+
+	if(flag & PBVH_UpdateNormals)
+		pbvh_update_face_normals(bvh, nodes, totnode, face_nors);
+
+	if(flag & (PBVH_UpdateNormals|PBVH_UpdateBB|PBVH_UpdateRedraw))
+		pbvh_update_BB_normals(bvh, nodes, totnode, flag, face_nors, fmap);
+
+	if(flag & PBVH_UpdateDrawBuffers)
+		pbvh_update_draw_buffers(bvh, nodes, totnode);
+
+	if(flag & PBVH_UpdateBB)
+		pbvh_flush_bb(bvh, bvh->nodes);
+
+	if(nodes) MEM_freeN(nodes);
+}
+
+void BLI_pbvh_redraw_bounding_box(PBVH *bvh, float bb_min[3], float bb_max[3])
+{
+	PBVHIter iter;
+	PBVHNode *node;
+	BB bb;
+
+	BB_reset(&bb);
+
+	pbvh_iter_begin(&iter, bvh, NULL, NULL);
+
+	while((node=pbvh_iter_next(&iter)))
+		if(node->flag & PBVH_UpdateRedraw)
+			BB_expand_with_bb(&bb, &node->vb);
+
+	pbvh_iter_end(&iter);
+
+	VecCopyf(bb_min, bb.bmin);
+	VecCopyf(bb_max, bb.bmax);
+}
+
+/***************************** Node Access ***********************************/
+
+void BLI_pbvh_node_mark_update(PBVHNode *node)
+{
+	node->flag |= PBVH_UpdateNormals|PBVH_UpdateBB|PBVH_UpdateDrawBuffers|PBVH_UpdateRedraw;
+}
+
+void BLI_pbvh_node_get_verts(PBVHNode *node, int **vert_indices, int *totvert)
+{
+	*vert_indices= node->vert_indices;
+	*totvert= node->uniq_verts;
+}
+
+void BLI_pbvh_node_get_faces(PBVHNode *node, int **face_indices, int *totface)
+{
+	*face_indices= node->face_indices;
+	*totface= node->totface;
+}
+
+void *BLI_pbvh_node_get_draw_buffers(PBVHNode *node)
+{
+	return node->draw_buffers;
+}
+
+/********************************* Raycast ***********************************/
+
 typedef struct {
 	/* Ray */
 	float start[3];
@@ -584,7 +833,7 @@ typedef struct {
 } RaycastData;
 
 /* Adapted from here: http://www.gamedev.net/community/forums/topic.asp?topic_id=459973 */
-static int ray_aabb_intersect(float bb_min[3], float bb_max[3], void *data_v)
+static int ray_aabb_intersect(PBVHNode *node, float bb_min[3], float bb_max[3], void *data_v)
 {
 	RaycastData *ray = data_v;
 	float bbox[2][3];
@@ -637,29 +886,6 @@ void BLI_pbvh_raycast(PBVH *bvh, BLI_pbvh_HitCallback cb, void *data,
 	rcd.sign[1] = rcd.inv_dir[1] < 0;
 	rcd.sign[2] = rcd.inv_dir[2] < 0;
 
-	BLI_pbvh_search(bvh, ray_aabb_intersect, &rcd, cb, data,
+	BLI_pbvh_search_callback(bvh, ray_aabb_intersect, &rcd, cb, data);
-			PBVH_SEARCH_NORMAL);
 }
 
-int BLI_pbvh_update_search_cb(float bb_min[3], float bb_max[3], void *data_v)
-{
-	int *data = data_v;
-
-	return ((*data) & PBVH_Modified);
-}
-
-void BLI_pbvh_modified_bounding_box(PBVH *bvh, float bb_min[3], float bb_max[3])
-{
-	VecCopyf(bb_min, bvh->modified_bb.bmin);
-	VecCopyf(bb_max, bvh->modified_bb.bmax);
-}
-
-void BLI_pbvh_reset_modified_bounding_box(PBVH *bvh)
-{
-	BB_reset(&bvh->modified_bb);	
-}
-
-void BLI_pbvh_toggle_modified_lock(PBVH *bvh)
-{
-	bvh->modified_lock = !bvh->modified_lock;
-}

source/blender/editors/sculpt_paint/paint_stroke.c

@@ -234,9 +234,7 @@ int paint_stroke_modal(bContext *C, wmOperator *op, wmEvent *event)
 {
 	PaintStroke *stroke = op->customdata;
 	float mouse[2];
-
+	int first= 0;
-	if(event->type == TIMER && (event->customdata != stroke->timer))
-		return OPERATOR_RUNNING_MODAL;
 
 	if(!stroke->stroke_started) {
 		stroke->last_mouse_position[0] = event->x;
@@ -251,26 +249,27 @@ int paint_stroke_modal(bContext *C, wmOperator *op, wmEvent *event)
 				stroke->timer = WM_event_add_timer(CTX_wm_manager(C), CTX_wm_window(C), TIMER, stroke->brush->rate);
 		}
 
+		first= 1;
 		//ED_region_tag_redraw(ar);
 	}
 
-	if(stroke->stroke_started) {
+	/* TODO: fix hardcoded event here */
-		if(paint_smooth_stroke(stroke, mouse, event)) {
+	if(first || event->type == MOUSEMOVE || (event->type == TIMER && (event->customdata == stroke->timer))) {
-			if(paint_space_stroke_enabled(stroke->brush)) {
+		if(stroke->stroke_started) {
-				if(!paint_space_stroke(C, op, event, mouse))
+			if(paint_smooth_stroke(stroke, mouse, event)) {
-					;//ED_region_tag_redraw(ar);
+				if(paint_space_stroke_enabled(stroke->brush)) {
+					if(!paint_space_stroke(C, op, event, mouse))
+						;//ED_region_tag_redraw(ar);
+				}
+				else
+					paint_brush_stroke_add_step(C, op, event, mouse);
 			}
 			else
-				paint_brush_stroke_add_step(C, op, event, mouse);
+				;//ED_region_tag_redraw(ar);
 		}
-		else
-			;//ED_region_tag_redraw(ar);
 	}
-
+	else if(event->type == LEFTMOUSE && event->val == KM_RELEASE) {
-	/* TODO: fix hardcoded event here */
+		/* exit stroke, free data */
-	if(event->type == LEFTMOUSE && event->val == KM_RELEASE) {
-		/* Exit stroke, free data */
-
 		if(stroke->smooth_stroke_cursor)
 			WM_paint_cursor_end(CTX_wm_manager(C), stroke->smooth_stroke_cursor);
 
@@ -281,8 +280,8 @@ int paint_stroke_modal(bContext *C, wmOperator *op, wmEvent *event)
 		MEM_freeN(stroke);
 		return OPERATOR_FINISHED;
 	}
-	else
+
-		return OPERATOR_RUNNING_MODAL;
+	return OPERATOR_RUNNING_MODAL;
 }
 
 int paint_stroke_exec(bContext *C, wmOperator *op)