archive/blender-archive
Archived
1
1
Fork 0
Code Pull Requests Packages Activity

BLI_string: correct size for BLI_str_format_int_grouped, update tests

Browse Source 
Ensure the defines match the longest strings in tests.
This commit is contained in:
Campbell Barton
2023-03-03 10:25:47 +11:00
parent 05324e2e3c
commit 55ea58ff5b
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
source/blender/blenlib/tests/BLI_string_test.cc
View File

@@ -336,12 +336,6 @@ TEST(string, StrFormatIntGrouped)
BLI_str_format_int_grouped(number_str, number = -1);
EXPECT_STREQ("-1", number_str);
BLI_str_format_int_grouped(number_str, number = -2147483648);
EXPECT_STREQ("-2,147,483,648", number_str);
BLI_str_format_int_grouped(number_str, number = 2147483647);
EXPECT_STREQ("2,147,483,647", number_str);
BLI_str_format_int_grouped(number_str, number = 1000);
EXPECT_STREQ("1,000", number_str);
@@ -353,6 +347,14 @@ TEST(string, StrFormatIntGrouped)
BLI_str_format_int_grouped(number_str, number = -999);
EXPECT_STREQ("-999", number_str);
BLI_str_format_int_grouped(number_str, number = 2147483647);
EXPECT_STREQ("2,147,483,647", number_str);
BLI_str_format_int_grouped(number_str, number = -2147483648);
EXPECT_STREQ("-2,147,483,648", number_str);
/* Ensure the limit is correct. */
EXPECT_EQ(sizeof(number_str), strlen(number_str) + 1);
}
/* BLI_str_format_uint64_grouped */
@@ -375,6 +377,8 @@ TEST(string, StrFormatUint64Grouped)
BLI_str_format_uint64_grouped(number_str, number = 18446744073709551615u);
EXPECT_STREQ("18,446,744,073,709,551,615", number_str);
/* Ensure the limit is correct. */
EXPECT_EQ(sizeof(number_str), strlen(number_str) + 1);
}
/* BLI_str_format_byte_unit */
@@ -440,6 +444,8 @@ TEST(string, StrFormatByteUnits)
/* Test maximum string length. */
BLI_str_format_byte_unit(size_str, size = -9223200000000000000, false);
EXPECT_STREQ("-8191.8472 PiB", size_str);
/* Ensure the limit is correct. */
EXPECT_EQ(sizeof(size_str), strlen(size_str) + 1);
}
/* BLI_str_format_decimal_unit */